From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tama50.ecl.ntt.co.jp (tama50.ecl.ntt.co.jp [129.60.39.147]) by dpdk.org (Postfix) with ESMTP id 0F6AF235 for ; Fri, 7 Jul 2017 10:23:37 +0200 (CEST) Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153]) by tama50.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id v678NaXt030484; Fri, 7 Jul 2017 17:23:36 +0900 Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id 0901A5F58A; Fri, 7 Jul 2017 17:23:36 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id F10B85F69F; Fri, 7 Jul 2017 17:23:35 +0900 (JST) Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id EB4BD400C18; Fri, 7 Jul 2017 17:23:35 +0900 (JST) References: <894235f1-d439-8db2-73ab-55b16a474084@lab.ntt.co.jp> <1339a006-43f6-8fa9-73a7-c8206d51d691@intel.com> From: Yasufumi Ogawa Message-ID: Date: Fri, 7 Jul 2017 17:22:52 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1339a006-43f6-8fa9-73a7-c8206d51d691@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit To: Ferruh Yigit , sy.jong.choi@intel.com, spp@dpdk.org X-TM-AS-MML: disable Subject: Re: [spp] Proposal for adding port for external management tools X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jul 2017 08:23:38 -0000 Hi Ferruh, Thank you for your comments! I'd re-send you patches divided in my proposal feature and other refactoring ones. > Would you mind using git send-email for sending patches? Sorry for lack of my understanding. I'll try it. Thanks, Yasufumi On 2017/07/06 21:56, Ferruh Yigit wrote: > On 6/29/2017 10:16 AM, Yasufumi Ogawa wrote: >> Hi, everyone, >> >> SPP controller is a CLI tool and has no way to send a command from >> remote. Considering to control SPP from a management tool like an >> orchestrator, it should be needed to have another port. This patch is >> adding it (called management port) to SPP for the purpose. >> >> This patch also includes following bug fixes. >> - Remove unwanted spaces from the sec command to avoid parse error. >> - Add socket.SO_REUSEADDR option for avoiding 'port is already used'. >> - Correct command completion. >> - Fix errors in report/playback command. > > Hi Yasufumi, > > Thank you for the patch. > > I think adding a remote management port is good idea. > > But I am not able to apply the patch, mail client seems wrapped some > lines, I tried to fix but not able to. Would you mind using git > send-email for sending patches? > > And if possible can you please split patch into multiple patches, one > patch for each logical thing, for your case you can have a separate > patch for each fix you listed above. This makes easy to understand each > modification done for a fix or feature. > > Thanks, > ferruh > >> >> Regards, >> >> Yasufumi >> > > > -- ------------------------------------------------- Yasufumi Ogawa NTT Network Service Systems Labs tel: 0422(59)5776 fax: 0422(59)5653 email: ogawa.yasufumi@lab.ntt.co.jp -------------------------------------------------