From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69403A04A3 for ; Tue, 16 Jun 2020 11:33:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 48D881BE7D; Tue, 16 Jun 2020 11:33:38 +0200 (CEST) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id 662821BE7D for ; Tue, 16 Jun 2020 11:33:36 +0200 (CEST) Received: by mail-pl1-f193.google.com with SMTP id k1so8033065pls.2 for ; Tue, 16 Jun 2020 02:33:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=c5mH3kp+C+A0ILMIowpBaD+nAAg69rWP5LaIecf7qMw=; b=QzRWBYUJYtdGLzviqPCXu1vm+avC1epztYf+zbk+cEHChr9GyzEiOf04KEXyDTQQdu 1WCNYSXRG8E/Xa+QdRwzyzYaCsYQLnkzhITLhTMPySYB9VG1CPO7lS71SIRLqvfZAax3 vfGVJ4rMdpbCVoUeFtaQkL/OAeBX+AHCUBHCZc3Ib5xBN/G9csVYaKX9nWp9i6uS/W9I NCUXwODlcPyTJPVu7SLsLHc9EuqFeEZEWP/Fau6vCpoUJnfJtu3sezP2DI0OjpiDiBtk 8xWpqfdLLpT9Ar5Y7LMzlM5E2eFE/vnhQfZlVFVFa5R0lkApQJmG6+N+LDMXnvTVw2pc SF3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=c5mH3kp+C+A0ILMIowpBaD+nAAg69rWP5LaIecf7qMw=; b=jJda4ge1YIn4g6t9bBp4mnhNQuxzMITW3EhaPQxkQeRdZaQok3J5KNa4ADPbbTyowM 7GoQ9J93qA6ea8KTPnq9jaI8EKw4HjO2Z+BTT/D2u24aPgfbhd8tPr5PjTQazN5rPqvV Gsr7EYxQoXtX2tAOWVt5eLGmlhbUO7JilDDE8P74ZW7RgIBqk5oWhCcuvRkb95DA1zWM bMH2GKR+pnmdcUxiK+XL4s1RhYihoXRolXWLrBSzE8AGgAjEHiAO9Njv3iCaTNDDIjDQ pn1TnoZqWuq++C5hoEIZoydWQ2DbDgAWo7rZtbL7RMqNeJ7GDB74h6v7lJbwQ4APw2xr MUKQ== X-Gm-Message-State: AOAM530jK1+JKeVppkZRUObrkRxmzATfiCVmSDfPdlTiv6nXp/vF+x2v Yw51btdOR0uzz5LGXy3tPECTCDHNKQs= X-Google-Smtp-Source: ABdhPJzSjHiePGQY+Y9NSiO215kwSlTvakZP31MxtazIHvLCeVebF0YqeTlsCCXU7x4ejyTSG2/sMA== X-Received: by 2002:a17:902:c402:: with SMTP id k2mr1321023plk.89.1592300015351; Tue, 16 Jun 2020 02:33:35 -0700 (PDT) Received: from mugwort.local ([192.47.164.146]) by smtp.gmail.com with ESMTPSA id y9sm16495885pfr.184.2020.06.16.02.33.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2020 02:33:34 -0700 (PDT) To: Itsuro Oda References: <20200611233112.5976-1-oda@valinux.co.jp> Cc: spp@dpdk.org From: Yasufumi Ogawa Message-ID: Date: Tue, 16 Jun 2020 18:33:32 +0900 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: <20200611233112.5976-1-oda@valinux.co.jp> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [spp] [PATCH] tools/sppc: improvement of Dockerfile for SPP container X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spp-bounces@dpdk.org Sender: "spp" > This patch includes some improvements of Dockerfile used by > building SPP containers. > > * remove a nonexistent command path > * add some useful command paths > * specify a value of 'make -j' option of making DPDK not to > exhaust system resources by compiling processes. I totally agree with your changes, but have one thing to be confirmed. I remember that I haven't included spp_mirror and spp_pcap in apps in SPP container because I don't have tested well yet. Have you confirmed that these app run on container env? > > Signed-off-by: Itsuro Oda > --- > tools/sppc/build/ubuntu/spp/Dockerfile.16.04 | 5 +++-- > tools/sppc/build/ubuntu/spp/Dockerfile.18.04 | 5 +++-- > tools/sppc/build/ubuntu/spp/Dockerfile.latest | 5 +++-- > 3 files changed, 9 insertions(+), 6 deletions(-) > > diff --git a/tools/sppc/build/ubuntu/spp/Dockerfile.16.04 b/tools/sppc/build/ubuntu/spp/Dockerfile.16.04 > index 3e060df..7c81b3a 100644 > --- a/tools/sppc/build/ubuntu/spp/Dockerfile.16.04 > +++ b/tools/sppc/build/ubuntu/spp/Dockerfile.16.04 > @@ -19,7 +19,8 @@ ENV PATH ${rte_sdk}/${rte_target}/app:${PATH} > ENV PATH ${home_dir}/${spp_dir}/src/primary/${rte_target}/:${PATH} > ENV PATH ${home_dir}/${spp_dir}/src/nfv/${rte_target}/:${PATH} > ENV PATH ${home_dir}/${spp_dir}/src/vf/${rte_target}/:${PATH} > -ENV PATH ${home_dir}/${spp_dir}/src/vm/${rte_target}/:${PATH} > +ENV PATH ${home_dir}/${spp_dir}/src/mirror/${rte_target}/:${PATH} > +ENV PATH ${home_dir}/${spp_dir}/src/pcap/${rte_target}/:${PATH} > > WORKDIR $home_dir > RUN git clone ${dpdk_branch} ${dpdk_repo} > @@ -27,7 +28,7 @@ RUN git clone ${spp_branch} ${spp_repo} > > # Compile DPDK and SPP > WORKDIR ${rte_sdk} > -RUN make -j install T=${rte_target} > +RUN make -j 4 install T=${rte_target} > > WORKDIR ${home_dir}/${spp_dir} > RUN make -j > diff --git a/tools/sppc/build/ubuntu/spp/Dockerfile.18.04 b/tools/sppc/build/ubuntu/spp/Dockerfile.18.04 > index e35fbc2..9b90dd4 100644 > --- a/tools/sppc/build/ubuntu/spp/Dockerfile.18.04 > +++ b/tools/sppc/build/ubuntu/spp/Dockerfile.18.04 > @@ -19,7 +19,8 @@ ENV PATH ${rte_sdk}/${rte_target}/app:${PATH} > ENV PATH ${home_dir}/${spp_dir}/src/primary/${rte_target}/:${PATH} > ENV PATH ${home_dir}/${spp_dir}/src/nfv/${rte_target}/:${PATH} > ENV PATH ${home_dir}/${spp_dir}/src/vf/${rte_target}/:${PATH} > -ENV PATH ${home_dir}/${spp_dir}/src/vm/${rte_target}/:${PATH} > +ENV PATH ${home_dir}/${spp_dir}/src/mirror/${rte_target}/:${PATH} > +ENV PATH ${home_dir}/${spp_dir}/src/pcap/${rte_target}/:${PATH} > ENV DEBIAN_FRONTEND noninteractive > > WORKDIR $home_dir > @@ -28,7 +29,7 @@ RUN git clone ${spp_branch} ${spp_repo} > > # Compile DPDK and SPP > WORKDIR ${rte_sdk} > -RUN make -j install T=${rte_target} > +RUN make -j 4 install T=${rte_target} > > WORKDIR ${home_dir}/${spp_dir} > RUN make -j > diff --git a/tools/sppc/build/ubuntu/spp/Dockerfile.latest b/tools/sppc/build/ubuntu/spp/Dockerfile.latest > index a1ffc80..7e6f5ac 100644 > --- a/tools/sppc/build/ubuntu/spp/Dockerfile.latest > +++ b/tools/sppc/build/ubuntu/spp/Dockerfile.latest > @@ -19,7 +19,8 @@ ENV PATH ${rte_sdk}/${rte_target}/app:${PATH} > ENV PATH ${home_dir}/${spp_dir}/src/primary/${rte_target}/:${PATH} > ENV PATH ${home_dir}/${spp_dir}/src/nfv/${rte_target}/:${PATH} > ENV PATH ${home_dir}/${spp_dir}/src/vf/${rte_target}/:${PATH} > -ENV PATH ${home_dir}/${spp_dir}/src/vm/${rte_target}/:${PATH} > +ENV PATH ${home_dir}/${spp_dir}/src/mirror/${rte_target}/:${PATH} > +ENV PATH ${home_dir}/${spp_dir}/src/pcap/${rte_target}/:${PATH} > ENV DEBIAN_FRONTEND noninteractive > > WORKDIR $home_dir > @@ -28,7 +29,7 @@ RUN git clone ${spp_branch} ${spp_repo} > > # Compile DPDK and SPP > WORKDIR ${rte_sdk} > -RUN make -j install T=${rte_target} > +RUN make -j 4 install T=${rte_target} > > WORKDIR ${home_dir}/${spp_dir} > RUN make -j >