From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tama500.ecl.ntt.co.jp (tama500.ecl.ntt.co.jp [129.60.39.148]) by dpdk.org (Postfix) with ESMTP id 558101B349 for ; Tue, 30 Jan 2018 04:56:39 +0100 (CET) Received: from vc2.ecl.ntt.co.jp (vc2.ecl.ntt.co.jp [129.60.86.154]) by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w0U3ubau020813; Tue, 30 Jan 2018 12:56:37 +0900 Received: from vc2.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 923445F612; Tue, 30 Jan 2018 12:56:37 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc2.ecl.ntt.co.jp (Postfix) with ESMTP id 858CA5F592; Tue, 30 Jan 2018 12:56:37 +0900 (JST) Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 803EE400AD3; Tue, 30 Jan 2018 12:56:37 +0900 (JST) References: <20180122142537.20291-1-ferruh.yigit@intel.com> From: Yasufumi Ogawa Message-ID: Date: Tue, 30 Jan 2018 12:55:28 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20180122142537.20291-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-CC-Mail-RelayStamp: 1 To: Ferruh Yigit Cc: spp@dpdk.org, nakamura.hioryuki@po.ntt-tx.co.jp X-TM-AS-MML: disable Subject: Re: [spp] [PATCH] spp_vf: fix build X-BeenThere: spp@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Soft Patch Panel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jan 2018 03:56:39 -0000 On 2018/01/22 23:25, Ferruh Yigit wrote: > build error: > ...spp/src/vf/classifier_mac.c:314:5: > error: format specifies type 'unsigned short' but the argument > has type 'int' [-Werror,-Wformat] > classified_data->num_pkt - n_tx, classified_data->port); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > ...build/include/rte_log.h:316:32: > note: expanded from macro 'RTE_LOG' > RTE_LOGTYPE_ ## t, # t ": " __VA_ARGS__) > ^~~~~~~~~~~ > > Looks like caused by integer promotion, to fix cast variable > explicityly to uint16_t. Ferruh, Thanks for your contribution. Although I compiled Hiroyuki's patch with DPDK 17.11 release (tagged as v17.11) and there is no error, but error is occured after replacing DPDK latest. ...spp/src/vf/spp_vf.c:931:28: error: ‘RTE_LOG_LEVEL’ undeclared (first use in this function) rte_log_set_global_level(RTE_LOG_LEVEL); ...spp/src/vf/spp_vf.c:931:28: note: each undeclared identifier is reported only once for each function it appears in /home/dpdk1711/dpdk-home/dpdk/mk/internal/rte.compile-pre.mk:114: ... It is different from your error, but caused by rte_log. I think it is possibly because of a change of rte_log after 17.11 release. In any case, I think your change should be merged. Acked-by: Yasufumi Ogawa Thanks, Yasufumi > > Fixes: 11512d8b6c28 ("spp_vf: add vf functions") > Cc: nakamura.hioryuki@po.ntt-tx.co.jp > > Signed-off-by: Ferruh Yigit > --- > > Cc: Yasufumi Ogawa > --- > src/vf/classifier_mac.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/vf/classifier_mac.c b/src/vf/classifier_mac.c > index 2e502a5..760d597 100644 > --- a/src/vf/classifier_mac.c > +++ b/src/vf/classifier_mac.c > @@ -311,7 +311,8 @@ transmit_packet(struct classified_data *classified_data) > rte_pktmbuf_free(classified_data->pkts[i]); > RTE_LOG(DEBUG, SPP_CLASSIFIER_MAC, > "drop packets(tx). num=%hu, dpdk_port=%hu\n", > - classified_data->num_pkt - n_tx, classified_data->port); > + (uint16_t)(classified_data->num_pkt - n_tx), > + classified_data->port); > } > > classified_data->num_pkt = 0; > -- Yasufumi Ogawa NTT Network Service Systems Labs