From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/avf: fix link autoneg value
Date: Wed, 28 Mar 2018 14:25:35 +0100 [thread overview]
Message-ID: <007e15a8-b87e-ba60-5c57-76b3d3ba3a11@intel.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E70611531754F1@SHSMSX103.ccr.corp.intel.com>
On 3/28/2018 7:42 AM, Zhang, Qi Z wrote:
> Hi Ferruh:
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
>> Sent: Saturday, March 10, 2018 1:57 AM
>> To: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo
>> <wenzhuo.lu@intel.com>
>> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; stable@dpdk.org
>> Subject: [dpdk-dev] [PATCH] net/avf: fix link autoneg value
>>
>> Intention of the logic is:
>> If ETH_LINK_SPEED_FIXED is set in dev_conf, set link_autoneg to
>> ETH_LINK_FIXED, else set it to ETH_LINK_AUTONEG
>>
>> ETH_LINK_SPEED_FIXED value is 1, and ETH_LINK_FIXED is 0;
>>
>> Current logic is broken, fix it according above values.
>>
>> Fixes: 48de41ca11f0 ("net/avf: enable link status update")
>> Cc: jingjing.wu@intel.com
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>
> BTW, I saw the same issue on i40evf, will you also fix that?
It is in: https://dpdk.org/dev/patchwork/patch/36076/
>
> Thanks
> Qi
>
next prev parent reply other threads:[~2018-03-28 13:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 17:56 [dpdk-stable] " Ferruh Yigit
2018-03-28 6:42 ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z
2018-03-28 13:25 ` Ferruh Yigit [this message]
2018-03-29 5:51 ` Zhang, Helin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=007e15a8-b87e-ba60-5c57-76b3d3ba3a11@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).