From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51DDBA04A2 for ; Tue, 5 Nov 2019 07:10:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2019334F0; Tue, 5 Nov 2019 07:10:57 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id CF7C22BC7; Tue, 5 Nov 2019 07:10:53 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Nov 2019 22:10:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,270,1569308400"; d="scan'208";a="403236084" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga006.fm.intel.com with ESMTP; 04 Nov 2019 22:10:52 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 4 Nov 2019 22:10:52 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.2]) with mapi id 14.03.0439.000; Tue, 5 Nov 2019 14:10:50 +0800 From: "Wang, ShougangX" To: "Xing, Beilei" , "dev@dpdk.org" CC: "Yang, Qiming" , "Cao, Yahui" , "stable@dpdk.org" Thread-Topic: [PATCH] net/ice: fix memory release in FDIR Thread-Index: AQHVk4WFl9/8Sm9eWE+7eS+V05b+jKd7gTQAgACSo2A= Date: Tue, 5 Nov 2019 06:10:49 +0000 Message-ID: <00A8E5A1740DFA49A87AFFAC34B8EDEA3BB834@SHSMSX101.ccr.corp.intel.com> References: <20191104204347.62267-1-shougangx.wang@intel.com> <94479800C636CB44BD422CB454846E013CE80E82@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <94479800C636CB44BD422CB454846E013CE80E82@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] net/ice: fix memory release in FDIR X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, Beilei > -----Original Message----- > From: Xing, Beilei > Sent: Tuesday, November 5, 2019 1:09 PM > To: Wang, ShougangX ; dev@dpdk.org > Cc: Yang, Qiming ; Cao, Yahui > ; stable@dpdk.org > Subject: RE: [PATCH] net/ice: fix memory release in FDIR >=20 >=20 >=20 > > -----Original Message----- > > From: Wang, ShougangX > > Sent: Tuesday, November 5, 2019 4:44 AM > > To: dev@dpdk.org > > Cc: Yang, Qiming ; Xing, Beilei > > ; Cao, Yahui ; Wang, > > ShougangX ; stable@dpdk.org > > Subject: [PATCH] net/ice: fix memory release in FDIR > > > > To avoid wild pointer and memory leak, following resources management > > should be added. > > - Check if the FDIR Memzone already exists before reserving. > > - Free FDIR memzone when teardown and other failure scenarios. > > - Set pointers to NULL after free them. > > - Release all counter resources when teardown. >=20 > Thanks for the patch, but could you split the patch according to differen= t issues? >=20 > Beilei OK, I will split them in next version. Thanks. Shougang