patches for DPDK stable branches
 help / color / Atom feed
From: Ranjit Menon <ranjit.menon@intel.com>
To: Tal Shnaiderman <talshn@nvidia.com>, dev@dpdk.org
Cc: thomas@monjalon.net, pallavi.kadam@intel.com,
	dmitry.kozliuk@gmail.com, navasile@linux.microsoft.com,
	dmitrym@microsoft.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] bus/pci: clear undefined bits in Windows segment parsing
Date: Wed, 14 Oct 2020 13:44:45 -0700
Message-ID: <00e4029d-26cc-db01-3a07-493c8f11c4d0@intel.com> (raw)
In-Reply-To: <20201014193001.13820-1-talshn@nvidia.com>


On 10/14/2020 12:30 PM, Tal Shnaiderman wrote:
> When reading bus and segment values using SPDRP_BUSNUMBER
> bits 24-31 are undefined.
>
> They are cleared to verify we read the segment number correctly.
>
> Fixes: c3adf8144a1 ("bus/pci: support segment value as address domain on Window")
> Cc: stable@dpdk.org
>
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
>   drivers/bus/pci/windows/pci.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/pci/windows/pci.c b/drivers/bus/pci/windows/pci.c
> index 2cd010a09b..2b0a7a7c86 100644
> --- a/drivers/bus/pci/windows/pci.c
> +++ b/drivers/bus/pci/windows/pci.c
> @@ -195,7 +195,7 @@ get_device_pci_address(HDEVINFO dev_info,
>   		return -1;
>   	}
>   
> -	addr->domain = bus_num >> 8;
> +	addr->domain = (bus_num >> 8) & 0xffff;
>   	addr->bus = bus_num & 0xff;
>   	addr->devid = dev_and_func >> 16;
>   	addr->function = dev_and_func & 0xffff;

Acked-by: Ranjit Menon <ranjit.menon@intel.com>


  reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-14 19:30 Tal Shnaiderman
2020-10-14 20:44 ` Ranjit Menon [this message]
2020-10-15 18:45 ` Narcisa Ana Maria Vasile
2020-10-16 10:22   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00e4029d-26cc-db01-3a07-493c8f11c4d0@intel.com \
    --to=ranjit.menon@intel.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=dmitrym@microsoft.com \
    --cc=navasile@linux.microsoft.com \
    --cc=pallavi.kadam@intel.com \
    --cc=stable@dpdk.org \
    --cc=talshn@nvidia.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox