From: Kevin Traynor <ktraynor@redhat.com>
To: Yajun Wu <yajunw@nvidia.com>, stable@dpdk.org
Cc: Matan Azrad <matan@nvidia.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH 21.11] vdpa/mlx5: workaround var offset within page
Date: Tue, 28 Jun 2022 15:58:03 +0100 [thread overview]
Message-ID: <011bc6c7-66b8-8ecd-372c-ce1ac834231e@redhat.com> (raw)
In-Reply-To: <20220628024748.2424880-1-yajunw@nvidia.com>
On 28/06/2022 03:47, Yajun Wu wrote:
> [ upstream commit 95af59b7ad9f6a465de2ead9ef709429678e750d ]
>
> vDPA driver first uses kernel driver to allocate doorbell(VAR) area for
> each device. Then uses var->mmap_off and var->length to mmap uverbs device
> file as doorbell userspace virtual address.
>
> Current kernel driver provides var->mmap_off equal to page start of VAR.
> It's fine with x86 4K page server, because VAR physical address is only 4K
> aligned thus locate in 4K page start.
>
> But with aarch64 64K page server, the actual VAR physical address has
> offset within page(not locate in 64K page start). So vDPA driver need add
> this within page offset(caps.doorbell_bar_offset) to get right VAR virtual
> address.
>
> Fixes: 62c813706e4 ("vdpa/mlx5: map doorbell")
>
> Signed-off-by: Yajun Wu <yajunw@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
Applied, thanks.
prev parent reply other threads:[~2022-06-28 14:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 2:47 Yajun Wu
2022-06-28 14:58 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=011bc6c7-66b8-8ecd-372c-ce1ac834231e@redhat.com \
--to=ktraynor@redhat.com \
--cc=matan@nvidia.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=yajunw@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).