From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38EACA057D for ; Tue, 28 Jun 2022 16:58:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33EC840042; Tue, 28 Jun 2022 16:58:09 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id BF79F40042 for ; Tue, 28 Jun 2022 16:58:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656428287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=irIsE7/wL+NOXGoIlO3it5XCcQPJG/Fj5z7icmJOocM=; b=aOtBbshJb6AhUZ3iPtrl1YIxq/U8JAoktrsAMuknPXcgXLIySQ4sAnepvZtgke+z5ofDOP n43iVYOBAYkC2rAEeyRNwjiYn7B1XlEIE0flOBvxDmvZkQUB8MT32Cxo17RfUD9u7zDbhE tRfHMz2/BIfPoxKw9H1Xj7mYPRcRoW4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-616-94p1LuulPCeS8eWGWyR_DA-1; Tue, 28 Jun 2022 10:58:06 -0400 X-MC-Unique: 94p1LuulPCeS8eWGWyR_DA-1 Received: by mail-wm1-f69.google.com with SMTP id 10-20020a1c020a000000b003a03f8cc1acso5673066wmc.6 for ; Tue, 28 Jun 2022 07:58:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=irIsE7/wL+NOXGoIlO3it5XCcQPJG/Fj5z7icmJOocM=; b=EI7+HVaxMmBdLyoBlfp1O8bbl226uT4SnQeMtKPBsF/thw5uHQe4wVim5Ufuoz9es0 ERma6NbiI8UuGB3Kxvo1UQ1Mu/4OPqEN6F237Zuy+3VgaewgaudZQH4vBeG6xXjq63MW FCC16BoB9etunq2qbdcamYrCsmYv9fkx5zSLCUQed4LyB4pWzhI0UYsjnmvoxU3eQA7n wubs7IyXgN9rxGN5nV0Udn73l5WveTMyR4oMwfPstJxxgAKakIMVQqyg2HRzA8Y1zo7O iRN7STKzpg7+hxFWxQcytRAJkeKokeNlQdw7LU5q0qm7SJ3U0KvrAWn80tGXpzDNnLCi 6how== X-Gm-Message-State: AJIora8EHkVB5rK/fptqR/bB3poaxmQXqDY5VL12ahOwxb5vNUwqb4vI GuG6FZebjnH9ojpqJW/z7UlNwcOfMgIm4wZgwrTq6jDyHTCvOknixHPukh6zFrHf/J+HdAR3rII 3mlKo76c= X-Received: by 2002:adf:db8e:0:b0:21b:4e5b:a438 with SMTP id u14-20020adfdb8e000000b0021b4e5ba438mr18272305wri.247.1656428284526; Tue, 28 Jun 2022 07:58:04 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uwj7hAdDHuwsecYnE0OlLdojXEO3dEsvA08te60XboxwXKamid4zOKeYg0Wq3gFHGiSX4hRA== X-Received: by 2002:adf:db8e:0:b0:21b:4e5b:a438 with SMTP id u14-20020adfdb8e000000b0021b4e5ba438mr18272284wri.247.1656428284347; Tue, 28 Jun 2022 07:58:04 -0700 (PDT) Received: from [192.168.0.36] ([78.17.181.1]) by smtp.gmail.com with ESMTPSA id e2-20020adfdbc2000000b0021b9f126fd3sm14223360wrj.14.2022.06.28.07.58.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jun 2022 07:58:03 -0700 (PDT) Message-ID: <011bc6c7-66b8-8ecd-372c-ce1ac834231e@redhat.com> Date: Tue, 28 Jun 2022 15:58:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH 21.11] vdpa/mlx5: workaround var offset within page To: Yajun Wu , stable@dpdk.org Cc: Matan Azrad , Maxime Coquelin References: <20220628024748.2424880-1-yajunw@nvidia.com> From: Kevin Traynor In-Reply-To: <20220628024748.2424880-1-yajunw@nvidia.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 28/06/2022 03:47, Yajun Wu wrote: > [ upstream commit 95af59b7ad9f6a465de2ead9ef709429678e750d ] > > vDPA driver first uses kernel driver to allocate doorbell(VAR) area for > each device. Then uses var->mmap_off and var->length to mmap uverbs device > file as doorbell userspace virtual address. > > Current kernel driver provides var->mmap_off equal to page start of VAR. > It's fine with x86 4K page server, because VAR physical address is only 4K > aligned thus locate in 4K page start. > > But with aarch64 64K page server, the actual VAR physical address has > offset within page(not locate in 64K page start). So vDPA driver need add > this within page offset(caps.doorbell_bar_offset) to get right VAR virtual > address. > > Fixes: 62c813706e4 ("vdpa/mlx5: map doorbell") > > Signed-off-by: Yajun Wu > Acked-by: Matan Azrad > Reviewed-by: Maxime Coquelin > --- Applied, thanks.