From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F71DA09D9 for ; Wed, 11 Nov 2020 12:51:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 83790F90; Wed, 11 Nov 2020 12:51:58 +0100 (CET) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by dpdk.org (Postfix) with ESMTP id 2DCD8F90 for ; Wed, 11 Nov 2020 12:51:56 +0100 (CET) Received: by mail-wm1-f54.google.com with SMTP id c16so2067421wmd.2 for ; Wed, 11 Nov 2020 03:51:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=aiLBZWwvzz7y6NuKsbTZcKBHbXmMAyxc3nYgetKQy8U=; b=mJ7debXb8J6hvzH3Y6zrO073O/FxH8XvgsiUAPbgArdeURM8d+D5SZYkQtASbmeaWA xGlQp2Nt9XSdLMVqS5Mlr09e8y4RmI5j3n9Lws9p3u9WIFAky58R7qXoqV99uetlpbYQ 8LY9vFzWxjrpV829U15W8eKt+Aeo6J5UozNO3IVfGpzX3Iqpg06TS+KqvcwNB7Lir9Ym Nt1+1u6vvGct9WLxo0FlOI651q4mfWXLBsvtkxOVnCMEhf7XGJTJx1QRkha9DAXRqK89 1oQXIcj6Q7vY7L35Q6b5/JoDNJoYl+NX0u/wR9NJySAM7tX2nHmZzScmRElzSZw/3Ua3 PWtA== X-Gm-Message-State: AOAM533Wki5LwFD85k4Nsryz6wke1sQiMb197ETet1f9ulD6PXkOUbGe yJX3Gfa1pC1spXqNA172lGE= X-Google-Smtp-Source: ABdhPJwZuK1hDdQ/0m+EmiM80JWiTRGGtaMQ305Wwmd44GynM8x643ExkT4xSL1AJpgLtCdhb9RL+A== X-Received: by 2002:a1c:bd08:: with SMTP id n8mr3666239wmf.136.1605095514967; Wed, 11 Nov 2020 03:51:54 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id r1sm2225039wrt.6.2020.11.11.03.51.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 03:51:53 -0800 (PST) Message-ID: <0331f3ff3f58461e9b1e7679418c350fb513344e.camel@debian.org> From: Luca Boccassi To: Kevin Traynor , David Marchand , Bruce Richardson Cc: Wei Ling , Ferruh Yigit , dpdk stable Date: Wed, 11 Nov 2020 11:51:53 +0000 In-Reply-To: <959611dc-44c8-8ec7-b4a5-8f01c1951e12@redhat.com> References: <20201105124015.306404-1-ktraynor@redhat.com> <20201105124015.306404-15-ktraynor@redhat.com> <3442a619-0beb-8441-5752-d709a850fe75@redhat.com> <959611dc-44c8-8ec7-b4a5-8f01c1951e12@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] patch 'app/testpmd: fix name of bitrate library in meson build' has been queued to LTS release 18.11.11 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Wed, 2020-11-11 at 10:50 +0000, Kevin Traynor wrote: > On 11/11/2020 10:44, Kevin Traynor wrote: > > On 05/11/2020 13:22, David Marchand wrote: > > > On Thu, Nov 5, 2020 at 1:41 PM Kevin Traynor wr= ote: > > > > From 1bde6247b23c54adb47fa48a5373270ca05a32b4 Mon Sep 17 00:00:00 2= 001 > > > > From: Bruce Richardson > > > > Date: Wed, 2 Sep 2020 17:24:27 +0100 > > > > Subject: [PATCH] app/testpmd: fix name of bitrate library in meson = build > > > >=20 > > > > [ upstream commit 54f89e3df4b16e9079c9d343870d16757429b68b ] > > > >=20 > > > > The bitrate library in DPDK is actually in a "bitratestats" directo= ry, > > > > so that is used by meson for the macro and library name. > > > > Therefore, we need to update references to RTE_LIBRTE_BITRATE to > > > > RTE_LIBRTE_BITRATESTATS in testpmd to have it found. Rather than > > > > supporting both defines, since make is being removed, we can just > > > > replace all instances of the former define with the latter. > > > >=20 > > > > To ensure testpmd links ok when this is done, we also need to add > > > > bitratestats to the list of library dependencies. > > >=20 > > > This backport will fix meson builds, but it will drop bitratestats > > > support in testpmd built with make. > > >=20 > > >=20 > >=20 > > Thanks David. That would be a user visible regression, so we can't do > > that. I will drop the patch for now and we can discuss after 20.11 when > > everyone is less busy. > >=20 >=20 > +Luca, fyi, this patch is in 19.11 tree. Thanks for the heads-up, I'll revert it for now. --=20 Kind regards, Luca Boccassi