From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Zhao1, Wei" <wei.zhao1@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-stable] [PATCH v5] net/ixgbe: fix over using multicast table for VF
Date: Mon, 7 Jan 2019 08:19:41 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E7061153316873@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1546845776-19013-1-git-send-email-wei.zhao1@intel.com>
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Monday, January 7, 2019 3:23 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH v5] net/ixgbe: fix over using multicast table for VF
>
> According to the current implementation, all VFs will set bit
> IXGBE_VMOLR_ROMPE during initialization, this cause any VF will accept packets
> that match the MTA table. Since the MTA table is shared by all VFs which means if
> one VF update MTA table in function ixgbe_vf_set_multicast, then all other VFs
> will receive multicast packets which cause unnecessary performance overhead.
>
> So it's better to set VF's ROPE bit of register VMOLR only if multicast address filter
> is required on that VF.
> Also, the ROPE bit should be reset when multicast address filter is requested to
> clean.
>
> This patch also aligns to the related fix on ixgbe kernel driver 5.3.7.
>
> Fixes: 00e30184daa0 ("ixgbe: add PF support")
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com
Applied to dpdk-next-net-intel.
Thanks
Qi
next prev parent reply other threads:[~2019-01-07 8:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <11546839569-13787-1-git-send-email-wei.zhao1@intel.com>
2019-01-07 6:16 ` [dpdk-stable] [PATCH v4] net/ixgbe: fix multicast table enable error " Wei Zhao
2019-01-07 7:21 ` [dpdk-stable] [PATCH v5] net/ixgbe: fix over using multicast table " Wei Zhao
2019-01-07 7:22 ` Wei Zhao
2019-01-07 8:19 ` Zhang, Qi Z [this message]
2019-01-07 7:33 ` [dpdk-stable] [PATCH v4] net/ixgbe: fix multicast table enable error " Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E7061153316873@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).