patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH v1] net/ice: fix burst Tx descriptor set issue
@ 2020-07-31  4:27 Haiyue Wang
  2020-07-31  5:56 ` Zhang, Qi Z
  0 siblings, 1 reply; 2+ messages in thread
From: Haiyue Wang @ 2020-07-31  4:27 UTC (permalink / raw)
  To: dev, qiming.yang, qi.z.zhang
  Cc: ting.xu, chenmin.sun, yinan.wang, Haiyue Wang, stable

The variables 'td_offset' and 'td_tag' should be reset to 0 for every
burst packet, otherwise the fields of Tx Descriptor will be set wrong,
this will cause the MDD event error, and Tx will hang.

Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
Cc: stable@dpdk.org

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 drivers/net/ice/ice_rxtx.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index bcb67ec25..b83c5c862 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -2431,6 +2431,8 @@ ice_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
 		tx_pkt = *tx_pkts++;
 
 		td_cmd = 0;
+		td_tag = 0;
+		td_offset = 0;
 		ol_flags = tx_pkt->ol_flags;
 		tx_offload.l2_len = tx_pkt->l2_len;
 		tx_offload.l3_len = tx_pkt->l3_len;
-- 
2.28.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-stable] [PATCH v1] net/ice: fix burst Tx descriptor set issue
  2020-07-31  4:27 [dpdk-stable] [PATCH v1] net/ice: fix burst Tx descriptor set issue Haiyue Wang
@ 2020-07-31  5:56 ` Zhang, Qi Z
  0 siblings, 0 replies; 2+ messages in thread
From: Zhang, Qi Z @ 2020-07-31  5:56 UTC (permalink / raw)
  To: Wang, Haiyue, dev, Yang, Qiming
  Cc: Xu, Ting, Sun, Chenmin, Wang, Yinan, stable



> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Friday, July 31, 2020 12:27 PM
> To: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: Xu, Ting <ting.xu@intel.com>; Sun, Chenmin <chenmin.sun@intel.com>;
> Wang, Yinan <yinan.wang@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>; stable@dpdk.org
> Subject: [PATCH v1] net/ice: fix burst Tx descriptor set issue
> 
> The variables 'td_offset' and 'td_tag' should be reset to 0 for every burst packet,
> otherwise the fields of Tx Descriptor will be set wrong, this will cause the MDD
> event error, and Tx will hang.
> 
> Fixes: 17c7d0f9d6a4 ("net/ice: support basic Rx/Tx")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-31  4:27 [dpdk-stable] [PATCH v1] net/ice: fix burst Tx descriptor set issue Haiyue Wang
2020-07-31  5:56 ` Zhang, Qi Z

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox