From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49279A0C41 for ; Thu, 30 Sep 2021 15:50:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1AE8B410E5; Thu, 30 Sep 2021 15:50:50 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 690FD410E5; Thu, 30 Sep 2021 15:50:49 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id CD4BF7F514; Thu, 30 Sep 2021 16:50:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru CD4BF7F514 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1633009849; bh=TEwPWnpOP2SVdyzujPqQU99B7E9Vu2/HzzsXTp4xC8k=; h=Subject:From:To:Cc:References:Date:In-Reply-To; b=QRCe/09y9caTpdKrvoBn6E5vOX1M8g8r6XFKmkciQE8aRbwinnLI8hBxGZCPWLneb 3jrZdeIVR86d+P786tQhSFmd0mUg0BQAXgIA7pgh0wXSMTOmoyDJ02H9cBfanjTtem mH65vkaFjfP5pkNebifaEnzqudkWoBvTOOsw9En0= From: Andrew Rybchenko To: Ferruh Yigit , Stephen Hemminger Cc: Rasesh Mody , Shahed Shaikh , Hemant Agrawal , Sachin Saxena , Haiyue Wang , Gagandeep Singh , John Daley , Hyong Youb Kim , Beilei Xing , Jingjing Wu , Qiming Yang , Qi Zhang , Shijith Thotton , Srisivasubramanian Srinivasan , Zyta Szpak , Liron Himi , Harman Kalra , Xiao Wang , Thomas Monjalon , dev@dpdk.org, stable@dpdk.org References: <20210928141627.904787-1-andrew.rybchenko@oktetlabs.ru> <20210928164854.1092217-1-andrew.rybchenko@oktetlabs.ru> <20210928101054.0f6ad088@hermes.local> <20f9d684-4a15-b870-672f-7301bd0503a0@oktetlabs.ru> <4b39a7ed-2367-b3f2-10d6-6f3d5fc719be@intel.com> Organization: OKTET Labs Message-ID: <040e1bb1-dc45-7dff-ee60-e9d82d4ae027@oktetlabs.ru> Date: Thu, 30 Sep 2021 16:50:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] drivers/net: remove queue xstats auto-fill flag X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 9/30/21 4:45 PM, Andrew Rybchenko wrote: > On 9/30/21 4:00 PM, Ferruh Yigit wrote: >> On 9/29/2021 7:38 AM, Andrew Rybchenko wrote: >>> On 9/28/21 8:10 PM, Stephen Hemminger wrote: >>>> On Tue, 28 Sep 2021 19:48:54 +0300 >>>> Andrew Rybchenko wrote: >>>> >>>>> Some drivers do not provide per-queue statistics. So, there is no point >>>>> to have these misleading zeros in xstats. >>>>> >>>>> Fixes: f30e69b41f94 ("ethdev: add device flag to bypass auto-filled queue xstats") >>>>> Cc: stable@dpdk.org >>>>> >>>>> Signed-off-by: Andrew Rybchenko >>>> Really? >>>> It is useful to have zeros rather than random data there. >>> >>> I guess there is a misunderstanding here. Auto-filling xstats is >>> an addition of per-queue basic statistics to xstats by ethdev >>> layer. It makes sense to do it if and only if there is some >>> sensible data there. >>> >>> There is a related deprecation notice saying that per-queue >>> stats should be removed from basic stats since per-queue >>> stats should be provided by xstats API natively. >>> >>> Basically RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS means >>> that corresponding driver is not ready vs the deprecation notice. >>> So, I want to clean it up to see not yet ready drivers only. >>> >> >> As you said, 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag set by driver means, >> driver is not ready on representing queue stats in xstats and ethdev layer is >> filling it automatically from basic stats. >> >> First we should wait for drivers to implement it, later clean queue stats from >> basic stats and remove the flag. >> >> I am not sure if we can remove the deprecation notice in this release, but agree >> to add a deadline for the drivers, which can be 22.11. >> > > I'm going to cleanup deprecation. I don't touch it in the Sorry "I'm NOT going to ..." > patch. I just want to cleanup list of drivers which > require attention/changes. Drivers covered here do not > provide per-queue stats in basic stats. So, there is no > point to set the flag to show it in xstats. >