patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>, <dev@dpdk.org>,
	"dpdk stable" <stable@dpdk.org>
Subject: Re: [PATCH] rib: fix traversal with /32 route
Date: Tue, 26 Apr 2022 15:30:27 +0100
Message-ID: <04cfa5fd-6e77-72df-f555-ea8f4d6a4b5b@intel.com> (raw)
In-Reply-To: <ec2a9cb9-22f6-4cad-8e54-2446428f403e@intel.com>

Fixes: 5a5793a5ffa2 ("rib: add RIB library")

On 26/04/2022 15:28, Medvedkin, Vladimir wrote:
> +Cc:stable@dpdk.org
> 
> On 14/04/2022 21:01, Stephen Hemminger wrote:
>> If a /32 route is entered in the RIB the code to traverse
>> will not see that a a end of the tree. This is due to trying
>> to do a negative shift which is an undefined in C.
>>
>> Fix by checking for max depth as is already done in rib6.
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>> ---
>>   lib/rib/rte_rib.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/lib/rib/rte_rib.c b/lib/rib/rte_rib.c
>> index cd9e823068d2..0603980cabd2 100644
>> --- a/lib/rib/rte_rib.c
>> +++ b/lib/rib/rte_rib.c
>> @@ -71,6 +71,8 @@ is_covered(uint32_t ip1, uint32_t ip2, uint8_t depth)
>>   static inline struct rte_rib_node *
>>   get_nxt_node(struct rte_rib_node *node, uint32_t ip)
>>   {
>> +    if (node->depth == RIB_MAXDEPTH)
>> +        return NULL;
>>       return (ip & (1 << (31 - node->depth))) ? node->right : node->left;
>>   }
> 
> Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> 

-- 
Regards,
Vladimir

  reply	other threads:[~2022-04-26 14:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220414200104.245071-1-stephen@networkplumber.org>
2022-04-26 14:28 ` Medvedkin, Vladimir
2022-04-26 14:30   ` Medvedkin, Vladimir [this message]
2022-06-01  7:04     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04cfa5fd-6e77-72df-f555-ea8f4d6a4b5b@intel.com \
    --to=vladimir.medvedkin@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git