From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD107A034E for ; Tue, 14 Dec 2021 15:52:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D3AB4113D; Tue, 14 Dec 2021 15:52:50 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 66A044003C; Tue, 14 Dec 2021 15:52:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639493567; x=1671029567; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=/LHDly1mbopWFyDkT85iCDVEU4aBPZJ2/KWsgG22yK0=; b=D2KDqQfYOR6l+BkgPhVavfldqC9V4DG34eMMPMM/su40BfTuskOQQgdA K5QLVqWrIRGqVXU/BXpD4SZY3UyS0475GJ1y8wNodXuIx1+lAteAHkqHL au6MNmzoBSnukHtMk15I4inURWC87FufYKiullbC4vHR28sCsSg34S7DW jQXtasOYJbqvkTxgXR9NOkEgnbRkhmKJnRo+IKQ27ubNFpP/28UTCmgyR DK+Oala/u9Sa82E3i386jttpVtm+0LZkMzAjBmA6xASCLAobv+2reNmo4 /xzwP/6lxD6KnIA0nuU4ln2kiSJUK5fHe+8YbZ6if0/HH9gmQHrIl0Sis A==; X-IronPort-AV: E=McAfee;i="6200,9189,10197"; a="263132431" X-IronPort-AV: E=Sophos;i="5.88,205,1635231600"; d="scan'208";a="263132431" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2021 06:52:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,205,1635231600"; d="scan'208";a="661403058" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga001.fm.intel.com with ESMTP; 14 Dec 2021 06:52:45 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 14 Dec 2021 06:52:45 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 14 Dec 2021 06:52:45 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 14 Dec 2021 06:52:45 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RSPLYm1N4MvvzzWbePUjTsoI5zGFgHtYysiHhdp6S7dog4ne6ZK/Ax4a/K+CRvgawRFfqc6UQv3czGifzDJZGUF/Xv2BDF/LLt8jJz0ITJj9p7x8Sy9EnGGGa4EbBoHv6QGx4JkSPeS2Fu/kRpdo5rW3LVKI40XXGIazNFd/kJIdkM/RtL6uqWNtvoUDr0v7E+NJDI8NO8X9qCpbbOOeAGlw/2OiBnfl3bN4f2npFgxDqVJBDuHv/d99YmzVTa+qX+55pa2UdvCs7xT8ChmA4MxAThCARlS8aIEBJJFDr13S5vX6r0nwbDIaGnkInFxM4HTo8x66Lb63H+lys2la5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T8ogb0BcLoTcAlCvM/CkljGfh1+SkBkiy872hRVgpFY=; b=VgP0U9n0xWogiTNPVzNkb7i75kngqGVPF9KdiSXpKXv/uvODSnW75gKfS12PI+cECYB+3brqUmWG5O05FlR6OANmOvg4rGbUKIFiAHFloLSG1xP9ZMtNDkD9KYXgeRo99L3Sh6KyXxK6yIV5fAbOvGQ8Kd8VxwufIuTTWgUvWdB4nXqMGT/7LmTlhk6xGJmYBgOaKwYdbHs6nV+7OiN6NKJXIvOAE3Gpet9pzay5k8a8wHyX8zOqipIU+kBgc5E4TKZy7+RYZjRhFR2T4zLCaQ1ryBIXk28kgclPaRcAv6ir6SUzLojnQ9TD7QzX3VsTrrsj1W12CeOqqkZmMUewcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T8ogb0BcLoTcAlCvM/CkljGfh1+SkBkiy872hRVgpFY=; b=dEs0rSiPW2rDlaUDyUbXPUgnBJ1qMFN0lT3NQaK+fHs8ExWXquQQLIiKbIAz/EQX+vHP2Vbghxm6LfZz72ah+6gi1iDddpHMSOCOcH+PyGIERHLRWqP/3ovuS11pBxDZWQpRA0Phn4d2/auVjxqxSLMLWd5Pl4dgxPVGJOOA1YY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4983.namprd11.prod.outlook.com (2603:10b6:510:40::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4801.14; Tue, 14 Dec 2021 14:52:42 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021 14:52:42 +0000 Message-ID: <04da027a-d9c0-5fe2-ec8c-1e72c66bfcbb@intel.com> Date: Tue, 14 Dec 2021 14:52:33 +0000 Content-Language: en-US To: Christian Ehrhardt CC: Kalesh Anakkur Purayil , "Abhishek Marathe" , Akhil Goyal , Ali Alnubani , David Christensen , Hariprasad Govindharajan , Hemant Agrawal , Ian Stokes , Jerin Jacob , John McNamara , Ju-Hyoung Lee , Kevin Traynor , Luca Boccassi , Pei Zhang , Raslan Darawsheh , Thomas Monjalon , , dpdk stable , dpdk-dev , , , , References: <20211209144315.3424225-1-christian.ehrhardt@canonical.com> <7bf4583f-c2de-0aa7-fb00-bf3e9ff8d99b@intel.com> <34e0a9a8-327e-0150-b18a-dc3bfdca7d11@intel.com> <43d82514-b3e0-1bbd-1351-f1221bfc53db@intel.com> <5ac74587-4a18-3e0b-f674-73f927a11f95@intel.com> <9f445304-f5d6-49a7-1f0f-65db8725d1ca@intel.com> From: Ferruh Yigit Subject: Re: 19.11.11 patches review and test X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0446.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::26) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3371744b-68ff-4644-d89f-08d9bf11618f X-MS-TrafficTypeDiagnostic: PH0PR11MB4983:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZecbzfGEUCMPbsQSBLTPfvIdrpP4blFgUeaPJOOjLTo9EsYG7fej54nrgL0mEHucv1uhgaUebCTAdXHP99XsFnBtr10boyJQQ395Y6A6tYPJ71A/B0skSKFc38xIVCYxyFyxqL12nLVCbWITXiZhLygyjQ4XqZzgLd8RS14nM4mxJ/yYWD9iiEZBmMJxNVjcB+gLM7DbkyncoUfyKzYZlZFFg7tcesCFnuqo6n6f8mnUy5oQ5yPD4dtbma0pDP3jARuG7GHtJ55X/cr4COgkK9aqJuFa5dlopIeynpbgGAOn1yprUWHJDGDSkwLgHlDKB9nQ/zfb7SWldrxXRPTzsWI5EWbjDDKlohf+qsODg1y/OqN+Vkvhwpu2TAGImaGdlDnFqpn8pxL9TQlaTT3h73yvHsHqGBMP49rBtpv4HS3DT/Z43h/yhQgCBGlJZ1F5zX2rihNIFno6S2QoX0hlhzuzCqoGxxwztoSM7GX/4OjC6h4M5Vju9CNYzslQy08WZW9Uvufk0DbYWGz1ZtdYbZwJIVL07Nq5NTSsijyZYP1taxEnfaYm5psJESbLzPUTB3wzdxBKsXW6jmrkfp+lUUUmDdbcaf4SGDc3j0/QTO+pHONg3b1RccGt3QmXOOxR2pKoJ5gfi++psDoQR8c2TxZl+MgxnZI9oNxS764WHIhgB6UDKil8Q4gPBR2Szr1pm+Hh56s8zAmG+pHPTCFsrzk9r6OyCsbxmO3qDtV+mgoPCxftoj6EcBO+BoHnozwA3KX8Yr+LQRbtuXVhL0ZGm/iEPmeyNLJnwv1UVRw8+b6CJsqPUzh1GoxodF6u2d7iQqgp7Q+BspQu090KzOt0CA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(5660300002)(8936002)(107886003)(8676002)(4326008)(26005)(7416002)(186003)(508600001)(66946007)(54906003)(66556008)(53546011)(316002)(66476007)(6512007)(6506007)(44832011)(6666004)(966005)(6916009)(2906002)(83380400001)(31686004)(31696002)(2616005)(86362001)(38100700002)(36756003)(82960400001)(6486002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YTdHOFRFMmxOL0ExRm1mQXBXbzFUMG9TZXZGK29raTBIeHlKNkd6ZzNwbm1P?= =?utf-8?B?eUlBVHRJUmkvSjlxNUZGeFh3dHVoeVhNdlExV1N5dWw2NytuVVk3VXBNNGph?= =?utf-8?B?VWRxRXEyMllSd0FnR0VsVnhBNWRBem13MHVFT1c2ZmF0elc2S1NHSVdna0Rq?= =?utf-8?B?bDNWckszNnBKcHRXRjAwcXJncUhLL3NPQVhMVmlFMHhxblNFRE1nK1BkRDR6?= =?utf-8?B?aHZGU1BVZmpxM3J1Ynk2ekR1a01JVExiRzJuM3VqRzllemgvT2ZTa1dpMW0z?= =?utf-8?B?Y2t0YWxISGFQNFlGOFV1Wi9KWlhKQ3NDelBsbkV3bzh6UUx3OVJGRC9GN2pQ?= =?utf-8?B?ZjdzZ1BGayticGNXQ3o0UlhRZXBGTVZqQy9ySTh4endqbWwxdjJHeDB6ZCtZ?= =?utf-8?B?Yy92cE4yc1JzaGN1SEc4QVJkOGI5Nk9VNnJHZW8rK2F5NWpFQkpCSVhpaFJQ?= =?utf-8?B?YVJ2MGQ3b2xaaUxxWEVTQ0hlbWdTZHptZ0JqK3Q1dHVFOTBYNmwzWlVyaWEw?= =?utf-8?B?b1hQdjFzVEswTC9tWDZFVlJXSnJCd2x4Ym5Ka0JxVElDMDJ4a1VMR2ZQaStH?= =?utf-8?B?czNRbmVUM2c0Z2NUTnFPNXV2bGdURXpGQlRZNy9OOTczKy9yL0hnV05SZEsy?= =?utf-8?B?S0J0MGhCdGN6RmlBRHhpS2FMQ1U4WFdxUXBBTjQyYlJ0VjJmQ2RneVovWDR0?= =?utf-8?B?cnVlNjJ3T3ZWUkpkdVFlcVBXb0R1VE81Q3lqMVlYNjh6SUpCQ1VNeXRpNWQy?= =?utf-8?B?WUdHMXV1SThNNUxyWGJFeGFlVUNMWlIvZkVEcTBVcVVmTGFQMlcvZWNldXdF?= =?utf-8?B?dHJTMjFMT2xqNkV5MHREdU1OVWRSUDRleGhaM29kZm9namJSUmhLQm15cmNF?= =?utf-8?B?NXgyNHB4QTU0cWRVUGtxTEZZaVNkQWtxMUo3ajBzYkFSMkNSblNZazc5akJU?= =?utf-8?B?aDRidFJTMms2N1gwTUk3bHIwcFJDRldyNUJSL0RUVXJoSTF6eTlrbFB5N2NY?= =?utf-8?B?VjNQZ1lGOHFkUkZSMnRIK1FBUTM0WUpvS1I0TmkxQU5rVVllZnBMVGpmYTZ4?= =?utf-8?B?d29xNTVUdWdDL09BYVpjYkEweGx1VFBoUmhIa3dCcWFOVmdwNnVoaHR0dVZF?= =?utf-8?B?T2VpWkVLbW84bm5yYnZlbk1NMFZnQjdnWHNxRWhSS1EvNlgzSnJ2V0JkVG5E?= =?utf-8?B?U0ZBck1HSGk3YWZhNVgzaC82bDhVNWg1TWhQTUYzK2hDMUNyVGppMFBrTEoz?= =?utf-8?B?Vm4zWmxLVk9yeCtwTGF3WDZjak1hQmRtemcrT25BelVnNXUxaXRaZjNlUzF0?= =?utf-8?B?SGdKZ1FYa1RtOXlMVzZPbUhhMkJmQ0p5WVJUT3ZrK3lKZCs1YmsrMGJkNkwv?= =?utf-8?B?S2kzWUNTTTFIYjF1QXQ0QnNDWEV5NG94VGJRSlIrZjZKenJFeTkrYU5mcGFJ?= =?utf-8?B?Q0t3NGlMMzRhcmd2MjFNYkY2ZjNKZWVQaTF4eDYyODc4NWR4SEFVK3Uvd2pL?= =?utf-8?B?b1BCVkNYN3FGVnhIQjhLZHk4ak5SZnJabkJSN3pPbGtKS05SSVVudWliVHhB?= =?utf-8?B?ZGx1aEEzZHNpenUxZ2FxNFdjMmwxQ01CYUZ5TU5KVHdqN1ltalgxRCtURnN2?= =?utf-8?B?Q05CV3MrYVpOdGIzOE5CcWxNVU5vMzhZVVI1V1JqTTl3QU9SbzdSeU1QYUZh?= =?utf-8?B?V2NncGVLNjdWbDBVblRRNkNxMlF6YWh5NjFOZFdreW5LVjBuSUtKTWR6V1Y5?= =?utf-8?B?T3VSa3EzM2U4ZW50QkJXSEQ2KzlIM3VjZ2ppM1d4WW01U3FZT1NtclRqOGhG?= =?utf-8?B?Q3d5YnhTNFF1VWVNYmRlYWhleUJkTXNBZGI2emNCdjBLWWREcHlxb0MrTG9I?= =?utf-8?B?dDhYSG04VmtTMTNwbXoxUW91TlQ0c3RmZUc3dGJ5cVBvT2R5cnVVdVRiYTkw?= =?utf-8?B?b0plVzhLYkhIRk5PUEIwcFVjOExzck5waXFsalNBVk1hdDJZcmdyTDdpQ0Zq?= =?utf-8?B?bTZScE1mV1NVM2pYaW9HZWIyZFZxbjFXTnRNU1VlVXRyeTczVVdsbTVkc1Zx?= =?utf-8?B?a2tyK1BIMXgxL1o1US9wNkdLTElPeXlHZmVYcjhSK01EV2JFTjE3TFJQaGN2?= =?utf-8?B?MzBlMDk0b01HN1Jvc241YWExN3dLNkkwSTJxczFOc1dIVG5yUnNua0hZYll5?= =?utf-8?Q?9oX5zO78XwLPgFy/O24OMvs=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 3371744b-68ff-4644-d89f-08d9bf11618f X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 14:52:42.5286 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lToei4Y0wpSWgCFtrWMoYDXxvEC2aMY23j6dPsRNyXCHs+NAFUxU8b4u69A9UlayfoYdbrh6F+yfcnG81fB0Jw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4983 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 12/14/2021 2:46 PM, Christian Ehrhardt wrote: > On Tue, Dec 14, 2021 at 2:58 PM Christian Ehrhardt > wrote: >> >> On Tue, Dec 14, 2021 at 2:10 PM Ferruh Yigit wrote: >>> >>> On 12/14/2021 11:39 AM, Christian Ehrhardt wrote: >>>> On Tue, Dec 14, 2021 at 11:13 AM Ferruh Yigit wrote: >>>>> >>>>> On 12/14/2021 7:44 AM, Christian Ehrhardt wrote: >>>>>> On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil >>>>>> wrote: >>>>>> >>>>>> [snip] >>>>>> >>>>>>>>> [Kalesh] Yes, i am seeing the same error. I used make command to build dpdk, not meson. >>>>>>>>> The back ported commit you mentioned takes care of meson build only I think. >>>>>>>>> >>>>>>>> >>>>>>>> I see, make build is failing, and yes the fix is only for the meson. >>>>>>>> I will check the make build and will send a fix for it. >>>>>>> >>>>>>> [Kalesh]: looks like the below changes fixes the issue. I tried only on SLES15 SP3 and not on other SLES flavors. >>>>>>> >>>>>>> diff --git a/kernel/linux/kni/Makefile b/kernel/linux/kni/Makefile >>>>>>> index 595bac2..bf0efab 100644 >>>>>>> --- a/kernel/linux/kni/Makefile >>>>>>> +++ b/kernel/linux/kni/Makefile >>>>>>> @@ -16,6 +16,16 @@ MODULE_CFLAGS += -I$(RTE_OUTPUT)/include >>>>>>> MODULE_CFLAGS += -include $(RTE_OUTPUT)/include/rte_config.h >>>>>>> MODULE_CFLAGS += -Wall -Werror >>>>>>> >>>>>>> +# >>>>>>> +# Use explicit 'source' folder for header path. In SUSE 'source' is not linked to 'build' folder. >>>>>>> +# >>>>>>> +ifdef CONFIG_SUSE_KERNEL >>>>>>> + KSRC = /lib/modules/$(shell uname -r)/source >>>>>>> + ifneq ($(shell grep -A 1 "ndo_tx_timeout" $(KSRC)/include/linux/netdevice.h | grep -o txqueue),) >>>>>>> + MODULE_CFLAGS += -DHAVE_TX_TIMEOUT_TXQUEUE >>>>>>> + endif >>>>>>> +endif >>>>>> >>>>>> Back in the day we tried various "is Suse and kernel version x.y" >>>>>> approaches, but they failed as there was no clear version throughout >>>>>> all of the Suse streams (leap, tumbleweed, sles) that worked well for >>>>>> all. >>>>>> This change here follows the upstream approach of "just check if it is there". >>>>>> >>>>>> I've applied this to 19.11 and did test builds across various distributions: >>>>>> 1. no non-suse build changed >>>>>> 2. suse builds stayed as-is or improved >>>>>> Formerly failing: >>>>>> openSUSE_Factory_ARM aarch64 >>>>>> SLE_15 x86_64 -> now working >>>>>> openSUSE_Leap_15.3 x86_64 -> now working >>>>>> openSUSE_Tumbleweed x86_64 -> still failing >>>>>> Formerly working: >>>>>> SLE_12_SP4 x86_64 ppc64le -> still fine >>>>>> openSUSE_Factory_ARM armv7l -> still fine >>>>>> openSUSE_Leap_15.2 x86_64 -> still fine >>>>>> >>>>> >>>>> Thanks Kalesh for the fix, and thanks Christian for testing. >>>>> >>>>> I was expecting this approach will fix all builds, after patch only >>>>> 'openSUSE_Tumbleweed' is failing, right? I will check it. >>>> >>>> As just discussed on IRC, yes and the log for that is at >>>> https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/openSUSE_Tumbleweed/x86_64 >>>> >>>> It also is affected by an issue around -Werror=implicit-fallthrough, >>>> so even with KNI fixed it likely is going to fail. >>>> >>>>> And I think you need the fix as a patch anyway, @Kalesh are you >>>>> planning to send the patch? >>>> >>>> I don't need it, as I have already grabbed and preliminary added it: >>>> https://github.com/cpaelzer/dpdk-stable-queue/commit/d43fa3e198c08a3a76d70f4565b31ad3ab5f29c4 >>>> >>>> But surely, once/If you come up with a full patch that also includes >>>> tumbleweed I can replace it with yours. >>>> >>> >>> 'tumbleweed' error is odd, it complains about macro being redefined, >>> not sure why only in this platform we are getting an error. >>> >>> Macro is only defined in one place, but indeed header file included >>> multiple times, one direct and one indirect, so macro defined multiple >>> times but without value, so it should be OK and it is OK for other >>> platforms, it is defined as: >>> #define HAVE_TX_TIMEOUT_TXQUEUE >>> >>> Another option is that macro is defined in some other header file, >>> although I think that is very unlikely, can you please test with >>> below change to rule out that option: >> >> I'm testing that and will let you know in a bit ... > > Hi Ferruh, > with your change the build now works. > So indeed the symbol might have been defined elsewhere. > Interesting, this is self note to prefix 'RTE_' future macros. > https://build.opensuse.org/package/live_build_log/home:cpaelzer:branches:home:bluca:dpdk/dpdk-19.11/openSUSE_Tumbleweed/x86_64 > > It still fails later with the "-Werror=implicit-fallthrough=" but that > is a different problem > => https://bugs.dpdk.org/show_bug.cgi?id=907 > Yep, this is igb_uio error, I assigned the bug to myself and will look at it. > Ferruh - are you ok if I merge your suggestion with the backport I got > from Kalesh? > Sure. But would you mind sending the final patch to the stable mail list as record? Or I can do the same if you prefer? >>> diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h >>> index 664785674ff1..71846419f437 100644 >>> --- a/kernel/linux/kni/compat.h >>> +++ b/kernel/linux/kni/compat.h >>> @@ -135,7 +135,7 @@ >>> (defined(RHEL_RELEASE_CODE) && \ >>> RHEL_RELEASE_VERSION(8, 3) <= RHEL_RELEASE_CODE) || \ >>> (defined(CONFIG_SUSE_KERNEL) && defined(HAVE_ARG_TX_QUEUE)) >>> -#define HAVE_TX_TIMEOUT_TXQUEUE >>> +#define RTE_HAVE_TX_TIMEOUT_TXQUEUE >>> #endif >>> >>> #if KERNEL_VERSION(5, 9, 0) > LINUX_VERSION_CODE >>> diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c >>> index c8bad5f197ca..7397de4659b2 100644 >>> --- a/kernel/linux/kni/kni_net.c >>> +++ b/kernel/linux/kni/kni_net.c >>> @@ -623,7 +623,7 @@ kni_net_rx(struct kni_dev *kni) >>> /* >>> * Deal with a transmit timeout. >>> */ >>> -#ifdef HAVE_TX_TIMEOUT_TXQUEUE >>> +#ifdef RTE_HAVE_TX_TIMEOUT_TXQUEUE >>> static void >>> kni_net_tx_timeout(struct net_device *dev, unsigned int txqueue) >>> #else >>> >>> >>>>>> Past fixes always "inverted" the result, by fixing some but breaking others. >>>>>> This new patch works in "not breaking any formerly working build" but >>>>>> at the same time fixing a few builds. >>>>>> Therefore -> applied & thanks! >>>>>> >>>>>> I'll likely tag -rc2 before the end of the week. >>>>>> The good thing is that (so far) we have: >>>>>> 1. a non functional change >>>>>> 2. a change fixing clang-13 builds (TBH only one of many needed clang13 issues) >>>>>> 3. a change fixing sles15SP3 builds >>>>>> >>>>>> Due to those, no current ongoing tests will have to be restarted. >>>>>> Whoever was able to build, can continue the current tests. >>>>>> Whoever was blocked by SLES15SP3 or clang-13 had no tests other than a >>>>>> failing build and can work with -rc2 then. >>>>>> I'll explain the same in the mail about -rc2. >>>>>> >>>>>>> -include /etc/lsb-release >>>>>>> >>>>>>> ifeq ($(DISTRIB_ID),Ubuntu) >>>>>>> >>>>>>> Regards, >>>>>>> Kalesh >>>>>> >>>>>> [snip] >>>>>> >>>>> >>>> >>>> >>> >> >> >> -- >> Christian Ehrhardt >> Staff Engineer, Ubuntu Server >> Canonical Ltd > > >