From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4C71A0C4D for ; Tue, 5 Oct 2021 16:24:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F1454136E; Tue, 5 Oct 2021 16:24:37 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 9CE284132D; Tue, 5 Oct 2021 16:24:35 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10128"; a="225696989" X-IronPort-AV: E=Sophos;i="5.85,349,1624345200"; d="scan'208";a="225696989" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2021 07:19:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,349,1624345200"; d="scan'208";a="438713237" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga006.jf.intel.com with ESMTP; 05 Oct 2021 07:19:37 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 5 Oct 2021 07:19:36 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 5 Oct 2021 07:19:36 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.44) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 5 Oct 2021 07:19:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dQfM1LnecWmikU9u9pHdUFwB0Raw3PB/O0fwht8/So54bdk4j+M3u8nb8P3xH3vidvZBu2TrlLaUctJSV6mMupwV06pMae6s0+SYlpo/wBd2zsH7YfB/L4656gEeMSvzeZ9ou0XnmmXw/8hFOZR1GdeVAtIzKEuBM1ZIWCB/V2y2lbLcIDqMuExyMMk93NsmSBzI4IF0nzG6jhnaFoktnAuCaaTh9FtWg1DJCWKATJoM8zRYiKnupvkgGgv3d6NCrQvnTI2wNRe+QInNHr2fSdQaWkjlW43R53wXEoq1sE+JqcqmIdZD0mAWpNcGiXj5lefhWsiAF37QDhKqXKSJFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hkHi8KNgUeapnzdlZIFFhSBEALzowt0PhRqsd1dWgpA=; b=ZLnPtNKPD4CZZV8u0v/AWdHn6yHviIVNiIIJO1laLsStffHFuIr3+G1CTaLgProJ0EEyoC18m6IxibZsHDlnTElCzYAag4rFHeMhAZdFlpsCRfq2VxHmroSNVeE6r6NRckmOwiFP2bFR5HHro+HqOdiQSz/0qTZEFbXzWpxYlvqx7ctQ7xIF6C7GGaGJdWHBzNcnH9QAX1gFrkghuRArDWtJu7f0Ki2TzQZMR1jhYx0XFr8Swsp8zobrqoRFupyE7SWi+Rl4QBzCibUvghz2gF7ASJKXfUDrps0R03zhOr4yr8Q0iilTeoSTyNAxE0pv1Mi5uO3OtDpVj04h3y2AMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hkHi8KNgUeapnzdlZIFFhSBEALzowt0PhRqsd1dWgpA=; b=yFdryYUqWzgx3jesasHUhYmCvJxMq9nourOMrvTFVzoE8MDKA7mMDCwZlCKLRnSCAh3B3ZlesfRCO07yFOj5jSeO5AZaUG4MeDvLwhSN7V64ICmQ6oRuetIH3s4e1uuNIPQlWJ2pAuE4Qbpr7+oJmxqf/eltSvrsakRkzraeQXU= Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5095.namprd11.prod.outlook.com (2603:10b6:510:3b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Tue, 5 Oct 2021 14:19:33 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%4]) with mapi id 15.20.4566.022; Tue, 5 Oct 2021 14:19:32 +0000 Message-ID: <050032e0-4d92-c672-d696-1bc712cae033@intel.com> Date: Tue, 5 Oct 2021 15:19:26 +0100 Content-Language: en-US To: David Marchand , Aman Singh CC: dev , dpdk stable , Qi Zhang , Beilei Xing References: <20211005115754.34117-1-aman.deep.singh@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0202CA0042.eurprd02.prod.outlook.com (2603:10a6:4:a5::28) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0202CA0042.eurprd02.prod.outlook.com (2603:10a6:4:a5::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Tue, 5 Oct 2021 14:19:31 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 246117e4-9033-4ce9-8e76-08d9880b2697 X-MS-TrafficTypeDiagnostic: PH0PR11MB5095: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dhvPzYGuyP8exyGoEppMkRQlmk0yY1KFYaG0JmE2GbnQ1qsf/ikglptpr7nWOcZksg2+C2oTApTgASwhXquMiOgzhMnPDddeGDick0pRXWyEUsXHKOrZ/HTLBnjPyvJbhFfMEuV6ojIhp/W+q19Jalx7Av18grekywfBq0+12r2S3ziJ9Wqhe3lqYPiUZetza5V65B6w0msvTls2pS/WV5dnL996QgAaUSD8HEAmG8/PkJUDPo7SqwW7HSHX25jbgzXZKAh90kdvwDyz3j4xyl1ePdVT4TO3fzCzIhME4poLebCjSkGgCqCdvugE/SBJFOtVXhUG1dRlun0X7nQeDbHvlRCRsZrqZYtuqYLnEjiUQQdKn6v5nR6UExkpGd/gq2U/WT/v5qU6QRMYxxS6TI9b7aYMYhofwL3mzGBHbwibsOqnl9NwC+v3AF5XeGc2S0J22cNMORbDtLfC+4gMzE/7fXREmnyFxuIRLvak6xdsVfHgxFn0Pq0kLDZP/RD5V2y6m5X27BZ3nSNpkmGb/Jk36H+oSib681eNmQr7MiTuQEqJCIl9gVIAQkBNW3dy4h1rpakrTHGWrWA2XNAi01F5H/l0aF91KRkUlBqBWscDLzKYzbRi08VL76YjIRWBR/qtuXXBldTTHMq+yFfOlTxE2DuyF26j22rPevG2gULZYbZEgzeWoqjBKx05ZbIBnk+L57hEBzBT2e1k5fKF5Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(38100700002)(26005)(6486002)(31686004)(36756003)(54906003)(110136005)(956004)(2616005)(16576012)(316002)(186003)(4326008)(6636002)(8936002)(86362001)(66946007)(508600001)(31696002)(8676002)(44832011)(53546011)(83380400001)(6666004)(5660300002)(2906002)(66556008)(107886003)(66476007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3N6ZjFEMGU4VTdIMnQ3MmN4NGZ1M2J6aU45UTZSQ3NVRDJOUVB3bER6c1h5?= =?utf-8?B?bEN5Z0s0QUtuRGpUYVVjcGR6Yy84dzcycHdycHE0UnZiQm1jK0FIcXlMYjV1?= =?utf-8?B?a0svOVlSWlVkclZPVnZ1Tzk5WWxhSFpPOERKNlhvS01qQ0Uyc2I0cnFlRGoz?= =?utf-8?B?c1R5d3RDWG4wWW1kRTJoWXp2SkdYTWpBY2c0S1FMb1llRUFlbFUvODdOWThh?= =?utf-8?B?QmlsdXZGSlZoN25GdllaZEQvU3hOSnZlY0xLOW4vb3VsTnoyaHNiYVJBTXNr?= =?utf-8?B?eCtIUXBkek9EUzcwSDdpa0RQbE0wa0FuZ0Jyc0xDSlg1L3ZEazBLbUNxU1lB?= =?utf-8?B?L2F4bmtFVnhKQkVJK0RXSDRPMUdvOXlTRndvTThrdysvczJVL29ZemxnQkJG?= =?utf-8?B?THNhYlpiLzRTQXFVSVlPVFp6WFNOYjBDc0VvamZLTUd1RVJpUGRmL1V6SnAv?= =?utf-8?B?U3lJYXptejQ3WVRCUmdsaE9wRVczMHhUWlcyVnhLOFJ1Wko5WGhCSERNcENF?= =?utf-8?B?cm05V255RWExM3U2dWhPdEtzT1RGdExkVmZEeGcwN3FHWFphd3Z1MDF5NXl4?= =?utf-8?B?SnhCRVRFQUh2WGN5QnZlSHFqUnp2TWlNZDRtNFJSQ3ZEQXYwSEMzQlEzdGJY?= =?utf-8?B?WE5Gbkk0Uy9YbjNHOG01ZE1pcEZGalpEWG9uZzZaZ3ZuOEUzSVQrNWJoc2oz?= =?utf-8?B?aFlLYzM2ZDJMcTczK2kreE8zWFAyclh1VkZPNjFTRkU4WlBHdTZlbnBoTjE3?= =?utf-8?B?MWNKYWdEa0VDQ3gyaXV3L3hsc1Y5cVRQcFBLTDMxMjdyVVI3dTg1UFdwZ0VE?= =?utf-8?B?blAxT0liTUZWaDRHZkI4UTlIVldPL0FpMDBQcG8wb0ZaR3FTUVdyK1haWmJh?= =?utf-8?B?b01nSWZETnlXOFlRK0g2QnFhOGsrbCtVZjNacEtCeFQvUEE1RlErTFV6bTl5?= =?utf-8?B?MHVuekxQWFE4cUpINEFZajMvQ1YrdmluZFNYcjNqRXVtTXhqNzBGdnh4UTg5?= =?utf-8?B?SHhtc0dEeGxIS1R5bWJvQnBsWFpwSUowUklxUVY2TmJlbDdPdHhGMHRLMmtJ?= =?utf-8?B?UWpjY3FXZ252Z2pjcUJnSzV1RkNPNW5udUV0b3djQ0hMY2MxL1laeGhRM0U0?= =?utf-8?B?ekdDUDVYZjFHZUxmdGpJL2RIYzdhblhheHM5blM5ZjFkY1JBQ2ZkNFpITXpm?= =?utf-8?B?UHBwR0wramFDMTNlTFVmbytjb1RPY0ZYcVh6OTRQb24vU0RNc2NoRWxSdkIv?= =?utf-8?B?M29yRnAvTXJFemJsYmR0WThUNjhURkR1cnEyZTFvSXNSSW02R3h6ZC8zanBa?= =?utf-8?B?ZzNtRGJFbTFJQ0o2emp2ZXlqUFhsZWJIa2F1VWY4alg5d3dyVUZoaW93OCsz?= =?utf-8?B?RC9kQ1NhTTNpU0g2bitlVGI5cjFXZDk5aTBqSFoyOGpEbmxKVnE3SUJoVXRN?= =?utf-8?B?c3BXZjZoTy8vSGJ6dENtV01mZjBac0pPNVdmMTVqZzlQa2pTL3oxcThHOVVJ?= =?utf-8?B?b29JNXIwbXp2L3V4Zm8waUtXb2JjNWxNVjN2MXNsVWpmTEREUTc1aG5oRUxK?= =?utf-8?B?V0VIRFNXcWFvaHdReFI2SDc4TmZveGRJTGw5NURmdUYzM3RnNDA3ZGUxbHkv?= =?utf-8?B?NldzTUR5cHlkTFdzVHVuWFFDN1ozaCtTU0p3VWFiWDFBZDM3NEQvYmpmZzBN?= =?utf-8?B?UmdCaE1BMENrNEl4MjNaVS9sZHY3ZnphREZUNVZqMVpqSkRNRyt2Q25BVHdv?= =?utf-8?Q?PVrPDTCkBmbBoXw6O2Ebp3XkxROUNP6J5h4r4Jw?= X-MS-Exchange-CrossTenant-Network-Message-Id: 246117e4-9033-4ce9-8e76-08d9880b2697 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 14:19:32.5967 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WJwxbq++uCMTDYJx4dBv5WtjAZBiYX9FT6kex1SxsCBIz6bph9OfX5sn/cR/Z1I6CHb6+snXeGyDRY2hhghJYw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5095 X-OriginatorOrg: intel.com Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ice/base: fix build error for GCC 4.8.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 10/5/2021 2:57 PM, David Marchand wrote: > On Tue, Oct 5, 2021 at 2:07 PM Aman Singh wrote: >> >> Code changes done for build issue as reported in Bug 817 >> error: dereferencing type-punned pointer will break strict-aliasing rules. >> added union to avoid pointer dereferencing >> > > About the title, Ali reproduced the issue with other versions of gcc. > > This patch touches base/ code, is Intel ok with this? > Else, we could consider disabling strict aliasing for the base driver, like > $ git grep alias '**/base/meson.build' > drivers/net/fm10k/base/meson.build: '-Wno-strict-aliasing', > '-Wno-format-extra-args', > drivers/net/i40e/base/meson.build: '-Wno-strict-aliasing', > '-Wno-unused-but-set-variable', > drivers/net/qede/base/meson.build: '-Wno-strict-aliasing', > It has some complications to update the shared code from the DPDK, but for this case the fix seems simple and valid, so I am for getting the fix and work on to propagate the fix to the shared code, instead of disable the warning directly. Mainly Qi and Beilei will be managing the shared code part, if shared code comes with different solution, we can send an incremental patch to replace this fix. Briefly I am for getting the patch, hence: Acked-by: Ferruh Yigit > > Bugzilla ID: 817 > >> Fixes: 39925373a333 ("net/ice/base: add parser execution main loop") > > No Cc: stable, this is a regression in main. > >> Signed-off-by: Aman Singh > > Tested-by: David Marchand > >