From: Olivier Matz <olivier.matz@6wind.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: dev@dpdk.org, pablo.de.lara.guarch@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] testpmd: fix crash when mempool allocation fails
Date: Fri, 9 Sep 2016 10:43:23 +0200 [thread overview]
Message-ID: <0504b8cb-891c-99c7-dbc7-fd2ddd11423d@6wind.com> (raw)
In-Reply-To: <20160909082501.GW7328@yliu-dev.sh.intel.com>
Hi Yuanhan,
On 09/09/2016 10:25 AM, Yuanhan Liu wrote:
> On Fri, Sep 09, 2016 at 10:16:25AM +0200, Olivier Matz wrote:
>> Avoid access to mempool pointer if it is NULL.
>>
>> Fixes: b19a0c75a0d4 ("app/testpmd: remove anonymous mempool code")
>> Coverity issue: 127553
>>
>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
>> ---
>> app/test-pmd/testpmd.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
>> index 1428974..e0f8285 100644
>> --- a/app/test-pmd/testpmd.c
>> +++ b/app/test-pmd/testpmd.c
>> @@ -444,10 +444,13 @@ mbuf_pool_create(uint16_t mbuf_seg_size, unsigned nb_mbuf,
>> mb_size, (unsigned) mb_mempool_cache,
>> sizeof(struct rte_pktmbuf_pool_private),
>> socket_id, 0);
>> + if (rte_mp == NULL)
>> + goto err;
>>
>> if (rte_mempool_populate_anon(rte_mp) == 0) {
>> rte_mempool_free(rte_mp);
>> rte_mp = NULL;
>> + goto err;
>> }
>> rte_pktmbuf_pool_init(rte_mp, NULL);
>> rte_mempool_obj_iter(rte_mp, rte_pktmbuf_init, NULL);
>> @@ -458,6 +461,7 @@ mbuf_pool_create(uint16_t mbuf_seg_size, unsigned nb_mbuf,
>> }
>> }
>>
>> + err:
>
> A minor nit: there is a heading white space char.
>
Well, that's something I've been doing since a long time due to my
editor config, but I cannot find any good reason for doing that.
I'll send a v2 without this space (and fix my config for next times ;))
Olivier
next prev parent reply other threads:[~2016-09-09 8:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 8:16 Olivier Matz
2016-09-09 8:25 ` Yuanhan Liu
2016-09-09 8:43 ` Olivier Matz [this message]
2016-09-09 9:40 ` [dpdk-stable] [PATCH v2] " Olivier Matz
2016-09-09 9:42 ` [dpdk-stable] [PATCH v3] " Olivier Matz
2016-09-21 23:02 ` De Lara Guarch, Pablo
2016-09-23 18:17 ` Thomas Monjalon
2016-09-27 6:37 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0504b8cb-891c-99c7-dbc7-fd2ddd11423d@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).