* [dpdk-stable] [PATCH 1/1] net/mlx4: update link status upon probing with lsc
@ 2017-03-03 15:39 Gaetan Rivet
2017-03-17 10:40 ` Adrien Mazarguil
0 siblings, 1 reply; 3+ messages in thread
From: Gaetan Rivet @ 2017-03-03 15:39 UTC (permalink / raw)
To: dev; +Cc: Adrien Mazarguil, Nelio Laranjeiro, stable
If LSC interrupts are enabled, the application expects the link_update
ops to be executed by the PMD itself.
No link status change event is received upon probing, therefore the link
status update must be forced.
Fixes: c4da6caa426d ("mlx4: handle link status interrupts")
Cc: stable@dpdk.org
Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
---
drivers/net/mlx4/mlx4.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
index fc84464..35a680c 100644
--- a/drivers/net/mlx4/mlx4.c
+++ b/drivers/net/mlx4/mlx4.c
@@ -5722,6 +5722,9 @@ mlx4_pci_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev)
/* Bring Ethernet device up. */
DEBUG("forcing Ethernet interface up");
priv_set_flags(priv, ~IFF_UP, IFF_UP);
+ /* Update link status once if waiting for LSC. */
+ if (eth_dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC)
+ mlx4_link_update(eth_dev, 0);
continue;
port_error:
--
2.1.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-stable] [PATCH 1/1] net/mlx4: update link status upon probing with lsc
2017-03-03 15:39 [dpdk-stable] [PATCH 1/1] net/mlx4: update link status upon probing with lsc Gaetan Rivet
@ 2017-03-17 10:40 ` Adrien Mazarguil
2017-03-20 14:16 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Adrien Mazarguil @ 2017-03-17 10:40 UTC (permalink / raw)
To: Gaetan Rivet; +Cc: dev, Nelio Laranjeiro, stable
On Fri, Mar 03, 2017 at 04:39:56PM +0100, Gaetan Rivet wrote:
> If LSC interrupts are enabled, the application expects the link_update
> ops to be executed by the PMD itself.
>
> No link status change event is received upon probing, therefore the link
> status update must be forced.
>
> Fixes: c4da6caa426d ("mlx4: handle link status interrupts")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
--
Adrien Mazarguil
6WIND
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-stable] [PATCH 1/1] net/mlx4: update link status upon probing with lsc
2017-03-17 10:40 ` Adrien Mazarguil
@ 2017-03-20 14:16 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-03-20 14:16 UTC (permalink / raw)
To: Adrien Mazarguil, Gaetan Rivet; +Cc: dev, Nelio Laranjeiro, stable
On 3/17/2017 10:40 AM, Adrien Mazarguil wrote:
> On Fri, Mar 03, 2017 at 04:39:56PM +0100, Gaetan Rivet wrote:
>> If LSC interrupts are enabled, the application expects the link_update
>> ops to be executed by the PMD itself.
>>
>> No link status change event is received upon probing, therefore the link
>> status update must be forced.
>>
>> Fixes: c4da6caa426d ("mlx4: handle link status interrupts")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-20 14:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-03 15:39 [dpdk-stable] [PATCH 1/1] net/mlx4: update link status upon probing with lsc Gaetan Rivet
2017-03-17 10:40 ` Adrien Mazarguil
2017-03-20 14:16 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).