Re: [dpdk-stable] [PATCH] lib/cryptodev: fix API digest length comments

[Declan Doherty <declan.doherty@intel.com>]

On 28/04/2017 2:38 PM, Trahe, Fiona wrote:
> Hi Declan,
>
>> -----Original Message-----
...

>> I don't think this comment change is valid, we already validate many of
>> the parameters which are passed into session creation, such as key
>> lengths etc, if we are not validating digest length now I think we
>> should be, maybe this is a gap in our unit tests.
>>
> Neither the API nor any of the PMDs validate the digest_length at present.
> I agree, they probably should, but it's a bit late to add this in 17.05,
> as it would be quite a bit of code churn, each PMD would have to check
> against the range in their Capabilities structure.
> So the next best thing for this release in my opinion is to remove the comment as
> it is misleading and out of sync with the implementation.
> In the next release we should remove the comments saying it's the callers
> responsibility from both digest_length and auth key length and add
> the param checks to each PMD.

Oh, I guess it's better to make the comment reflect the current 
implementation and then fix in next release.

>
....
>