patches for DPDK stable branches
 help / color / Atom feed
From: "Sun, GuinanX" <guinanx.sun@intel.com>
To: "Guo, Jia" <jia.guo@intel.com>,
	"Xing, Beilei" <beilei.xing@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/i40e: fix link status
Date: Thu, 30 Jul 2020 09:26:18 +0000
Message-ID: <05758BDAD7FC8E4BAED63D0390A8A95587FCD1@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <426f9eeb-21b0-cf17-9161-aab428a88399@intel.com>

Hi Jeff

> -----Original Message-----
> From: Guo, Jia
> Sent: Thursday, July 30, 2020 5:12 PM
> To: Sun, GuinanX <guinanx.sun@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: Re: [PATCH] net/i40e: fix link status
> 
> hi, guinan
> 
> On 7/30/2020 4:25 PM, Guinan Sun wrote:
> > The PF driver supports to use link_event_adv or link_event to get the
> > link speed. However, when using link_event_adv to get link speed,
> > there is a lack of logic to convert between link speed type
> > (I40E_LINK_SPEED_XXX) and mbps type (SPEED_XXX).
> > As a result, the mbps type is not recognized, so the link status down
> > problem occurs. This patch is used for type replacement between speed
> > types.
> >
> > Fixes: 2a73125b7041 ("i40evf: fix link info update")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> > ---
> >   drivers/net/i40e/base/virtchnl.h  |  8 +++++-
> >   drivers/net/i40e/i40e_ethdev_vf.c | 42 +++++++++++++++++++++++++++++-
> -
> >   drivers/net/i40e/i40e_pf.c        |  4 +++
> >   3 files changed, 51 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/i40e/base/virtchnl.h
> > b/drivers/net/i40e/base/virtchnl.h
> > index 4f498ca45..90c404fb8 100644
> > --- a/drivers/net/i40e/base/virtchnl.h
> > +++ b/drivers/net/i40e/base/virtchnl.h
> > @@ -240,7 +240,8 @@ VIRTCHNL_CHECK_STRUCT_LEN(16,
> virtchnl_vsi_resource);
> >   #define VIRTCHNL_VF_OFFLOAD_ENCAP		0X00100000
> >   #define VIRTCHNL_VF_OFFLOAD_ENCAP_CSUM		0X00200000
> >   #define VIRTCHNL_VF_OFFLOAD_RX_ENCAP_CSUM	0X00400000
> > -
> > +/* Define below the capability flags that are not offloads */
> > +#define VIRTCHNL_VF_CAP_ADV_LINK_SPEED		0x00000080
> >   #define VF_BASE_MODE_OFFLOADS (VIRTCHNL_VF_OFFLOAD_L2 | \
> >   			       VIRTCHNL_VF_OFFLOAD_VLAN | \
> >   			       VIRTCHNL_VF_OFFLOAD_RSS_PF) @@ -540,6
> +541,11 @@ struct
> > virtchnl_pf_event {
> >   			enum virtchnl_link_speed link_speed;
> >   			bool link_status;
> >   		} link_event;
> > +		struct {
> > +			/* link_speed provided in Mbps */
> > +			u32 link_speed;
> > +			u8 link_status;
> > +		} link_event_adv;
> >   	} event_data;
> >
> >   	int severity;
> > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c
> > b/drivers/net/i40e/i40e_ethdev_vf.c
> > index 69cab8e73..f8cf45fbe 100644
> > --- a/drivers/net/i40e/i40e_ethdev_vf.c
> > +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> > @@ -1386,8 +1386,46 @@ i40evf_handle_pf_event(struct rte_eth_dev *dev,
> uint8_t *msg,
> >   		break;
> >   	case VIRTCHNL_EVENT_LINK_CHANGE:
> >   		PMD_DRV_LOG(DEBUG, "VIRTCHNL_EVENT_LINK_CHANGE
> event");
> > -		vf->link_up = pf_msg->event_data.link_event.link_status;
> > -		vf->link_speed = pf_msg->event_data.link_event.link_speed;
> > +
> > +		if (vf->vf_res->vf_cap_flags &
> VIRTCHNL_VF_CAP_ADV_LINK_SPEED) {
> > +			vf->link_up =
> > +				pf_msg-
> >event_data.link_event_adv.link_status;
> > +
> > +			switch (pf_msg-
> >event_data.link_event_adv.link_speed) {
> > +			case ETH_SPEED_NUM_100M:
> > +				vf->link_speed = I40E_LINK_SPEED_100MB;
> > +				break;
> > +			case ETH_SPEED_NUM_1G:
> > +				vf->link_speed = I40E_LINK_SPEED_1GB;
> > +				break;
> > +			case ETH_SPEED_NUM_2_5G:
> > +				vf->link_speed = I40E_LINK_SPEED_2_5GB;
> > +				break;
> > +			case ETH_SPEED_NUM_5G:
> > +				vf->link_speed = I40E_LINK_SPEED_5GB;
> > +				break;
> > +			case ETH_SPEED_NUM_10G:
> > +				vf->link_speed = I40E_LINK_SPEED_10GB;
> > +				break;
> > +			case ETH_SPEED_NUM_20G:
> > +				vf->link_speed = I40E_LINK_SPEED_20GB;
> > +				break;
> > +			case ETH_SPEED_NUM_25G:
> > +				vf->link_speed = I40E_LINK_SPEED_25GB;
> > +				break;
> > +			case ETH_SPEED_NUM_40G:
> > +				vf->link_speed = I40E_LINK_SPEED_40GB;
> > +				break;
> > +			default:
> > +				vf->link_speed =
> I40E_LINK_SPEED_UNKNOWN;
> > +				break;
> > +			}
> > +		} else {
> > +			vf->link_up =
> > +				pf_msg->event_data.link_event.link_status;
> 
> 
> Is the link_status the same of processing whatever adv speed cap?

They are  not the same process, so it's no need to change.

> 
> 
> > +			vf->link_speed =
> > +				pf_msg->event_data.link_event.link_speed;
> > +		}
> >   		break;
> >   	case VIRTCHNL_EVENT_PF_DRIVER_CLOSE:
> >   		PMD_DRV_LOG(DEBUG,
> "VIRTCHNL_EVENT_PF_DRIVER_CLOSE event"); diff
> > --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c index
> > 7bf1e7941..33af30bbb 100644
> > --- a/drivers/net/i40e/i40e_pf.c
> > +++ b/drivers/net/i40e/i40e_pf.c
> > @@ -320,6 +320,10 @@ i40e_pf_host_process_cmd_get_vf_resource(struct
> i40e_pf_vf *vf, uint8_t *msg,
> >   	else
> >   		vf->request_caps = *(uint32_t *)msg;
> >
> > +#ifdef VIRTCHNL_VF_CAP_ADV_LINK_SPEED
> > +	vf_res->vf_cap_flags |= VIRTCHNL_VF_CAP_ADV_LINK_SPEED; #endif
> /*
> > +VIRTCHNL_VF_CAP_ADV_LINK_SPEED */
> > +
> 
> 
> Below code is after your change here,  be careful to use "|=" please.

Yes, you are right, Iwill take care of it.
But there is a problem with the logic of this code, which will be removed later.

> 
>      vf_res->vf_cap_flags = vf->request_caps &
>                     I40E_VIRTCHNL_OFFLOAD_CAPS;
> 
> 
> >   	/* enable all RSS by default,
> >   	 * doesn't support hena setting by virtchnnl yet.
> >   	 */

  reply index

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-30  8:25 Guinan Sun
2020-07-30  9:12 ` Jeff Guo
2020-07-30  9:26   ` Sun, GuinanX [this message]
2020-07-30 10:25 ` [dpdk-stable] [PATCH v2] " Guinan Sun
2020-07-30 10:51   ` [dpdk-stable] [dpdk-dev] " Wang, ShougangX
2020-07-30 10:57     ` Jeff Guo
2020-07-31  2:29   ` Xing, Beilei
2020-07-31  2:37     ` Wang, ShougangX
2020-07-31  3:50       ` Xing, Beilei
2020-07-31  4:09         ` Sun, GuinanX
2020-08-06  8:16 ` [dpdk-stable] [PATCH v3] " Guinan Sun
2020-08-06  9:46   ` [dpdk-stable] [dpdk-dev] " Wang, ShougangX
2020-08-06 10:08   ` [dpdk-stable] " Xing, Beilei
2020-08-07  2:09     ` Jeff Guo
2020-08-31  0:52     ` Zhang, Qi Z
2020-08-31 13:24   ` Ferruh Yigit
2020-09-01  8:52     ` Sun, GuinanX
2020-09-02  8:06 ` [dpdk-stable] [PATCH v4] " Guinan Sun
2020-09-03  8:38   ` Jeff Guo
2020-09-03  8:43     ` [dpdk-stable] [dpdk-dev] " Min, JiaqiX
2020-09-04  6:21 ` [dpdk-stable] [PATCH v5] " Guinan Sun
2020-09-07  5:04   ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05758BDAD7FC8E4BAED63D0390A8A95587FCD1@SHSMSX101.ccr.corp.intel.com \
    --to=guinanx.sun@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jia.guo@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox