patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: David Marchand <david.marchand@redhat.com>, dev <dev@dpdk.org>,
	Luca Boccassi <bluca@debian.org>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] Backporting rte_intr_ack
Date: Fri, 22 Nov 2019 16:33:36 +0000	[thread overview]
Message-ID: <05f8dc7b-d4b3-2ab2-d36f-b6671804aeee@redhat.com> (raw)
In-Reply-To: <4111590.xNL0bnPyNO@xps>

On 22/11/2019 15:24, Thomas Monjalon wrote:
> 22/11/2019 16:12, Kevin Traynor:
>> On 19/11/2019 10:40, Thomas Monjalon wrote:
>>> 14/10/2019 17:55, David Marchand:
>>>> The api rte_intr_ack that has been introduced to fix a race condition
>>>> observed with (at least) qede drivers/hw.
>>>> This is an experimental api in master but it still fixes a problem, so
>>>> I'd like to see this in stable branches.
>>>
>>> This is more a driver interface than an API.
>>>
>>>> Opinions?
>>>
>>> If it comes with a fix in a driver, I think it is worth backporting.
>>>
>>>
>>
>> I think fine to backport as it solves an observed problem for qede.
>> However, a bit reluctant to update all the drivers to use it without
>> acks from their maintainers.
>>
>> Discussed with David offline and idea to backport and only update qede
>> now. Other drivers can be updated if there is a request from
>> maintainers. How does it sound?
> 
> It's better than nothing.

Not sure whether it should be opt-in or opt-out for driver maintainers,
but if there is some bug found in this new experimental API it can break
many drivers, so was airing on the side of no regression. Open to other
suggestions. Btw, it is not urgent, as we have time before next release.

> But it makes tracking of backports more difficult.

Yes, a little. We can have a separate 18.11 only qede patch and not
claim to backport the commit which updates all drivers.

> Is it a common practice to backport half of fixes?
> 

I don't remember it before where it all can apply.

> 


      reply	other threads:[~2019-11-22 16:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-14 15:55 David Marchand
2019-11-19 10:40 ` Thomas Monjalon
2019-11-22 15:12   ` Kevin Traynor
2019-11-22 15:24     ` Thomas Monjalon
2019-11-22 16:33       ` Kevin Traynor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05f8dc7b-d4b3-2ab2-d36f-b6671804aeee@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=bluca@debian.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).