* [dpdk-stable] [PATCH 2/4] crypto/dpaa_sec: fix HMAC supported digest sizes
[not found] <1524156759-12931-1-git-send-email-hemant.agrawal@nxp.com>
@ 2018-04-19 16:52 ` Hemant Agrawal
2018-04-20 10:35 ` Akhil Goyal
2018-04-19 16:52 ` [dpdk-stable] [PATCH 3/4] crypto/dpaa2_sec: " Hemant Agrawal
1 sibling, 1 reply; 4+ messages in thread
From: Hemant Agrawal @ 2018-04-19 16:52 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch, akhil.goyal, stable, Nipun Gupta
For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported
digest sizes are not a fixed value, but a range between
1 and the maximum digest size for those algorithms.
Also setting iv_size as 0.
Fixes: c3e85bdcc6e6 ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform")
Cc: stable@dpdk.org
Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
drivers/crypto/dpaa_sec/dpaa_sec.h | 30 ++++++++++++++++++------------
1 file changed, 18 insertions(+), 12 deletions(-)
diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.h b/drivers/crypto/dpaa_sec/dpaa_sec.h
index b8f7bd2..1433595 100644
--- a/drivers/crypto/dpaa_sec/dpaa_sec.h
+++ b/drivers/crypto/dpaa_sec/dpaa_sec.h
@@ -185,10 +185,11 @@ static const struct rte_cryptodev_capabilities dpaa_sec_capabilities[] = {
.increment = 1
},
.digest_size = {
- .min = 16,
+ .min = 1,
.max = 16,
- .increment = 0
+ .increment = 1
},
+ .iv_size = { 0 }
}, }
}, }
},
@@ -205,10 +206,11 @@ static const struct rte_cryptodev_capabilities dpaa_sec_capabilities[] = {
.increment = 1
},
.digest_size = {
- .min = 20,
+ .min = 1,
.max = 20,
- .increment = 0
+ .increment = 1
},
+ .iv_size = { 0 }
}, }
}, }
},
@@ -225,10 +227,11 @@ static const struct rte_cryptodev_capabilities dpaa_sec_capabilities[] = {
.increment = 1
},
.digest_size = {
- .min = 28,
+ .min = 1,
.max = 28,
- .increment = 0
+ .increment = 1
},
+ .iv_size = { 0 }
}, }
}, }
},
@@ -245,10 +248,11 @@ static const struct rte_cryptodev_capabilities dpaa_sec_capabilities[] = {
.increment = 1
},
.digest_size = {
- .min = 32,
+ .min = 1,
.max = 32,
- .increment = 0
+ .increment = 1
},
+ .iv_size = { 0 }
}, }
}, }
},
@@ -265,10 +269,11 @@ static const struct rte_cryptodev_capabilities dpaa_sec_capabilities[] = {
.increment = 1
},
.digest_size = {
- .min = 48,
+ .min = 1,
.max = 48,
- .increment = 0
+ .increment = 1
},
+ .iv_size = { 0 }
}, }
}, }
},
@@ -285,10 +290,11 @@ static const struct rte_cryptodev_capabilities dpaa_sec_capabilities[] = {
.increment = 1
},
.digest_size = {
- .min = 64,
+ .min = 1,
.max = 64,
- .increment = 0
+ .increment = 1
},
+ .iv_size = { 0 }
}, }
}, }
},
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-stable] [PATCH 3/4] crypto/dpaa2_sec: fix HMAC supported digest sizes
[not found] <1524156759-12931-1-git-send-email-hemant.agrawal@nxp.com>
2018-04-19 16:52 ` [dpdk-stable] [PATCH 2/4] crypto/dpaa_sec: fix HMAC supported digest sizes Hemant Agrawal
@ 2018-04-19 16:52 ` Hemant Agrawal
2018-04-20 10:36 ` Akhil Goyal
1 sibling, 1 reply; 4+ messages in thread
From: Hemant Agrawal @ 2018-04-19 16:52 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch, akhil.goyal, stable, Nipun Gupta
For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported
digest sizes are not a fixed value, but a range between
1 and the maximum digest size for those algorithms.
Fixes: f947fd77185f ("crypto/dpaa2_sec: fix HMAC supported key sizes")
Cc: stable@dpdk.org
Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
index e8ac95b..a9d83eb 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
@@ -185,9 +185,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
.increment = 1
},
.digest_size = {
- .min = 16,
+ .min = 1,
.max = 16,
- .increment = 0
+ .increment = 1
},
.iv_size = { 0 }
}, }
@@ -206,9 +206,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
.increment = 1
},
.digest_size = {
- .min = 20,
+ .min = 1,
.max = 20,
- .increment = 0
+ .increment = 1
},
.iv_size = { 0 }
}, }
@@ -227,9 +227,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
.increment = 1
},
.digest_size = {
- .min = 28,
+ .min = 1,
.max = 28,
- .increment = 0
+ .increment = 1
},
.iv_size = { 0 }
}, }
@@ -248,9 +248,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
.increment = 1
},
.digest_size = {
- .min = 32,
- .max = 32,
- .increment = 0
+ .min = 1,
+ .max = 32,
+ .increment = 1
},
.iv_size = { 0 }
}, }
@@ -269,9 +269,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
.increment = 1
},
.digest_size = {
- .min = 48,
+ .min = 1,
.max = 48,
- .increment = 0
+ .increment = 1
},
.iv_size = { 0 }
}, }
@@ -290,9 +290,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
.increment = 1
},
.digest_size = {
- .min = 64,
+ .min = 1,
.max = 64,
- .increment = 0
+ .increment = 1
},
.iv_size = { 0 }
}, }
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH 2/4] crypto/dpaa_sec: fix HMAC supported digest sizes
2018-04-19 16:52 ` [dpdk-stable] [PATCH 2/4] crypto/dpaa_sec: fix HMAC supported digest sizes Hemant Agrawal
@ 2018-04-20 10:35 ` Akhil Goyal
0 siblings, 0 replies; 4+ messages in thread
From: Akhil Goyal @ 2018-04-20 10:35 UTC (permalink / raw)
To: Hemant Agrawal, dev; +Cc: pablo.de.lara.guarch, stable, Nipun Gupta
On 4/19/2018 10:22 PM, Hemant Agrawal wrote:
> For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported
> digest sizes are not a fixed value, but a range between
> 1 and the maximum digest size for those algorithms.
> Also setting iv_size as 0.
>
> Fixes: c3e85bdcc6e6 ("crypto/dpaa_sec: add crypto driver for NXP DPAA platform")
> Cc: stable@dpdk.org
>
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH 3/4] crypto/dpaa2_sec: fix HMAC supported digest sizes
2018-04-19 16:52 ` [dpdk-stable] [PATCH 3/4] crypto/dpaa2_sec: " Hemant Agrawal
@ 2018-04-20 10:36 ` Akhil Goyal
0 siblings, 0 replies; 4+ messages in thread
From: Akhil Goyal @ 2018-04-20 10:36 UTC (permalink / raw)
To: Hemant Agrawal, dev; +Cc: pablo.de.lara.guarch, stable, Nipun Gupta
On 4/19/2018 10:22 PM, Hemant Agrawal wrote:
> For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported
> digest sizes are not a fixed value, but a range between
> 1 and the maximum digest size for those algorithms.
>
> Fixes: f947fd77185f ("crypto/dpaa2_sec: fix HMAC supported key sizes")
> Cc: stable@dpdk.org
>
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-20 10:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1524156759-12931-1-git-send-email-hemant.agrawal@nxp.com>
2018-04-19 16:52 ` [dpdk-stable] [PATCH 2/4] crypto/dpaa_sec: fix HMAC supported digest sizes Hemant Agrawal
2018-04-20 10:35 ` Akhil Goyal
2018-04-19 16:52 ` [dpdk-stable] [PATCH 3/4] crypto/dpaa2_sec: " Hemant Agrawal
2018-04-20 10:36 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).