From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1530F4266F for ; Wed, 4 Oct 2023 13:37:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB81A4029A; Wed, 4 Oct 2023 13:37:56 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 77C6640289; Wed, 4 Oct 2023 13:37:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696419474; x=1727955474; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=7hWRqZdR6mQ4YgpmANPoEkhdrqLbuzV/AM4F6WcdnM8=; b=PUuhB/TQnnPctLVWBPC3n1XRI9NVn7+5zfU0aqiYKq+Y6RjmpxsKT0c4 7vUGpNbRbFsCIlWxJ1/E8p95PcQDA48Es0TWNwgLrFZKYaFitebhDQ4JN fNn2ivmGSLIh4NErEGI13fODs3xCMVFiOiohV3fi0qzwSOKhqaflzQAd8 gNTfxYBIStGsmcozjds9dD5L1M0I4u62/srH/nqbIRjPdC39Qe3yzOA7U EQuvHbBySkXRB7DIj59dz0G3WvBGRPX+cY2nC5UbMnK1iSQVmFp/NCTC1 bKgOmv9MKZzCQa9pLH1t3JEkoBqEDJJxhb1C2sOzQhsByGzKcKyGKGyfA Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10852"; a="469411794" X-IronPort-AV: E=Sophos;i="6.03,200,1694761200"; d="scan'208";a="469411794" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2023 04:37:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10852"; a="998424451" X-IronPort-AV: E=Sophos;i="6.03,200,1694761200"; d="scan'208";a="998424451" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 04 Oct 2023 04:37:53 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Wed, 4 Oct 2023 04:37:52 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Wed, 4 Oct 2023 04:37:52 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Wed, 4 Oct 2023 04:37:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R3wsYyKsN97Buta9KcpqKZmY0FtP5rE3vQPuUBm/BcZ5Js7XIqS++eeWy6SsZugG/yUCrtvQzmj5t5fvasTiPNt7QI0/HceVfcJDFovQp8rEywroZUlG9tkXbsUUGJw/yrVY4mZE1lyEyvtUQtqI/ukEuVNOQnKoJKx3/yMPfFono/hsA5Q9KZ4t9x5TB8RT+TSk3W+kYsELYOiTH6E2ZehmZpQlZuBGmWM7RVfTooregiUwO0+Xi1ju8PMiBz8YDsGu7yXMHO9zmPhhwwNHoDsCrKI4UQlG3pHcf8Gn/blPjYU9e+7budlxtnnlo7nAMbY3JDEVG0WExv9WGs2olg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=W6TVzKA+R7P9iXx6c7QKHnVLQ7arG84gfd3H2LVj2MU=; b=QrFpuRGBh/aej8k4/izhbU5YVqRbThfmOn5yDjCPQnZV2G1342QvlKm4NbVDtcfG+iydv+dbEywrtSvGXVAopgWZFLrSRnCtvpKnB6I4DmB1s+us3ut5tMeJoLgbbRqnBAqkVyCGD+RcoE43aHbvJ77xKv76k9xMw6ppN7C3hlff+x6vkvhqgdUBhEFCvUs7BDkCdsclEOuMidNGVij67ntK5aIT+LPEhepnTlfzXrU+kwauukM2L+M4JYAim4U7c6JftXj8UyI/rbctPcENGMpbKlt3hSmY00mhsbqJGXBvRUTZgdd3rIk94n9uc8KN/gbFQZYXKhmout/YFgw6HA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by SN7PR11MB7420.namprd11.prod.outlook.com (2603:10b6:806:328::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.28; Wed, 4 Oct 2023 11:37:48 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::2889:5e26:b0f5:e77b]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::2889:5e26:b0f5:e77b%3]) with mapi id 15.20.6838.024; Wed, 4 Oct 2023 11:37:48 +0000 Message-ID: <08992987-4fe0-1759-aad6-490f0078d9f3@intel.com> Date: Wed, 4 Oct 2023 12:37:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.14.0 Subject: Re: [PATCH v1 1/1] eal/random: fix random state initialization for non-eal threads Content-Language: en-US To: David Marchand , =?UTF-8?Q?Mattias_R=c3=b6nnblom?= , "Stephen Hemminger" CC: , Bruce Richardson , , =?UTF-8?Q?Morten_Br=c3=b8rup?= References: <366f5750e01894c56d5d486c75d312e85c404277.1693224396.git.anatoly.burakov@intel.com> From: "Burakov, Anatoly" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU2PR04CA0292.eurprd04.prod.outlook.com (2603:10a6:10:28c::27) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|SN7PR11MB7420:EE_ X-MS-Office365-Filtering-Correlation-Id: 79a15e86-8bf3-430b-d653-08dbc4ce55d5 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: anZ6WP/tlhlpIMABBMkX2TClkFO4xYmey6q3YjbpVmFbCUXtyIDJ6Tak/U+gzETVHgWTfR6pDhBV7HFdYwOx3yNtb9yuO0HtLo9DUiVRyvQICZJr5eIUlI3LVsCEiIGO9gnRGdVPeet8B9cDNwA7xDATflxWIw9cMAhz+INWjFFA5aatedCMqNakHIYFdh72ilc6Eq1wZcTI7B/4DwPEDF9M1pTD7d+wPI9MFuj/uzfTc1QC1AnLT1MMlOsZaO5XdWJibcQULcvkwqr1H4nK1vfKVWFkpbnrJE7r6Fm5Nba59GRj0Y85aIVrkOSeSEaHXFIH5Xoy3lD3oA70/97do5u9PGtrgexAHOrIZ8ROdHq0Wuy1iSwDUcCh6iJ5i7vsPOtdrMTKrWlLbMXdnqm1j6aIRTI/uj5ORaSCgiqT9aCI6OYu6+fa98ZatxvyTpk8FAV9wVseTv+yoyeSXkXDWJgyNqkBSvdHsjcGs1fu+5JxiuggPp2biaEtVwUJ88JBZp67lTViKhfsZBrihzswb0oE8DPqlgo3TN4gGtQ07Y8sAnFkaTMynkVkDm6F7EK9Vk0g+EQlrIF6dA+UqPVLeBJHfXZDURkuVMNwRvnI+/sC3OQwBB4zsZyiS97CZZxtae+gq7NbPsO8Za3kDE0fgA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(136003)(376002)(366004)(346002)(396003)(230922051799003)(1800799009)(64100799003)(451199024)(186009)(2616005)(26005)(82960400001)(6512007)(54906003)(110136005)(53546011)(66556008)(66946007)(316002)(66476007)(8676002)(478600001)(6486002)(4326008)(41300700001)(6666004)(966005)(8936002)(38100700002)(31686004)(6506007)(86362001)(2906002)(31696002)(36756003)(5660300002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUZacUx2MlpWY3FTZWZUK0tYOTdIWkU3Q01SVjRSRGJzWllueEV5OWpnamln?= =?utf-8?B?MzdpUU85S0RhTm9SdXlBR05oOFZJMXpQMkJGU0VJdkZrS1pzWVhOczZvTFhR?= =?utf-8?B?cVQ3cTMzM0QxSDhVVUVhUmF3SHhCTnpMZ0JsV1NKd2ZtaVlrN1JHanh1ZjBC?= =?utf-8?B?WmMzMWZ0V2RsODVSbU9FenNjQk4vSnJ5R0dzSEJyOXJDWGF0Y21Pb0h5TGRG?= =?utf-8?B?MGtrakxwTWVibFE1RFRMU2g3VjEyQXhuSmJGZytyNndlSWx6V2MrVzlWbEdt?= =?utf-8?B?ZVpkNGR4bFg5bEsxcnZrNkY5eTBFMlNPSTJ3RGdtTS9FT3FGUEcyVVZ4M0hp?= =?utf-8?B?VE5mVURqWUp1WEM4dWJYVmtYR0lRQnJSTE5hZysyK1VtVCtFS09lYzhhWHRM?= =?utf-8?B?VHVIeTN4M2Voc3VJZ0ptY0N6elM2RjdsSU0vTUo3STQyVGhWRnI2ZSt2WFF4?= =?utf-8?B?b2xzTGNMWlVmWHpyQzhqRkQ3cjJNODFiSG1LZEhTOTA5WGt3bE12MDZxb25Z?= =?utf-8?B?bkIxR004N05QZUlpZjFKKzRxaDZIYXNtdjJFZDlrTmZhL254Vks3NVhCTzRE?= =?utf-8?B?S21QVGFpRjY1OXFlN3FPM2twRnlZcUJ3Q3YrRThxVnIrVkNOK3pUbG9teHUx?= =?utf-8?B?UFRTN0xpRGVRMGpLR3RXYUY1dHkrSjBodDl0dWJkT3k5U0diOTVxZ0hLNXRX?= =?utf-8?B?LzdhbHloeFdIYkF3c3c3QkdGeStHbkVyY25aNFpSZEVGTnlCVXBrVy9TUlJW?= =?utf-8?B?OElDei82Ykw2ZXRmRUJVUk1hZXFsS09MOHVTa25lcU53VEZPRkN2YndGMzg3?= =?utf-8?B?WERJSm8rb0Y2QzViV3phcUJUeXoyR0phRmJBWUJrTWRxbTAxdk9qakFzcjQ1?= =?utf-8?B?Mko5ZkNsamQ4ckpTZDFNTzZNMUZ5MC95djVnYUovOXI5REpndzV4MVM4RzY3?= =?utf-8?B?UjIzd296emNNbE05MzhLaDZlZ3hwcFJLQ3dLYjNaQTFLZnZQYm9jZXEzbG9X?= =?utf-8?B?QzFZbFk4MmMwUnVIMnBrQS9CVGI1Qk9YUnJYamMrY3ZyRHdkNFd4dHh1N2Fm?= =?utf-8?B?cUdnZGVML3ZQYStqcTgveFRYTEQ0dnIzT3dPN2RCUEIzbjdaUlRwU0t1UkZM?= =?utf-8?B?KzMwZUZyTkczREMyVmNIb2JvaWVoUVdUbE9uRVV1ajJlY0Q0RERrNTR1UWgy?= =?utf-8?B?WWtodnYwbSt2RnVDcUtlN3VZS28vbGRaUXVlbFpmQTVBdncySytNMC8wVkUx?= =?utf-8?B?eXNBWDQ2RUdwZGVIWDJWMS8xd0VBTnBHbVExK2VNcXkzb3JEZTZrRlhJU2FV?= =?utf-8?B?VHlrNFhuNkZWQ2RGWGQ4NUdkVmdoa2d3eFVPZDQ2bXUzOEl3MWxGUjBqKytG?= =?utf-8?B?d2pxT2hmd1pSRCtqZ1A5TW1xekFzTHhnOXhLVzJHMG9QQTBGN0RLbjZyQ3Fu?= =?utf-8?B?WE41UWpnNStGY2liMi8xTHNPditwV29GNHRmcldSQmhBSDc5NlM4NjNUVVdB?= =?utf-8?B?OEFLM1gvSUlNR3Y0YWJ6Mm1DOXNidnpzMWJnMGJvaHk3aXo0RzBaUDZnRzJ6?= =?utf-8?B?eGIxdlM1cEkxN0oyd0UrOWZGTnFqSUJaNFpmNm1BV2dHa29MNk90UllVTHB5?= =?utf-8?B?OVVJWjlvUnM1UWh3YXJqK1g1L2ZWZUJvc2FqeEFLWVdreVhhaHV4MzRwcndC?= =?utf-8?B?RFNLQloxQUlzR21Sb1N5MTBjeGQ1aTJzSEhyejMyWXhsbUtxQjFIb2FRWC9u?= =?utf-8?B?QWp1TkZwRWV6aHVJaDZHMmY3NFNJc3VYVUJpeVk3NnM0NHA1VE40TFd4V1gy?= =?utf-8?B?NnZ3NmlkVml6M2NnTkFhQ1hRWjNrajF6RkxKOUZxTzdKQmtGQmd0WG0zRXN1?= =?utf-8?B?VUlsODAzZHZOQi8ySzFaUWpPeUsxN3E5aURqczlFWTYxREN2QVU2c3lwWUhR?= =?utf-8?B?Zk5ybWVRLzlKRm45b1FHelBUTy9VZHo3bHkxSThCeEJKdm9qdjZWMzhoN01T?= =?utf-8?B?RUxWTDV0dG15eDZ3WW92aFYrV1kxVEFwU3NFZlhtM01uOGlpWE5NamcvYldP?= =?utf-8?B?UmJYNWx5TCsyemVBc3ZYdUpjbFhuUFpKaDJBd0phdGJVN2NSMjBITVBUNjBL?= =?utf-8?B?OEpHc1BsK1FJWHZPcjZrblI0V2VjdDlPbXA0N0xrNkYrVXpmUmxHQ3M4Zkxt?= =?utf-8?B?QWc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 79a15e86-8bf3-430b-d653-08dbc4ce55d5 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Oct 2023 11:37:48.7891 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: whu4SI/nmn5tnDRSeV3/owuZ6ph6Gl+ncTvkbMS/iXjd0LS4yoFedwHWHL8EL3OyBBHo2Z0yZfqBwxmpdUxpg+o2P5uuyoPnItYau+hjDD0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7420 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 10/2/2023 9:25 AM, David Marchand wrote: > Hello guys, > > On Mon, Aug 28, 2023 at 2:07 PM Anatoly Burakov > wrote: >> >> Currently, the rte_rand() state is initialized with seed, and each >> rand state is initialized up until RTE_MAX_LCORE'th rand state. However, >> rand state also has one extra rand state reserved for non-EAL threads, >> which is not initialized. Fix it by initializing this extra state. >> >> Fixes: 3f002f069612 ("eal: replace libc-based random generation with LFSR") >> Cc: mattias.ronnblom@ericsson.com >> Cc: stable@dpdk.org >> >> Signed-off-by: Anatoly Burakov > > We have two series for fixing related issues. > > Stephen alternative patch 1 handles Anatoly fix here. > https://patchwork.dpdk.org/project/dpdk/list/?series=29449&state=%2A&archive=both > > I see Anatoly was acked by Mattias and Morten, though Stephen > (RTE_DIM) fix is more elegant. > How do you guys want me to proceed? > > > Thanks. I'm OK with either, so please feel free to merge Stephen's patch :) -- Thanks, Anatoly