From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30FB1A00C5 for ; Tue, 1 Feb 2022 13:21:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21497411ED; Tue, 1 Feb 2022 13:21:11 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 0334340691; Tue, 1 Feb 2022 13:21:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643718068; x=1675254068; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=FHMwIMJQmxrs/09ofwv5gGaPxKiQIMwwMd4PEYw+neI=; b=mq4iKmnQ5wk/bCugCezwaCyMsLClsHpdhuRJV7Ybpx4ys3uJi1jLqSa/ HgCFIMxc75SMOoLasOCZCjcqPB7QZISLBeIub0mRydU9qnJUz5JEWnz9B lX3R7D75ZG77P6/qltQ05fEhYCOdyWTIepC1f5h8fBkLqdFfbO26DLlY6 bqdVlEQxNvwBV0AOm8Y3z3fFEdMXeL3e9KOWEDv1p9t6djZlIOXrYD0Br qOR22IhTSm3AUleODkx38FqvlDtFl13x9/APYASdPtN/WUW4LztwAoD5C LSKq74UGhivcVC3Wcy2uhYqE6Ar5rqWTD1Kdtov2nFVGxhu+D+4Rwexxz A==; X-IronPort-AV: E=McAfee;i="6200,9189,10244"; a="308410628" X-IronPort-AV: E=Sophos;i="5.88,333,1635231600"; d="scan'208";a="308410628" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2022 04:21:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,333,1635231600"; d="scan'208";a="583013500" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP; 01 Feb 2022 04:21:06 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 1 Feb 2022 04:21:05 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 1 Feb 2022 04:21:05 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 1 Feb 2022 04:21:05 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 1 Feb 2022 04:21:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C+NFPVyAxln7CwBreiqefafAsy97TahUjcUFj7CMgJuOLqgZKf/nkzKuAkjx45m3bErSX/ZQfLSYwmWN6+boulR0MmZ6BHaRpW5RZcDB867+xiXuvyo36uos7lh9iVnNlXVfphowsiwH4mCqBRlrVnx2q0OtKQlAY3Z7Ig+yx0aezzUiipSr3JMTs6C9R3qOYBOs32QuMqZpJFx/Iq9L0QvGEUIJvpAxux+TkFPy8B6y+YxMJFVZxsEU7+XmW+GF8zM/6bm40Ts+F6WXO1Ps23qkv4Wv44GKCx/er1LI/WEwOW8+xUnLOws4C9y83uTDl+5T+B39ivPGazrDyW24yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DJyNq6Hpnl0m1DZsY7eG9l0U7rUUl9E6LZbeHLFJmEM=; b=nY848OJpdEwjRiFGLYlcfwb0QGEeN6qgxn/NxqwWEaRWG2GykDklJ07Z4hpH5+qKWOBoRyMzcZmAyDvOwisKGUoi+8nckhw4Mbs2KEPycMI0lifKHPkwCgBIQvsjNNGEgfFxW6kSBCqQpeTzM6xaOKQdFIdxg8ElQ6+GShdyOyD2GW1mPGEjnlmNRCv4z07pjI2ueebmy6ut93XsON6f6KGu0jQowlhwJZ6rS3DnVGR+TImY8UUmYD+aMhOTK46cMZS5kLmOYa8ky3TxU6XzY1Kqo8MiY5TMOPytk+IGLyVGNgWJ57LR9E4SzsJfjkqBMdqBFq3zul+o4uxjBR3OMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by CY4PR11MB1367.namprd11.prod.outlook.com (2603:10b6:903:2d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.17; Tue, 1 Feb 2022 12:21:03 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4930.022; Tue, 1 Feb 2022 12:21:03 +0000 Message-ID: <08bb9446-73fa-4c11-2a86-fac1ba1a6edd@intel.com> Date: Tue, 1 Feb 2022 12:20:56 +0000 Content-Language: en-US To: Ori Kam , "20220126063016.2384393-1-jie1x.wang@intel.com" <20220126063016.2384393-1-jie1x.wang@intel.com>, "dev@dpdk.org" CC: "stevex.yang@intel.com" , "aman.deep.singh@intel.com" , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , "andrew.rybchenko@oktetlabs.ru" , "jingjing.wu@intel.com" , "beilei.xing@intel.com" , "qi.z.zhang@intel.com" , "olivier.matz@6wind.com" , "stable@dpdk.org" References: <20220129062434.2455711-1-jie1x.wang@intel.com> <20220129062434.2455711-3-jie1x.wang@intel.com> From: Ferruh Yigit Subject: Re: [PATCH v3 2/6] net: fix L2TPv2 common header X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0257.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:194::10) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5b43170e-199e-4774-9f03-08d9e57d500d X-MS-TrafficTypeDiagnostic: CY4PR11MB1367:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:14; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sTNb6m+qjDPmenqz4wor6a4aEl4lPmS64zs6llUHeBweZiYG/wije5yx3d0glMc2wrD5iMVdLHMFVtA6Q5j2pbGgsPkdwnUCvHlJ/fSAF0iT9tPVDA7CCqy8r3udyAxSDjc5NZXCdpYdynVwgePEh/LvuWeGuFHPH+mqCjv51fz75iPzvh7ysDeFPnG7RNGNbB65ff5PJpHLAqHpyciMB3+2Lfzu+MNlqisVcbxSOUaprIfqzqvf0sp6/VdzMizBkKYeheYDz4qBHqvKkPwW5T0NqmP7zNy9/Gn6MMrD3cROGFReIHLXsaYUoWi4bRBzJHjIqQBqJjJQKqrc0ZUlcSHREa7AheMJDYCOr3/FlJ9VBGS7fXoS8htlgDmk5LdIKWyl38V1geGxCBqsHawyz2jlWtZwaa3or2FpF3M1NmVAv/czzhAczzJdWTxhOJndOfcnRgYrMqTGs7RQp/CmocqgxhIDyfoq0qrXtbIYd3cVmjarbM8W/a/MCZk9lqeziJoB9e3Yr2dS+n+eZh8EmCTB/FS2Yz66g+cG2yRSHXbBSHldK6kvnCngCOM8iBOpU3Z/neu2mdyoe4wK3KyPym/MA0kXOHh34QAcU7yrjRBVjvlGbkaav02I2AUuBwJ4EqGXU44vQV/WklPiOneO0U3IvYn/GHAFbYXKTyGo6qL/Y+4YCxC1c+j4VCqLkwgStsgonRT0WBOVDdx1bB8pn6FXt2O1d8BdcD4GqSTNuDZEO0Mnxx7Ot1M3erUeYWmTdd8yE1RUNL3IHhTkjLzt9muU+ttMeseiB6+6+1Ivx+s= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(82960400001)(66556008)(66476007)(508600001)(31696002)(86362001)(6486002)(966005)(316002)(31686004)(38100700002)(54906003)(66946007)(4326008)(8936002)(36756003)(8676002)(186003)(26005)(2616005)(44832011)(2906002)(53546011)(6506007)(6666004)(55236004)(110136005)(6512007)(83380400001)(5660300002)(45980500001)(20210929001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c1VVT092dFBha3Ura0xLZDRpcFZ3SFZkMjJxUlFzeTVwcHQxWXl2eEI0Z09i?= =?utf-8?B?MHc3QWtYN2Z6cjVvbXpHMnhmb0l2SDFVY1ZWMkZtbE03VThCdFZRemxPdkJ0?= =?utf-8?B?bVJGdWxNdVkvRWFkSGg2UTJtdzJ6ZjdYYmdvN25lL1JDdWswb202VjlkYm41?= =?utf-8?B?OE45Rzhtd1NXblYzNVJHaXFZVTR2T0p2ZENqVnExT1FEOXVzK3EyU2lxK3oz?= =?utf-8?B?YmRXS1ltbUd3RFdNV012VTcvMFVpelJ1MEtuYW9IcDNWVlpOMXN4YU9qbkpt?= =?utf-8?B?MWEvamxqTjhkSUZ1V3JDVlE5TTAwd0Q0WDQzeGZGa0lCbU9zcHB5NFliYjQ4?= =?utf-8?B?NVQ5czhTMFptVjRMMTc1QWQxTDFoZnlXVS82dCs4Z2p5UkJJR29qRDhxenhL?= =?utf-8?B?RHZMTTJoRUF2Z0JaTFhMRVZObm5uOFVQenBsMFFRSWFOY2VUb3FhS3JxaVRD?= =?utf-8?B?d3gzTkJTemhhT29qSVVxM09qd29icG5zZDZ5UytiUUtrQ2Y0UlpieE5kRDZP?= =?utf-8?B?blZ1T3Q1bm4wQ0EzbUxtdCtERW1kWWVyT0U4SkhjRVlXc3NUVi9aUFpzdUFo?= =?utf-8?B?K3kvZnIvbGwzR2toa21NUVRzd3JuZlFSVVdVTUljWTZFeGtRNHoyVmpibkh4?= =?utf-8?B?akdLdnd6QUdZREx0M24rVFRPUXhBTjZJd09BVUgySzMvdE4wdHdycUlHQzE3?= =?utf-8?B?VDRvMFhsWmhJU2RoWnJkcWJxZ1RsVUtycEQ3a1YzNUZsZVAvSDNPS0JlTlFZ?= =?utf-8?B?WEY1ZVVxd216YVhJSU9UWDRzTVdIRGk3djhPMEp4K2hKSWdiTDBqc0RUd0J2?= =?utf-8?B?KzBIeWdRbU0xNURWZjNFakV0czRjVXBZUjNlakFGT2xUTG51K1dXL3YrRHp5?= =?utf-8?B?eUVnR2VFY2F1K1MrVU1rU0lJenAyUE8zdWFSMGhvcURiQVk3SVBBSCtxYlV5?= =?utf-8?B?RXNPSG43bktzSFViTU5jeDdJV0hFL2s3ZGRjTGdSRVZNOTF1MDhQeUtPVmJv?= =?utf-8?B?eFh4RkVzWllIQk9IcUpJZHZSdXhxZmUzcWZRU0NrbWcrdUF1SmRFY0s3T3N0?= =?utf-8?B?bDc0dFc0R0RaQUozZlluR1ZIaTg2SkdwTUIxMGJ2cERhdUhEQWtMTFdzR0c1?= =?utf-8?B?OWxSRDBPU0g1WVVvWEJnRGFvMkk3dG5rMVNhSHUzS3YwVGNKbHZ0SEpJWVgv?= =?utf-8?B?WDJRU2lvN3lvVjg3eWtiUDdieGNIMStUenc4SnBEVXU5MVdNRGFPZHZ2VWll?= =?utf-8?B?cXhVMWRuR0xGZDAxSkFlcUcvYjVlSmNNMWtTM3dtNUhkVTNUYms5dUxZNkpz?= =?utf-8?B?L3hINnZFZ0x4Qmp0M1lRYzRGUnVlNmlNRS9LcmNHaytOcVd6RG5Ucy9MaFFR?= =?utf-8?B?cUwwRERiWHVMNWlQUGpZQVQ5aVgrdWtpajJVVmNCVHJaVFhrY0pwTHNsZW5s?= =?utf-8?B?S3pLTEpIdEt4bnlmbmwvMnJmZm0xTzk1Vk1IZ1ArajVIb01KQlBJdC8rN2V6?= =?utf-8?B?NDVIbFBhR3ZVckVzdGhlbm96SUpmYmhJazdDVHlVNkVza3JPRG9OeXZ6TnZP?= =?utf-8?B?UlN4SE9GcWtRRDJObVErRGVYRWdXTk1Ma2F1RHI5Yjg2cXdZSEx1SWdsaUhS?= =?utf-8?B?V256K3QweXFibHg1a295bXNNKy9RNCtqY3FOcHRWRHErTnBZNUg2NHMyWjZF?= =?utf-8?B?U3hQYWY1VHcvZUNsTGkzZ25UUzI5NTVoQmNFeHJhQWtDbkgwQ2RuMjM2aGEz?= =?utf-8?B?ZEdIV1NwWDhlUFNKL2M3ZUxqdHBzSjhFZFdvMDJnL1FLc3Q4WVllZGZVRWE3?= =?utf-8?B?WVlYWFR5NzVvR2ZxemQvUGhvWmtSVlpBSzBlUFhoT2NjaVJ0MnNwWm9oNm9v?= =?utf-8?B?UGJOVFpZN1RUZmVQaTdyZ0lqMXd5YXRLWGlTaUM0TGNaSlFNZThGNC9XUlF1?= =?utf-8?B?bWp4VE5tTG0ySnU1blhydHZoRTJQODZSRHhoS1o1RktlT0o1UzdGTjYyRnFY?= =?utf-8?B?YjZ2SWxoTWV5MFAyeUZaWEgwaDZQVmxVRyt5cXY0NVJ5REZvRTBDRDBhSmxr?= =?utf-8?B?OVR4NmRKQTFJS3FYeXJpT2IwTjFVR2NEcExRdWZtam9TdHYzMWEyeGFwdkJz?= =?utf-8?B?Mld6NWdJLy8rcC9GRnRENktnQk5Dd0dwUWgzWG5XbGpoQ0ljTzVRYWN5NFJK?= =?utf-8?Q?D74vwJHNyoXQXvx/l0gxfJA=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 5b43170e-199e-4774-9f03-08d9e57d500d X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 12:21:02.8721 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LN2fU9GV2A3KX5eTL0cdHodKjfUNlhVw6wsFb/vQgDY9w9CSouoH9nbzo4Am5BMamNl9irogca8rwV4pLrlj2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1367 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 1/30/2022 9:17 AM, Ori Kam wrote: > > >> -----Original Message----- >> From: Jie Wang >> Sent: Saturday, January 29, 2022 8:25 AM >> To: dev@dpdk.org >> Cc: stevex.yang@intel.com; Ori Kam ; aman.deep.singh@intel.com; >> ferruh.yigit@intel.com; NBU-Contact-Thomas Monjalon (EXTERNAL) ; >> andrew.rybchenko@oktetlabs.ru; jingjing.wu@intel.com; beilei.xing@intel.com; >> qi.z.zhang@intel.com; olivier.matz@6wind.com; Jie Wang ; stable@dpdk.org >> Subject: [PATCH v3 2/6] net: fix L2TPv2 common header >> >> The fields of L2TPv2 common header were reversed in big endian and >> little endian. >> >> This patch fixes this error to ensure L2TPv2 can be parsed correctly. >> >> Fixes: 3a929df1f286 ("ethdev: support L2TPv2 and PPP procotol") >> Cc: stable@dpdk.org >> >> Signed-off-by: Jie Wang >> --- >> lib/net/rte_l2tpv2.h | 20 ++++++++++---------- >> 1 file changed, 10 insertions(+), 10 deletions(-) >> >> diff --git a/lib/net/rte_l2tpv2.h b/lib/net/rte_l2tpv2.h >> index 938a993b48..1f3ad3f03c 100644 >> --- a/lib/net/rte_l2tpv2.h >> +++ b/lib/net/rte_l2tpv2.h >> @@ -89,16 +89,6 @@ struct rte_l2tpv2_common_hdr { >> __extension__ >> struct { >> #if RTE_BYTE_ORDER == RTE_LITTLE_ENDIAN >> - uint16_t t:1; /**< message Type */ >> - uint16_t l:1; /**< length option bit */ >> - uint16_t res1:2; /**< reserved */ >> - uint16_t s:1; /**< ns/nr option bit */ >> - uint16_t res2:1; /**< reserved */ >> - uint16_t o:1; /**< offset option bit */ >> - uint16_t p:1; /**< priority option bit */ >> - uint16_t res3:4; /**< reserved */ >> - uint16_t ver:4; /**< protocol version */ >> -#elif RTE_BYTE_ORDER == RTE_BIG_ENDIAN >> uint16_t ver:4; /**< protocol version */ >> uint16_t res3:4; /**< reserved */ >> uint16_t p:1; /**< priority option bit */ >> @@ -108,6 +98,16 @@ struct rte_l2tpv2_common_hdr { >> uint16_t res1:2; /**< reserved */ >> uint16_t l:1; /**< length option bit */ >> uint16_t t:1; /**< message Type */ >> +#elif RTE_BYTE_ORDER == RTE_BIG_ENDIAN >> + uint16_t t:1; /**< message Type */ >> + uint16_t l:1; /**< length option bit */ >> + uint16_t res1:2; /**< reserved */ >> + uint16_t s:1; /**< ns/nr option bit */ >> + uint16_t res2:1; /**< reserved */ >> + uint16_t o:1; /**< offset option bit */ >> + uint16_t p:1; /**< priority option bit */ >> + uint16_t res3:4; /**< reserved */ >> + uint16_t ver:4; /**< protocol version */ >> #endif >> }; >> }; >> -- >> 2.25.1 > > Acked-by: Ori Kam > Acked-by: Ferruh Yigit What do you think putting the link of the related RFC in the commit log for reference: https://datatracker.ietf.org/doc/html/rfc2661#section-3.1