From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9AFFDA034E for ; Mon, 21 Feb 2022 14:06:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A1B7410F2; Mon, 21 Feb 2022 14:06:13 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id A74AF4013F; Mon, 21 Feb 2022 14:06:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645448771; x=1676984771; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=1/DoSCS3RPhQxBWqX2fufOIYNFsptLznUoRPR6et6o0=; b=A5jzeJBiaCqSkxTE/j1NneGcxA+Upp5T90z4s8SnX1HOuZd1j44N8CX2 hkLdqAUR3BsAHYtb20WPiWlmG6ptq5H6y1/J0PqemvYkzfXGezLhldiKL l/WgRfyF8C0KQjX6Hu2yCaaX8haswznLFoIZmMfqzY80/eRCkI+mXID/Z OQPltobfJ67yQFZ/fiQG0P9qTGO6X5S226/JcXK/FOAIR6usC7DdFroYh k+2kLpFLfRSTY9X+aUmyNEScYpYRRJ9CNQmiz5OY5RVihDt/yf46+ywKP eeER49BUKkTKs+U7OD1AR49a+GED3NcJxqBQIRHTawrEvJ32malzSybOQ Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10264"; a="314767164" X-IronPort-AV: E=Sophos;i="5.88,385,1635231600"; d="scan'208";a="314767164" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2022 05:06:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,385,1635231600"; d="scan'208";a="706250235" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga005.jf.intel.com with ESMTP; 21 Feb 2022 05:06:09 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 21 Feb 2022 05:06:08 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 21 Feb 2022 05:06:08 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 21 Feb 2022 05:06:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bSElNXRzdmnwfkzo6VzzI7Jvw/kA0pyImIw2aKOgZPuB82/Wi+FCfJVqVJJcWGvGiVAov7relvV0AH5jEPNtyKN2Z5H1tsAuP6nPt8E4Z6C3N4SJs6k4mTGOg4V4LMW5HRaBSb38PX7fr8Lkdnrum8SAFmA5L5isCtpVfbsepxdzziwYEG/VWDglxbDcyyrL65PfiyBJwgbaUpLk6TSffvH/n5VtRJP2LrJvOmL3EzAXrXvXyrwMbflBqoGZhSRmIjnyUa5R+hx4d4Ij5Ko7tX54wmT3gDFTpbUuJL1zo0197dbtuODHzyWTVXZxxc+z45aZ84cmwO+0CRp82lLqDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rJLvYcTs1h0sfhlR2XUjf4y7vhcP8ml51UrzFBCHB1E=; b=X3GIjdTExSjFU8XeQMjKcSaU/ldcGhGWmEkCU5ASN7TkYazY660hoRaFtl+h8U2U060aPaxOuy9xQ0P+X9kZFW3okCTK5yeK3MUgypVucQAHlv2BdoLwMX6/NXNrzvMa3OfE1+rmQkZdnQzMOhD752LrmbVBuuGHvlj7vo3yAr3dhIHLzgzQX/diEZwngQo+foxN85QeU6+/rPXTymlbjYM/YppIV+d5tKZzyjGPP024tIu5zSa5mZCOi8IsUD67qSM3K/kzlEwhsNTcNhyShDrQl1yRBlxMKqKder2CCB4p4VSn2sM5WqwwE7MyrenY18B+nHqxScnYOF7HdAHn0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by SA2PR11MB5179.namprd11.prod.outlook.com (2603:10b6:806:112::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.16; Mon, 21 Feb 2022 13:06:07 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4995.027; Mon, 21 Feb 2022 13:06:07 +0000 Message-ID: <090d35bb-fbab-1572-d8da-94d5156c22e4@intel.com> Date: Mon, 21 Feb 2022 13:06:01 +0000 Content-Language: en-US To: Jiawen Wu , CC: References: <20220221092121.2145802-1-jiawenwu@trustnetic.com> <20220221092121.2145802-2-jiawenwu@trustnetic.com> From: Ferruh Yigit Subject: Re: [PATCH 1/2] net/ngbe: fix debug log X-User: ferruhy In-Reply-To: <20220221092121.2145802-2-jiawenwu@trustnetic.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0031.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5c::19) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6a0d5524-b534-4622-47e8-08d9f53aec1e X-MS-TrafficTypeDiagnostic: SA2PR11MB5179:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gFI/fHHa35X0de/7um30bdnEFJGbMsfDdNiHEuTfbiMmNVVx9PzhHuYQkGcoAjJypS9440+vlOO0r+fnR6ADSVWU6JsRWu8NpVrBZJgnx1Fzj7nno2m4Xfq68u6ub1DobjvK3ni9oeJcrZhGXFNhtTbZ30EYhWUkq+O4MtcsR8cwfmRAgvRzZHjU/zeqKK7ymh4T4NtAHxeqoqSli59YhI8WOriDPXWEI6d2BWYszOTq0sv6x5kQxOIfReCLCGqIeKzfiWmhk6+T0HKGFQ2X3hj2XCampC4jyG54w6PSwBa8AQBsBzeDfQvhh1gIvu50MZKmTTIywhAQF2zB8mkI4Y7pVe9sETQ13ORmR4DosKhutTnhQ7w2SfgiTdz26Bz7BDvpduMeaNDj2dihJCkCCInvxfnF9coZkZjbLUe1OIWkbiyMUAkQY0Ok/5EU/N1k9oc52rEMaAAgT+gNqHv3IyrQzZvt9XEkirIlrNSy2Q+CbtYkupY1SLTUQYvEUPiVShSZON7BdF50wzJSqQ93kzAetfVQd8pbNi8I/rDai2yhu8mzaPISPnginaiqXeVtOy66fkpSKzU7nN/E8nHzRjiS+uq4Ve79wEclt4S+ymvCO6pxoKnCDPX0pE0H3wTRSGmu9DIhx0K7Jq7udyrIdimdVG6JX6dTTXgCgQMQlrkBzBTr4DXJu8Zal80YYygdThyebH7qCvy9hnwhSOfcnQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6506007)(66476007)(38100700002)(31686004)(2906002)(186003)(66946007)(82960400001)(26005)(53546011)(44832011)(36756003)(2616005)(6512007)(8936002)(6486002)(316002)(6666004)(5660300002)(83380400001)(4326008)(8676002)(508600001)(31696002)(66556008)(86362001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUk3OStUZWlERHQvVWIrQW03Q3l5MEFyaDIrbjc0RmRFazMzWGRrM29mWE1P?= =?utf-8?B?WERpaWV1b0hnQkVBTExCOUN4SWFPUU5Rc3ppR3UxK0libllhc2x4Y001Szkx?= =?utf-8?B?VkN0Sm9xOHpBN0RWWjcxQTlYaWZmY21SL1EzUndhOFVZdTJGOXFhQ0srVTl6?= =?utf-8?B?YnZVWWVHV0JWVDVROENzWHdlclNLM0UzV3Jmd0lmdkZkYVdxajZFbEg1NEJQ?= =?utf-8?B?aHJkSkN2OWFuRTZlRnUrRk0zVHRLZ2VySVZNNWZTdURKYWY5OTRNUlRaUkF3?= =?utf-8?B?RkdIbzJCSTJRZndaS1JRUnJOTFNxQW96SEt4WlFxU1B6S0diYjRTako3TklJ?= =?utf-8?B?dm5sSWNyYjFTYnVTNUJVTDVRMkNDV0dEekFPdGZjNXlvVE1uMlVveDlLQ1RY?= =?utf-8?B?OC85STdhVERwUjMxcU81dTZQb0N1dlBiTEVIajdGYTNJQTM5V0lLZTZwVDhS?= =?utf-8?B?WERuSk8wUHM2dDViZ2liam9nV1VERy91U1pRZCt0cUVmS2dvR0M4TjNjUEts?= =?utf-8?B?UmtKaXBuVzR3VC82UEI4UVBTVmFQNk9SY1IxblpERmRxUzRGdnBvQU5hNXNz?= =?utf-8?B?REdTaHNUM2F6VDBXM0NqM2E0ZnVaWUpmNFh0ZUhQMFdYRlZxWjRFNlZNdUhP?= =?utf-8?B?eHRFa2JHajRudlZoSGdDS3I4VmxuUGhKQUpNbG44TGxoTHk5cXkxRXhLR1Rp?= =?utf-8?B?OE45QUhmQ24rRTlKL09YekFTcmtGNFo2dEQ4dEJHSjEvYTZpWkpzYmVXRFVw?= =?utf-8?B?dFlVbXBlMmhRYzU1WDg0cWQvRkVoNEhEc2kxV2ZEMUJSbzdrYjcvd2JwMFJs?= =?utf-8?B?dVdadllabjJxWGpWOGREY0R3cGY4ZlRYSVIvQW52dmwwQXBWdC9tR0NNTHZv?= =?utf-8?B?alBWZ1YyMk41ZFUra2pQNWlRd05MYmNCTVY4KzNuWXZwYWRldlNvdmRYeXFD?= =?utf-8?B?MC9QT1lmUkxiT2RNY28ycUYweFZlQkZsbWdON1FJeG10a0R0OG1GYUUva3FW?= =?utf-8?B?aEhPT3U0NFlWSy9Lc2szdEdOVkt6Z1lJaU1JQ29Wd0pnZDJsYW5LeDhZWVg3?= =?utf-8?B?V3RjL20veWJiTHAxdU5PZ0x5UWdVdUZEZmxjR3IyQno4Ni9MZjFCeWYzRW9T?= =?utf-8?B?Y3JXUFFpcGVzV09WaVJSMmxtVzRHUmZrMnN0R24zc2JSRmpsSXhxQ21mNlF4?= =?utf-8?B?d0ZTTGp3eGxiWGtXRVFhNGZlcFNicjdpZWRkZjJRRVBvSVA3cXlyV1VyYjVZ?= =?utf-8?B?eHQ4SlZLMzFDdDVPZ0Iyd2dhdWx6NTFabUNWZ0t3THRpT1pRVkFQVlFHM2h2?= =?utf-8?B?Y1VsTTcvcHlYMnFPeFV1QVpNVk1VNlplSlM0Qk52V2lpTUtKVGhnSm90bFZ5?= =?utf-8?B?RjlMekwwOGJpZENCZkFhc2kwcmF2RGVBODVSRGJ2UE8ya1lwaCs3eTZ1Ylg5?= =?utf-8?B?Wm1oVk9PN0R5L3NMQ2tkcE1kMlBnaDBGUlZTSlMrcnlTaS9oQUtNeDRvckMv?= =?utf-8?B?WFU3bS81aWg0WFZuZnZITEtrdFV0ZkxBempMNzF5YUpXWDFYU0tISmVMMC9P?= =?utf-8?B?eFF5aFdNQ1MyUFROSjZ4ZnVuREY0MHAxTk10WWR6MWErY094L2RxY3JqUGJM?= =?utf-8?B?MmtQVDFBdDhaZjJCZkRSSk9aS2FIeUIyaVNEdWdzNVpsbU40NVJvL2lWalVY?= =?utf-8?B?eFN6MDRJTGVsVXdtRVAzOW8waUFQS0phWUJLbFNFbmUwam9JaFBNMEFCVVdj?= =?utf-8?B?Qm42L3IvR0R1M1ZWSGlncGc5OG1RTEU0RFc5YVBZOE8vS2ZoV2VrQUM2eDJS?= =?utf-8?B?cGZYdnp3Y2lOTXZyVkZJV2pvbjFLOWFUUEVXQTduQ0Zld1RNUVM3MVJXY2Fx?= =?utf-8?B?SnU5a2dJRWRPT3pTcjlncWk1L3NkbEd5V2xDSm5FaTNlTXk2S1lrems5aXEr?= =?utf-8?B?SUJDOXFQcm0xWUR0N090V0gwTVQ4ZWMveTRDRm1HNDdjOWNiaVpaU1ZDL0tz?= =?utf-8?B?NFNNS1FCL1RxV09FbFlYUmhYNHB2S1JndTdGZk01TnlFYWNFVGZWejg1RUdk?= =?utf-8?B?eUxWMGJIOFFBQnFaVWxxbEhWZWd3eEJORkd1aysycXdNZmVEZVh6RlBqYTUx?= =?utf-8?B?d0docnJiM2V4TFNpdzhMVGkrN0crQ002WklQWFBNUUg4NDFseDhNNkFyVGgz?= =?utf-8?Q?w/v9OLOk76rt4p9wAmiAkH0=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 6a0d5524-b534-4622-47e8-08d9f53aec1e X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2022 13:06:07.0763 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LfvgYf4Js4RJjhFYC1tPELrp9qkizf9SeluUBtI4R9ByElDorvZTejIHSyoenw+qhqNI3rR/sTHvsxqBauLWOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5179 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 2/21/2022 9:21 AM, Jiawen Wu wrote: > Remove 'DEBUGFUNC' due to too many invalid debug log prints, unify the > DEBUG level macros. > > Fixes: cc934df178ab ("net/ngbe: add log and error types") > Cc: stable@dpdk.org > > Signed-off-by: Jiawen Wu <...> > @@ -91,7 +86,7 @@ s32 ngbe_get_eeprom_semaphore(struct ngbe_hw *hw) > > if (i == timeout) { > DEBUGOUT("Driver can't access the eeprom - SMBI Semaphore " > - "not granted.\n"); > + "not granted."); Not for this patch, but for future, preferred to not break log messages, coding convention allows longer lines for log messages. The logic behid it is to let user able to search the log she got from the console and easily find it in the code. <...> > @@ -590,18 +564,16 @@ s32 ngbe_init_rx_addrs(struct ngbe_hw *hw) > /* Get the MAC address from the RAR0 for later reference */ > hw->mac.get_mac_addr(hw, hw->mac.addr); > > - DEBUGOUT(" Keeping Current RAR0 Addr =%.2X %.2X %.2X ", > + DEBUGOUT(" Keeping Current RAR0 Addr =%.2X %.2X %.2X %.2X %.2X %.2X", Not for this patch, but for future, there is 'RTE_ETHER_ADDR_PRT_FMT' macro that can be used for MAC format. It is good to use existing macro for consistent output.