From: "Xu, Rosen" <rosen.xu@intel.com>
To: Luca Boccassi <bluca@debian.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH v5] net/i40e: fix disabling promiscuous mode
Date: Tue, 1 May 2018 13:16:39 +0000 [thread overview]
Message-ID: <0E78D399C70DA940A335608C6ED296D739FA45E8@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1525095806.23337.20.camel@debian.org>
> -----Original Message-----
> From: Luca Boccassi [mailto:bluca@debian.org]
> Sent: Monday, April 30, 2018 9:43 PM
> To: Xu, Rosen
> Cc: stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH v5] net/i40e: fix disabling promiscuous
> mode
>
> On Sat, 2018-04-28 at 19:37 +0800, Rosen Xu wrote:
> > v5 updates:
> > ===========
> > - Modificate some comments for this patch
> >
> > v4 updates:
> > ===========
> > - Add some comments for this patch
> >
> > v3 updates:
> > ===========
> > - Move modification from device close to device disable
> > - i40evf_reset_vf() will cause kernel driver enable all vlan
> > promiscuous,
> > so unicast/multicast promiscuous disable should set before reset.
> >
> > v2 updates:
> > ===========
> > - Add more comments
> >
> > In scenario of Kernel Driver runs on PF and PMD runs on VF, PMD exit
> > doesn't disable promiscuous mode, this will cause vlan filter set by
> > Kernel Driver will not take effect.
> >
> > This patch will fix it, add promiscuous disable at device disable.
> >
> > Fixes: 4861cde46116 ("i40e: new poll mode driver")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> > Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>
> Has this or a version of this fix been committed to mainline?
Do you means to commit to Kernel Driver?
> --
> Kind regards,
> Luca Boccassi
next prev parent reply other threads:[~2018-05-01 13:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1521090873-50595-1-git-send-email-rosen.xu@intel.com>
2018-04-28 11:37 ` Rosen Xu
2018-04-30 13:43 ` Luca Boccassi
2018-05-01 13:16 ` Xu, Rosen [this message]
2018-05-01 13:27 ` Xu, Rosen
2018-05-01 13:52 ` Luca Boccassi
2018-05-01 14:29 ` Xu, Rosen
2018-04-28 11:38 ` Rosen Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0E78D399C70DA940A335608C6ED296D739FA45E8@SHSMSX104.ccr.corp.intel.com \
--to=rosen.xu@intel.com \
--cc=bluca@debian.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).