From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id BBB3F1B3BC; Thu, 12 Jul 2018 07:26:40 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Jul 2018 22:26:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,341,1526367600"; d="scan'208";a="215358034" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 11 Jul 2018 22:26:39 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 11 Jul 2018 22:26:38 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 11 Jul 2018 22:26:38 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.81]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.17]) with mapi id 14.03.0319.002; Thu, 12 Jul 2018 13:26:33 +0800 From: "Xu, Rosen" To: Ori Kam , "dev@dpdk.org" CC: "Yigit, Ferruh" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] examples/flow_filtering: add rte_fdir_conf initialization Thread-Index: AQHUGZ+tQxtXwC0mrU+ZE/7J7YYBkKSLDmZA Date: Thu, 12 Jul 2018 05:26:33 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73A13DA82@SHSMSX104.ccr.corp.intel.com> References: <1531361387-116027-1-git-send-email-rosen.xu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTVhZDlmODctYTdiZi00MjQzLWEwMzMtODczY2I4ZmM3NGUyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQ0o5SThuTFdsdGxsVWFleUVlQ3h4WTZQSTNZeW5KU0k0amc4cGE3ZVROOTcyRUptZFU2MHBFM1FXelJodGhuZiJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] examples/flow_filtering: add rte_fdir_conf initialization X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jul 2018 05:26:42 -0000 Hi Ori, examples/flow_filtering sample app fails on i40e [1] because i40e requires = explicit FDIR configuration. But rte_flow in and hardware independent ways of describing flow-action, it= shouldn't require specific config options for specific hardware. Is there any chance driver select the FDIR config automatically based on rt= e_flow rule, unless explicitly a FDIR config set by user? [1] Flow can't be created 1 message: Check the mode in fdir_conf. EAL: Error - exiting with code: 1 > -----Original Message----- > From: Ori Kam [mailto:orika@mellanox.com] > Sent: Thursday, July 12, 2018 13:17 > To: Xu, Rosen ; dev@dpdk.org > Cc: Yigit, Ferruh ; stable@dpdk.org; Ori Kam > > Subject: RE: [dpdk-dev] [PATCH] examples/flow_filtering: add rte_fdir_con= f > initialization >=20 > Hi Rosen, >=20 > Why do the fdir_conf must be initialized? >=20 > What is the issue you are seeing? >=20 > Best, > Ori >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rosen Xu > > Sent: Thursday, July 12, 2018 5:10 AM > > To: dev@dpdk.org > > Cc: rosen.xu@intel.com; ferruh.yigit@intel.com; Ori Kam > > ; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH] examples/flow_filtering: add rte_fdir_conf > > initialization > > > > Rte_fdir_conf of rte_eth_conf should be initialized before port > > initialization. > > > > Fixes: 4a3ef59a10c8 ("examples/flow_filtering: add simple demo of flow > > API") > > Cc: stable@dpdk.org > > > > Signed-off-by: Rosen Xu > > --- > > examples/flow_filtering/main.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/examples/flow_filtering/main.c > > b/examples/flow_filtering/main.c index f595034..aa03e23 100644 > > --- a/examples/flow_filtering/main.c > > +++ b/examples/flow_filtering/main.c > > @@ -132,6 +132,12 @@ > > DEV_TX_OFFLOAD_SCTP_CKSUM | > > DEV_TX_OFFLOAD_TCP_TSO, > > }, > > + .fdir_conf =3D { > > + .mode =3D RTE_FDIR_MODE_PERFECT, > > + .pballoc =3D RTE_FDIR_PBALLOC_64K, > > + .status =3D RTE_FDIR_REPORT_STATUS, > > + .drop_queue =3D 127, > > + }, > > }; > > struct rte_eth_txconf txq_conf; > > struct rte_eth_rxconf rxq_conf; > > -- > > 1.8.3.1