From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id AAF92A00E6 for ; Fri, 17 May 2019 06:43:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 53BD72BAF; Fri, 17 May 2019 06:43:32 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 03CD32BAF for ; Fri, 17 May 2019 06:43:29 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 May 2019 21:43:28 -0700 X-ExtLoop1: 1 Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 16 May 2019 21:43:28 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 16 May 2019 21:43:28 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 16 May 2019 21:43:28 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.150]) with mapi id 14.03.0415.000; Fri, 17 May 2019 12:43:26 +0800 From: "Xu, Rosen" To: "Zhang, Tianfei" CC: "Pei, Andy" , "stable@dpdk.org" Thread-Topic: [PATCH] raw/ifpga: fix logically dead code Thread-Index: AQHVDGIVK+4tjRs31Ey+QkgWHW5CoaZuvPAw Date: Fri, 17 May 2019 04:43:26 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73A753123@SHSMSX104.ccr.corp.intel.com> References: <20190517112516.28667-1-tianfei.zhang@intel.com> In-Reply-To: <20190517112516.28667-1-tianfei.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZDQ5MDQ4ODYtNDI1ZS00MGQwLTkyNTgtOGQ2OGRhNTAzMzVhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUGZod0k2YU4yOWZaV3JUOVZhTlFMaHZXdkFKeGVnVGc5a0JvVk5aN0xGOEZVbHhubjNaemFDbFZBRWIyM1hCWCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] raw/ifpga: fix logically dead code X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Tianfei, > -----Original Message----- > From: Zhang, Tianfei > Sent: Friday, May 17, 2019 19:25 > To: Xu, Rosen > Cc: Pei, Andy ; Zhang, Tianfei > ; stable@dpdk.org; Zhang > Subject: [PATCH] raw/ifpga: fix logically dead code >=20 > add temporary variable in max10_reg_write(). >=20 > Coverity issue: 337927 > Cc: stable@dpdk.org >=20 > Signed-off-by: Zhang, Tianfei > --- > drivers/raw/ifpga_rawdev/base/opae_intel_max10.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c > b/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c > index f354ee4b6..3ff6575d7 100644 > --- a/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c > +++ b/drivers/raw/ifpga_rawdev/base/opae_intel_max10.c > @@ -17,11 +17,13 @@ int max10_reg_read(unsigned int reg, unsigned int > *val) >=20 > int max10_reg_write(unsigned int reg, unsigned int val) { If you don't need to modify val, why use const? > + unsigned int tmp =3D val; > + > if (!g_max10) > return -ENODEV; >=20 > return spi_transaction_write(g_max10->spi_tran_dev, > - reg, 4, (unsigned char *)&val); > + reg, 4, (unsigned char *)&tmp); > } >=20 > struct intel_max10_device * > @@ -57,7 +59,7 @@ intel_max10_device_probe(struct altera_spi_device > *spi, >=20 > /* set PKVL Polling manually in BBS */ > ret =3D max10_reg_write(PKVL_POLLING_CTRL, 0x3); > - if (ret) { > + if (ret !=3D 0) { > dev_err(dev, "%s set PKVL polling fail\n", __func__); > goto spi_tran_fail; > } > -- > 2.17.1