From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 34657A05D3 for ; Thu, 23 May 2019 04:28:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0FA311B947; Thu, 23 May 2019 04:28:55 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id AF4952B9E; Thu, 23 May 2019 04:28:50 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2019 19:28:49 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga006.fm.intel.com with ESMTP; 22 May 2019 19:28:49 -0700 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 22 May 2019 19:28:49 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx162.amr.corp.intel.com (10.18.125.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 22 May 2019 19:28:49 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.213]) with mapi id 14.03.0415.000; Thu, 23 May 2019 10:28:45 +0800 From: "Xu, Rosen" To: "Pei, Andy" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH] net/ipn3ke: delete unnecessary code Thread-Index: AQHVEGrIVitjbTPuLkio1Cnp5UxHkqZ3/XGg Date: Thu, 23 May 2019 02:28:44 +0000 Message-ID: <0E78D399C70DA940A335608C6ED296D73A76EAF4@SHSMSX104.ccr.corp.intel.com> References: <1558507524-350810-1-git-send-email-andy.pei@intel.com> In-Reply-To: <1558507524-350810-1-git-send-email-andy.pei@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGU5MDJhMjktZTI5Yi00NDUyLTgyNzUtYzcwM2VlNjMyYzRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicmM2ajhoMit6NjNZWlBhYnFZSlNsVzRBcWdYc2hCOUdpVmdSd0xFRjN2bzUyRWxWeXA4VGxaSEpENnpCYXBKUCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH] net/ipn3ke: delete unnecessary code X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Pei, Andy > Sent: Wednesday, May 22, 2019 14:45 > To: dev@dpdk.org > Cc: Pei, Andy ; Xu, Rosen ; > stable@dpdk.org > Subject: [PATCH] net/ipn3ke: delete unnecessary code >=20 > Whether the value of ret is true or false, the end target is always run. > It is unnecessary to check the value of ret, so just delete it. >=20 > Coverity issue: 337930 > Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver") > Cc: rosen.xu@intel.com > Cc: stable@dpdk.org >=20 > Signed-off-by: Andy Pei > --- > drivers/net/ipn3ke/ipn3ke_ethdev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.c > b/drivers/net/ipn3ke/ipn3ke_ethdev.c > index 9079b57..d88afa6 100644 > --- a/drivers/net/ipn3ke/ipn3ke_ethdev.c > +++ b/drivers/net/ipn3ke/ipn3ke_ethdev.c > @@ -581,8 +581,7 @@ static int ipn3ke_vswitch_remove(struct > rte_afu_device *afu_dev) > } >=20 > ret =3D ipn3ke_cfg_parse_i40e_pf_ethdev(afu_name, pf_name); > - if (ret) > - goto end; > + > end: > if (kvlist) > rte_kvargs_free(kvlist); > -- > 1.8.3.1 Acked-by: Rosen Xu