* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/qede: fix resource leak
[not found] <1480509129-27623-1-git-send-email-wang.yong19@zte.com.cn>
@ 2016-12-13 11:52 ` Ferruh Yigit
0 siblings, 0 replies; only message in thread
From: Ferruh Yigit @ 2016-12-13 11:52 UTC (permalink / raw)
To: Yong Wang, harish.patil; +Cc: dpdk stable, DPDK
On 11/30/2016 12:32 PM, Yong Wang wrote:
> Current code does not close 'fd' on function exit, leaking resources.
>
> Signed-off-by: Yong Wang <wang.yong19@zte.com.cn>
CC: stable@dpdk.org
> ---
> drivers/net/qede/qede_main.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
> index ab22409..b666e1c 100644
> --- a/drivers/net/qede/qede_main.c
> +++ b/drivers/net/qede/qede_main.c
> @@ -137,6 +137,7 @@ static int qed_load_firmware_data(struct ecore_dev *edev)
>
> if (fstat(fd, &st) < 0) {
> DP_NOTICE(edev, false, "Can't stat firmware file\n");
> + close(fd);
> return -1;
> }
>
> @@ -158,9 +159,11 @@ static int qed_load_firmware_data(struct ecore_dev *edev)
> if (edev->fw_len < 104) {
> DP_NOTICE(edev, false, "Invalid fw size: %" PRIu64 "\n",
> edev->fw_len);
> + close(fd);
> return -EINVAL;
> }
>
> + close(fd);
> return 0;
> }
> #endif
>
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-12-13 11:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1480509129-27623-1-git-send-email-wang.yong19@zte.com.cn>
2016-12-13 11:52 ` [dpdk-stable] [dpdk-dev] [PATCH] net/qede: fix resource leak Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).