Re: [PATCH V2 2/2] net/hns3: support backplane media type

[Dongdong Liu <liudongdong3@huawei.com>]

Hi Ferruh

On 2022/6/22 18:06, Ferruh Yigit wrote:
> On 6/22/2022 4:09 AM, Dongdong Liu wrote:
>> From: Chengwen Feng <fengchengwen@huawei.com>
>>
>> The 802.11 physical PMA sub-layer defines three media: copper, fiber and
>> backplane. For PMD, the backplane is similar to the fiber, the main
>> differences are that backplane doesn't have optical module.
>>
>> Because the interface of firmware fiber is also applicable to the
>> backplane, this patch supports the backplane only through simple
>> extension.
>>
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
>> Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
>> ---
>> v1->v2:
>> - document new 'backplane' media type support in release notes.
>> ---
>>   doc/guides/rel_notes/release_22_07.rst |  4 ++
>>   drivers/net/hns3/hns3_ethdev.c         | 54 ++++++++++++++------------
>>   2 files changed, 34 insertions(+), 24 deletions(-)
>>
>> diff --git a/doc/guides/rel_notes/release_22_07.rst
>> b/doc/guides/rel_notes/release_22_07.rst
>> index dd371952c3..7884ecfd09 100644
>> --- a/doc/guides/rel_notes/release_22_07.rst
>> +++ b/doc/guides/rel_notes/release_22_07.rst
>> @@ -172,6 +172,10 @@ New Features
>>       * Added support for yt8531s PHY.
>>   +* **Updated HiSilicon hns3 driver.**
>> +
>> +  * Added support for backplane media type.
>> +
>
> We are sorting PMD updates on vendor name, so can you please move update
> above Intel updates.
will do
>
> Except above minor release notes location order, patch looks good to me,
> but it requires hns3 maintainers ack/review to proceed. (Same for both
> patches.)

Lijun Ou and Min Hu current do not work for the hns3 driver.
I will do the work. I will send a patch to update the hns3 maintainers.

Thanks,
Dongdong
>
> Thanks,
> ferruh
> .
>