From: Declan Doherty <declan.doherty@intel.com>
To: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>,
pablo.de.lara.guarch@intel.com, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] crypto/openssl: fix that remove unneeded check
Date: Tue, 10 Jan 2017 09:28:11 +0000 [thread overview]
Message-ID: <0df6fc09-6d6e-f9fd-40e4-caae605469ff@intel.com> (raw)
In-Reply-To: <1483973136-154458-1-git-send-email-piotrx.t.azarewicz@intel.com>
On 09/01/17 14:45, Piotr Azarewicz wrote:
> EVP_CIPHER_CTX_set_padding() function always returns 1, so the check is
> unneeded.
>
> Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library")
>
> Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
> ---
> drivers/crypto/openssl/rte_openssl_pmd.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c
> index 832ea1d..312154a 100644
> --- a/drivers/crypto/openssl/rte_openssl_pmd.c
> +++ b/drivers/crypto/openssl/rte_openssl_pmd.c
> @@ -522,8 +522,7 @@
> if (EVP_DecryptInit_ex(ctx, algo, NULL, key, iv) <= 0)
> goto process_cipher_decrypt_err;
>
> - if (EVP_CIPHER_CTX_set_padding(ctx, 0) <= 0)
> - goto process_cipher_decrypt_err;
> + EVP_CIPHER_CTX_set_padding(ctx, 0);
>
> if (EVP_DecryptUpdate(ctx, dst, &dstlen, src, srclen) <= 0)
> goto process_cipher_decrypt_err;
>
Acked-by: Declan Doherty <declan.doherty@intel.com>
next prev parent reply other threads:[~2017-01-10 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 14:45 [dpdk-stable] " Piotr Azarewicz
2017-01-10 9:28 ` Declan Doherty [this message]
2017-01-10 13:53 ` [dpdk-stable] [dpdk-dev] " De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0df6fc09-6d6e-f9fd-40e4-caae605469ff@intel.com \
--to=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=piotrx.t.azarewicz@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).