From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Dongdong Liu <liudongdong3@huawei.com>,
jerinj@marvell.com, dev@dpdk.org,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Huisong Li <lihuisong@huawei.com>,
"Min Hu (Connor)" <humin29@huawei.com>
Cc: thomas@monjalon.net, david.marchand@redhat.com,
andrew.rybchenko@oktetlabs.ru, stable@dpdk.org
Subject: Re: [PATCH] net/hns3: fix build warning
Date: Fri, 7 Apr 2023 18:08:02 +0100 [thread overview]
Message-ID: <0f41fcd2-eee0-4eb4-b9d2-045f917f009a@amd.com> (raw)
In-Reply-To: <9edb30d6-e4c7-3c72-d95a-e46eb486886b@huawei.com>
On 4/4/2023 9:22 AM, Dongdong Liu wrote:
> Hi Jerin
>
> Many thanks for fixing the warning.
> On 2023/4/4 14:55, jerinj@marvell.com wrote:
>> From: Jerin Jacob <jerinj@marvell.com>
>>
>> aarch64 gcc 12.2.0 build complain with below warning[1].
>> Move the new_link initialization upwards to fix the warning.
>>
>> Compiling C object
>> drivers/libtmp_rte_net_hns3.a.p/net_hns3_hns3_ethdev.c.o
>> drivers/net/hns3/hns3_ethdev.c: In function ‘hns3_dev_link_update’:
>> drivers/net/hns3/hns3_ethdev.c:2249:1: warning: ‘new_link’ may be
>> used uninitialized [-Wmaybe-uninitialized]
> It looks like a false positive from the logic of the code.
> Anyway, this warning can be fixed by this patch, so
> Acked-by: Dongdong Liu <liudongdong3@huawei.com>
>
Agree that it looks false positive.
Moving memset upwards does unnecessary memset for some case but this can
be OK for control path function.
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2023-04-07 17:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 6:55 jerinj
2023-04-04 8:22 ` Dongdong Liu
2023-04-07 17:08 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f41fcd2-eee0-4eb4-b9d2-045f917f009a@amd.com \
--to=ferruh.yigit@amd.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=humin29@huawei.com \
--cc=jerinj@marvell.com \
--cc=lihuisong@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).