From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Steve Yang <stevex.yang@intel.com>, <dev@dpdk.org>
Cc: <beilei.xing@intel.com>, <stephen@networkplumber.org>, <stable@dpdk.org>
Subject: Re: [PATCH v3] net/i40e: fix unintentional integer overflow
Date: Fri, 25 Feb 2022 14:48:21 +0000 [thread overview]
Message-ID: <10077478-eb46-4f43-3f82-47c8a9306e98@intel.com> (raw)
In-Reply-To: <20220225023947.73045-1-stevex.yang@intel.com>
On 2/25/2022 2:39 AM, Steve Yang wrote:
> Cast 1 to type uint64_t to avoid overflow.
>
> CID 375812 (#1 of 1):
> Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN)
> overflow_before_widen: Potentially overflowing expression 1 << 2 * i + 1
> with type int (32 bits, signed) is evaluated using 32-bit arithmetic, and
> then used in a context that expects an expression of type uint64_t
> (64 bits, unsigned).
>
> Coverity issue: 375812
> Fixes: 5fec01c35c49 ("net/i40e: support Linux VF to configure IRQ link list")
> Cc: stable@dpdk.org
>
> ---
> v2: update commit message;
> v3: use RTE_BIT64() to set bit;
>
> Signed-off-by: Steve Yang <stevex.yang@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2022-02-25 14:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220223064147.3512888-1-stevex.yang@intel.com>
2022-02-24 1:17 ` [PATCH v2] " Steve Yang
2022-02-24 3:25 ` Zhang, Qi Z
2022-02-24 4:10 ` Stephen Hemminger
2022-02-24 6:21 ` Yang, SteveX
2022-02-24 11:42 ` Ferruh Yigit
2022-02-25 2:39 ` [PATCH v3] " Steve Yang
2022-02-25 14:48 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10077478-eb46-4f43-3f82-47c8a9306e98@intel.com \
--to=ferruh.yigit@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=stevex.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).