patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH 1/2] bus/dpaa: fix build with gcc 9.0
@ 2018-11-01 13:19 Ferruh Yigit
  2018-11-01 12:49 ` [dpdk-stable] [dpdk-dev] " Shreyansh Jain
                   ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: Ferruh Yigit @ 2018-11-01 13:19 UTC (permalink / raw)
  To: Thomas Monjalon, Hemant Agrawal, Shreyansh Jain; +Cc: dev, Ferruh Yigit, stable

build error:
In function ‘fman_if_init’,
    .../drivers/bus/dpaa/base/fman/fman.c:186:2:
    error: ‘strncpy’ output may be truncated copying 4095 bytes from a
           string of length 4095 [-Werror=stringop-truncation]
    strncpy(__if->node_path, dpa_node->full_name, PATH_MAX - 1);

strncpy may result a not null-terminated string,
replaced it with rte_strscpy

Fixes: 5b22cf744689 ("bus/dpaa: introducing FMan configurations")
Cc: stable@dpdk.org

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 drivers/bus/dpaa/base/fman/fman.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/dpaa/base/fman/fman.c b/drivers/bus/dpaa/base/fman/fman.c
index bdb700423..ddcd7d1f3 100644
--- a/drivers/bus/dpaa/base/fman/fman.c
+++ b/drivers/bus/dpaa/base/fman/fman.c
@@ -13,6 +13,7 @@
 #include <fman.h>
 #include <of.h>
 #include <rte_dpaa_logs.h>
+#include <rte_string_fns.h>
 
 #define QMI_PORT_REGS_OFFSET		0x400
 
@@ -183,7 +184,7 @@ fman_if_init(const struct device_node *dpa_node)
 	}
 	memset(__if, 0, sizeof(*__if));
 	INIT_LIST_HEAD(&__if->__if.bpool_list);
-	strncpy(__if->node_path, dpa_node->full_name, PATH_MAX - 1);
+	rte_strscpy(__if->node_path, dpa_node->full_name, PATH_MAX - 1);
 	__if->node_path[PATH_MAX - 1] = '\0';
 
 	/* Obtain the MAC node used by this interface except macless */
-- 
2.17.2

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2018-11-04 21:39 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-01 13:19 [dpdk-stable] [PATCH 1/2] bus/dpaa: fix build with gcc 9.0 Ferruh Yigit
2018-11-01 12:49 ` [dpdk-stable] [dpdk-dev] " Shreyansh Jain
2018-11-01 13:19 ` [dpdk-stable] [PATCH 2/2] eal: " Ferruh Yigit
2018-11-01 17:42 ` [dpdk-stable] [dpdk-dev] [PATCH 1/2] bus/dpaa: " Stephen Hemminger
2018-11-01 17:45   ` Bruce Richardson
2018-11-01 18:21     ` Ferruh Yigit
2018-11-01 19:45       ` Thomas Monjalon
2018-11-02 19:06 ` [dpdk-stable] [PATCH v2 " Ferruh Yigit
2018-11-02 19:06   ` [dpdk-stable] [PATCH v2 2/2] eal: " Ferruh Yigit
2018-11-04 21:38     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).