From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ciara Loftus <ciara.loftus@intel.com>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/af_xdp: change return value from Rx to unsigned
Date: Tue, 1 Sep 2020 16:10:27 +0100 [thread overview]
Message-ID: <1105b664-cad0-3420-2d55-6a622682b909@intel.com> (raw)
In-Reply-To: <6150bcd9-12e8-7d32-e0d8-a823f5b339e8@intel.com>
On 8/7/2020 11:07 AM, Ferruh Yigit wrote:
> On 8/7/2020 10:32 AM, Ciara Loftus wrote:
>> The af_xdp rx function was returning a negative value on error, when an
>> unsigned value is expected. Fix this.
>>
>> Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
>> ---
>> drivers/net/af_xdp/rte_eth_af_xdp.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c
>> index 936d4a7d5f..7ce4ad04af 100644
>> --- a/drivers/net/af_xdp/rte_eth_af_xdp.c
>> +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
>> @@ -236,7 +236,7 @@ af_xdp_rx_zc(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
>> if (rte_pktmbuf_alloc_bulk(umem->mb_pool, fq_bufs, nb_pkts)) {
>> AF_XDP_LOG(DEBUG,
>> "Failed to get enough buffers for fq.\n");
>> - return -1;
>> + return 0;
>> }
>>
>> rcvd = xsk_ring_cons__peek(rx, nb_pkts, &idx_rx);
>>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2020-09-01 15:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 9:32 Ciara Loftus
2020-08-07 10:07 ` Ferruh Yigit
2020-09-01 15:10 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1105b664-cad0-3420-2d55-6a622682b909@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).