From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6442CA046B for ; Fri, 28 Jun 2019 10:46:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6FE984C8E; Fri, 28 Jun 2019 10:46:12 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id C24CE4C8E; Fri, 28 Jun 2019 10:46:10 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jun 2019 01:46:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,427,1557212400"; d="scan'208";a="173415189" Received: from klaatz-mobl1.ger.corp.intel.com (HELO [10.237.221.70]) ([10.237.221.70]) by orsmga002.jf.intel.com with ESMTP; 28 Jun 2019 01:46:07 -0700 To: Ferruh Yigit , Thomas Monjalon Cc: dev@dpdk.org, stable@dpdk.org, Reshma Pattan , Flavia Musatescu References: <20190627195144.89720-1-ferruh.yigit@intel.com> From: "Laatz, Kevin" Message-ID: <114e7aba-06da-75b0-3459-7bac9c4119f1@intel.com> Date: Fri, 28 Jun 2019 09:46:07 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190627195144.89720-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-stable] [PATCH] telemetry: fix build X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 27/06/2019 20:51, Ferruh Yigit wrote: > Build error: > ../lib/librte_telemetry/rte_telemetry.c:558:28: > error: comparison of unsigned expression < 0 is always false > [-Werror,-Wtautological-compare] > > Build error not observed in default make build because telemetry library > disabled by default but easier to reproduce via meson. > > Fixing by converting unsigned variables to signed. > > Fixes: 0fe3a37924d4 ("telemetry: format json response when sending stats") > Fixes: 4080e46c8078 ("telemetry: support global metrics") > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit > --- > Cc: Reshma Pattan > Cc: Flavia Musatescu > --- > lib/librte_telemetry/rte_telemetry.c | 12 ++++++------ > lib/librte_telemetry/rte_telemetry_internal.h | 6 +++--- > 2 files changed, 9 insertions(+), 9 deletions(-) Acked-by: Kevin Laatz