From: santosh <santosh.shukla@caviumnetworks.com>
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Cc: olivier.matz@6wind.com, dev@dpdk.org, hemant.agrawal@nxp.com,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH 1/2] test/mempool_perf: Free mempool on exit
Date: Wed, 5 Apr 2017 18:03:43 +0530 [thread overview]
Message-ID: <11699bfc-4a59-31ed-1d68-098389f1350c@caviumnetworks.com> (raw)
In-Reply-To: <adff3d3a-a6bc-ea1b-ae9c-266a772fa21a@nxp.com>
Hi Shreyansh,
On Wednesday 05 April 2017 03:27 PM, Shreyansh Jain wrote:
> Hello Santosh,
> On Wednesday 05 April 2017 02:21 PM, Santosh Shukla wrote:
>> Mempool_perf test not freeing pool memory.
>> Cc: stable@dpdk.org
>> Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
>> ---
>> test/test/test_mempool_perf.c | 31 +++++++++++++++++++------------
>> 1 file changed, 19 insertions(+), 12 deletions(-)
>> diff --git a/test/test/test_mempool_perf.c b/test/test/test_mempool_perf.c
>> index ebf1721..3c45971 100644
>> --- a/test/test/test_mempool_perf.c
>> +++ b/test/test/test_mempool_perf.c
>> @@ -312,6 +312,8 @@ struct mempool_test_stats {
>> static int
>> test_mempool_perf(void)
>> {
>> + int ret = -1;
>> +
>> rte_atomic32_init(&synchro);
>> /* create a mempool (without cache) */
>> @@ -322,7 +324,7 @@ struct mempool_test_stats {
> Can you check why the patch is showing "struct mempool_test_stats" as
> the context?
> I tried creating this patch and it shows "test_mempool_perf(void)" as
> context.
> off the topic, does it matter to maintainers if context is not correct?
> t
That was because of older git-version i.e. < 2.x.
I upgraded to 2.11.0 and applied same patch then did 'git show' shows
correct context.
So in short; Posted patch won't break anything. if end user has
git version < 2.x then he'll see disparity in patch context however
> 2.x won't.
In anycase I will post v2. Thanks for pointing out.
diff --git a/test/test/test_mempool_perf.c b/test/test/test_mempool_perf.c
index ebf1721ac..3c45971ab 100644
--- a/test/test/test_mempool_perf.c
+++ b/test/test/test_mempool_perf.c
@@ -312,6 +312,8 @@ do_one_mempool_test(unsigned cores)
static int
test_mempool_perf(void)
{
+ int ret = -1;
+
rte_atomic32_init(&synchro);
/* create a mempool (without cache) */
@@ -322,7 +324,7 @@ test_mempool_perf(void)
my_obj_init, NULL,
SOCKET_ID_ANY, 0);
if (mp_nocache == NULL)
- return -1;
+ goto err;
[...]
> Other than that:
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
Thanks!,
>
next prev parent reply other threads:[~2017-04-05 12:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 8:51 Santosh Shukla
2017-04-05 9:57 ` Shreyansh Jain
2017-04-05 12:33 ` santosh [this message]
2017-04-06 6:45 ` [dpdk-stable] [PATCH v2 " Santosh Shukla
2017-04-07 15:51 ` Olivier Matz
[not found] ` <BLUPR0701MB17140B8FD2D59B1A7835769FEA0E0@BLUPR0701MB1714.namprd07.prod.outlook.com>
2017-04-09 19:43 ` santosh
2017-04-10 20:09 ` Olivier MATZ
2017-04-18 8:34 ` [dpdk-stable] [PATCH v3 1/3] test/test/mempool_perf: Remove mempool global vars Santosh Shukla
2017-04-18 8:34 ` [dpdk-stable] [PATCH v3 2/3] test/test/mempool_perf: Free mempool on exit Santosh Shukla
2017-04-18 13:42 ` [dpdk-stable] [PATCH v3 1/3] test/test/mempool_perf: Remove mempool global vars Olivier MATZ
2017-04-18 14:39 ` santosh
2017-04-18 14:41 ` [dpdk-stable] [PATCH v4 " Santosh Shukla
2017-04-18 14:41 ` [dpdk-stable] [PATCH v4 2/3] test/test/mempool_perf: Free mempool on exit Santosh Shukla
2017-04-18 15:31 ` [dpdk-stable] [PATCH v4 1/3] test/test/mempool_perf: Remove mempool global vars Olivier MATZ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11699bfc-4a59-31ed-1d68-098389f1350c@caviumnetworks.com \
--to=santosh.shukla@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=olivier.matz@6wind.com \
--cc=shreyansh.jain@nxp.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).