From: "Guo, Jia" <jia.guo@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>
Cc: "Xu, Ting" <ting.xu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ice/base: fix wrong outer ipv6 ptype table
Date: Tue, 8 Sep 2020 03:59:13 +0000 [thread overview]
Message-ID: <1205329527874f9e9c23a2dc01f5cde2@intel.com> (raw)
In-Reply-To: <20200906130145.44729-1-qi.z.zhang@intel.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Qi Zhang
> Sent: Sunday, September 6, 2020 9:02 PM
> To: Yang, Qiming <qiming.yang@intel.com>
> Cc: Xu, Ting <ting.xu@intel.com>; dev@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/ice/base: fix wrong outer ipv6 ptype table
>
> ptype 264, 265, 266, 267, 275 is should not be set in ice_ptypes_ipv6_ofos_all.
>
A tiny comment, "is" should be deleted, right? And I think ptype name is more readable than number when interpret the reason, you choose.
After that patch is ok.
Acked-by: Jeff Guo <jia.guo@intel.com>
> Fixes: 88824213be8a ("net/ice/base: enable RSS for PFCP/L2TP/ESP/AH")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/ice/base/ice_flow.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ice/base/ice_flow.c
> b/drivers/net/ice/base/ice_flow.c index 6035bdfcf..552e58f9b 100644
> --- a/drivers/net/ice/base/ice_flow.c
> +++ b/drivers/net/ice/base/ice_flow.c
> @@ -278,7 +278,7 @@ static const u32 ice_ptypes_ipv6_ofos[] = { static
> const u32 ice_ptypes_ipv6_ofos_all[] = {
> 0x00000000, 0x00000000, 0x77000000, 0x10002000,
> 0x00000000, 0x000002AA, 0x00000000, 0x00000000,
> - 0x00080F00, 0x03F00000, 0x7C1F0000, 0x00000206,
> + 0x00000000, 0x03F00000, 0x7C1F0000, 0x00000206,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> 0x00000000, 0x00000000, 0x00000000, 0x00000000,
> --
> 2.13.6
next prev parent reply other threads:[~2020-09-08 3:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-06 13:01 [dpdk-stable] " Qi Zhang
2020-09-08 3:59 ` Guo, Jia [this message]
2020-09-08 9:00 ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1205329527874f9e9c23a2dc01f5cde2@intel.com \
--to=jia.guo@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=ting.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).