* [dpdk-stable] [PATCH v2] bus/ifpga: fix forcing optional devargs
[not found] <1547430067-63007-1-git-send-email-andy.pei@intel.com>
@ 2019-01-18 11:07 ` Ferruh Yigit
2019-01-18 19:02 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Ferruh Yigit @ 2019-01-18 11:07 UTC (permalink / raw)
To: dev, Rosen Xu; +Cc: Andy Pei, stable, tianfei.zhang
From: Andy Pei <andy.pei@intel.com>
Original driver requires users to input "afu_bts" args.
But driver can also work without an explicit "afu_bts" args.
Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
Cc: stable@dpdk.org
Signed-off-by: Andy Pei <andy.pei@intel.com>
Acked-by: Rosen Xu <rosen.xu@intel.com>
---
Cc: rosen.xu@intel.com
Cc: tianfei.zhang@intel.com
---
drivers/bus/ifpga/ifpga_bus.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
index 5f23ed8b4..e4b7b6f50 100644
--- a/drivers/bus/ifpga/ifpga_bus.c
+++ b/drivers/bus/ifpga/ifpga_bus.c
@@ -125,15 +125,13 @@ ifpga_scan_one(struct rte_rawdev *rawdev,
IFPGA_AFU_BTS);
goto end;
}
+ afu_pr_conf.pr_enable = 1;
} else {
- IFPGA_BUS_ERR("arg %s is mandatory for ifpga bus",
- IFPGA_AFU_BTS);
- goto end;
+ afu_pr_conf.pr_enable = 0;
}
afu_pr_conf.afu_id.uuid.uuid_low = 0;
afu_pr_conf.afu_id.uuid.uuid_high = 0;
- afu_pr_conf.pr_enable = path?1:0;
if (ifpga_find_afu_dev(rawdev, &afu_pr_conf.afu_id))
goto end;
--
2.17.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] bus/ifpga: fix forcing optional devargs
2019-01-18 11:07 ` [dpdk-stable] [PATCH v2] bus/ifpga: fix forcing optional devargs Ferruh Yigit
@ 2019-01-18 19:02 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2019-01-18 19:02 UTC (permalink / raw)
To: Ferruh Yigit, Andy Pei; +Cc: dev, Rosen Xu, stable, tianfei.zhang
18/01/2019 12:07, Ferruh Yigit:
> From: Andy Pei <andy.pei@intel.com>
>
> Original driver requires users to input "afu_bts" args.
> But driver can also work without an explicit "afu_bts" args.
>
> Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
> Cc: stable@dpdk.org
>
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> Acked-by: Rosen Xu <rosen.xu@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-18 19:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1547430067-63007-1-git-send-email-andy.pei@intel.com>
2019-01-18 11:07 ` [dpdk-stable] [PATCH v2] bus/ifpga: fix forcing optional devargs Ferruh Yigit
2019-01-18 19:02 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).