From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id C9689187 for ; Mon, 30 Apr 2018 17:07:39 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6E3BA22C43; Mon, 30 Apr 2018 11:07:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 30 Apr 2018 11:07:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=1kBuxBSek8sRtqWotATf7Tu8P6 Sen7j/+xN9JjYFrVk=; b=ER72mVCf7BVs0GQ2V4Egsdxk/lonTcG6DCwGDF41wS /ypo9s5GDRMmnS7rvyMQm0P97vrSg+n0xC4/IGdqcscLwTidE/femLLbU+plNM77 FBCnakel0S7xDhUtm0jiyNAEhnyk335qh4t4ZAYNJs+GyqbwACfW09tFHLp4VvZI 8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=1kBuxB Sek8sRtqWotATf7Tu8P6Sen7j/+xN9JjYFrVk=; b=NmI0l0IiGUwOcuHRMAIoFP yMuWuzzfIL825QIgHz+S1VO4YuFN4w8b2xzMWMT7KjzbBkCouy1rXKsZB8hNoAzm 0kb/9ehGU4h5JlWewtWCtgNDiiikm4QcIT/AgyyBcSjgc8+23hMVVL1nqOe5imgA FlIKXzqVdOmXplefZ5T+LBeL7KDfj2VqlzEcIuAXVmhHZ8jeptCwLXOAMtiAJ6iG wHa8H+F+5RZtq0g9/6G8GG1OsNOBdcnXnR8q3BBpexV7EmHot71nS1oCX4PmITbp tLnDgtK+69celp1T7a+b4rfMY8Igb8S9s/FSkHvIX7jGoMbR5/Zjn8EgyyaSidcQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DF03EE4FE6; Mon, 30 Apr 2018 11:07:38 -0400 (EDT) From: Thomas Monjalon To: luca.boccassi@gmail.com Cc: dpdk stable Date: Mon, 30 Apr 2018 17:07:37 +0200 Message-ID: <12735445.Izu66BeJPl@xps> In-Reply-To: <20180430144223.18657-57-luca.boccassi@gmail.com> References: <20180430140606.4615-80-luca.boccassi@gmail.com> <20180430144223.18657-1-luca.boccassi@gmail.com> <20180430144223.18657-57-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] patch 'fix ethdev ports enumeration' has been queued to stable release 18.02.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Apr 2018 15:07:40 -0000 30/04/2018 16:41, luca.boccassi@gmail.com: > Hi, > > FYI, your patch has been queued to stable release 18.02.2 > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 05/02/18. So please > shout if anyone has objections. I did not plan to backport it. But yes, it may be a good idead. In this case, you need to backport some fixes on top of it: net/mvpp2: fix build ethdev: remove experimental flag of ports enumeration > --- > From beef7e18559abf272f9ca0a4d1b62f8d32c47b02 Mon Sep 17 00:00:00 2001 > From: Thomas Monjalon > Date: Thu, 5 Apr 2018 17:33:20 +0200 > Subject: [PATCH] fix ethdev ports enumeration > > [ upstream commit 8728ccf37615904cf23fb8763895b05c9a3c6b0c ] > > Some DPDK applications wrongly assume these requirements: > - no hotplug, i.e. ports are never detached > - all allocated ports are available to the application > > Such application iterates over ports by its own mean. > The most common pattern is to request the port count and > assume ports with index in the range [0..count[ can be used. > > There are three consequences when using such wrong design: > - new ports having an index higher than the port count won't be seen > - old ports being detached (RTE_ETH_DEV_UNUSED) can be seen as ghosts > - failsafe sub-devices (RTE_ETH_DEV_DEFERRED) will be seen by the application > > Such mistake will be less common with growing hotplug awareness. > All applications and examples inside this repository - except testpmd - > must be fixed to use the iterator RTE_ETH_FOREACH_DEV. > > Signed-off-by: Thomas Monjalon