From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 960E9A0A0B for ; Fri, 22 Jan 2021 03:38:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 87BDC140DCC; Fri, 22 Jan 2021 03:38:34 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 9AF0F140D95; Fri, 22 Jan 2021 03:38:31 +0100 (CET) IronPort-SDR: ZMaq+H9iE+GEf7ylFTkMM/1D5xtgHGrPr2JU5RaElAhecTcwm648l3I7DaklrCXuYcMp1dWSuI y4YsKMOJ5fmw== X-IronPort-AV: E=McAfee;i="6000,8403,9871"; a="158560830" X-IronPort-AV: E=Sophos;i="5.79,365,1602572400"; d="scan'208";a="158560830" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2021 18:38:26 -0800 IronPort-SDR: FW2eIWJhy19ifT/NiF0+xIdU6Djq6yOqRkg7WUWlAxMilAnUyKHhRMnp8W+18Ti8lHwY14z2qC s0ufy0kIoMNQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,365,1602572400"; d="scan'208";a="571915332" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga006.fm.intel.com with ESMTP; 21 Jan 2021 18:38:26 -0800 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 21 Jan 2021 18:38:25 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 22 Jan 2021 10:38:23 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Fri, 22 Jan 2021 10:38:23 +0800 From: "Zhang, Qi Z" To: "Wang, Haiyue" , "dev@dpdk.org" CC: "Yang, Qiming" , "Fu, Qi" , "stable@dpdk.org" Thread-Topic: [PATCH v3] net/ice: drain out DCF AdminQ command queue Thread-Index: AQHW8B2Bj2ywYweFyEu631GCGws2Kaoy7utQ Date: Fri, 22 Jan 2021 02:38:23 +0000 Message-ID: <12bf10fee3074d44be24451a2baedea7@intel.com> References: <220210121141804.83855-1-haiyue.wang@intel.com> <20210121173137.108599-1-haiyue.wang@intel.com> In-Reply-To: <20210121173137.108599-1-haiyue.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH v3] net/ice: drain out DCF AdminQ command queue X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Wang, Haiyue > Sent: Friday, January 22, 2021 1:32 AM > To: dev@dpdk.org > Cc: Yang, Qiming ; Zhang, Qi Z > ; Fu, Qi ; Wang, Haiyue > ; stable@dpdk.org > Subject: [PATCH v3] net/ice: drain out DCF AdminQ command queue >=20 > The virtchnl message is handled one by one by checking opcode to match th= e > response for the request. >=20 > The DCF AdminQ command with buffer needs two virtchnl commands, one is to > handle the AdminQ descriptor, the other is to the handle AdminQ buffer. I= f both > of them are sent to PF successfully, it needs to wait two responses from = PF, > even if the AdminQ descriptor command gets the failure response. Since PF= will > handle them one by one, and send back the response for each. >=20 > If not wait for the buffer message response until timeout to drain out th= e > virtchnl command queue, it will cause the next AdminQ command with buffer= to > get the stall buffer response from previous. >=20 > Fixes: daa714d55c72 ("net/ice: handle AdminQ command by DCF") > Cc: stable@dpdk.org >=20 > Signed-off-by: Haiyue Wang Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi