* [dpdk-stable] [PATCH] devtools/test-meson-build: fix CC override for cross builds
@ 2018-06-08 10:35 Bruce Richardson
2018-06-14 15:47 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Bruce Richardson @ 2018-06-08 10:35 UTC (permalink / raw)
To: thomas; +Cc: dev, Bruce Richardson, stable
For cross-builds the CC environmental variable only applies for compiling
native binaries i.e. pmdinfogen, so setting it to a cross-build compiler
will only cause problems. Leave the value unset in the script to use the
platform-default compiler.
Fixes: a55277a788df ("devtools: add test script for meson builds")
CC: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
devtools/test-meson-builds.sh | 1 -
1 file changed, 1 deletion(-)
diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
index 9868c325b..f2ad05f32 100755
--- a/devtools/test-meson-builds.sh
+++ b/devtools/test-meson-builds.sh
@@ -41,6 +41,5 @@ for f in config/arm/arm*gcc ; do
if ! command -v $c >/dev/null 2>&1 ; then
continue
fi
- export CC="ccache $c"
build build-$(basename $f | tr '_' '-' | cut -d'-' -f-2) --cross-file $f
done
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-stable] [PATCH] devtools/test-meson-build: fix CC override for cross builds
2018-06-08 10:35 [dpdk-stable] [PATCH] devtools/test-meson-build: fix CC override for cross builds Bruce Richardson
@ 2018-06-14 15:47 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2018-06-14 15:47 UTC (permalink / raw)
To: Bruce Richardson; +Cc: stable, dev
08/06/2018 12:35, Bruce Richardson:
> For cross-builds the CC environmental variable only applies for compiling
> native binaries i.e. pmdinfogen, so setting it to a cross-build compiler
> will only cause problems. Leave the value unset in the script to use the
> platform-default compiler.
>
> Fixes: a55277a788df ("devtools: add test script for meson builds")
>
> CC: stable@dpdk.org
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-14 15:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-08 10:35 [dpdk-stable] [PATCH] devtools/test-meson-build: fix CC override for cross builds Bruce Richardson
2018-06-14 15:47 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).