* [dpdk-stable] [PATCH v3] eventdev: fix Rx adapter event flush logic
[not found] <1557376797-10609-1-git-send-email-nikhil.rao@intel.com>
@ 2019-05-10 8:08 ` Nikhil Rao
2019-05-10 13:30 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Nikhil Rao @ 2019-05-10 8:08 UTC (permalink / raw)
To: thomas; +Cc: jerinj, dev, matias.elo, Nikhil Rao, stable
The Rx adapter flushes events only if it has BATCH_SIZE
events buffered where BATCH_SIZE is set to 32, e.g., if a
single packet is sent, it is never passed to
eventdev. Fix this issue by adding an event buffer flush
either when a Rx queue is found to be empty or the adapter service
function has processed the max number of packets for an invocation.
Bugzilla ID: 277
Fixes: 6b83f5935543 ("eventdev: add event buffer flush in Rx adapter")
Reported-by: Matias Elo <matias.elo@nokia.com>
CC: stable@dpdk.org
Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
---
lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
v2:
* add Bugzilla ID
v3:
* add stable CC
* replace boolean check with check for > 0
diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
index 8b6e69d..b60674b 100644
--- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
@@ -872,7 +872,7 @@ static uint16_t rxa_gcd_u16(uint16_t a, uint16_t b)
break;
}
- if (buf->count >= BATCH_SIZE)
+ if (buf->count > 0)
rxa_flush_event_buffer(rx_adapter);
return nb_rx;
--
1.8.3.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [PATCH v3] eventdev: fix Rx adapter event flush logic
2019-05-10 8:08 ` [dpdk-stable] [PATCH v3] eventdev: fix Rx adapter event flush logic Nikhil Rao
@ 2019-05-10 13:30 ` Thomas Monjalon
2019-05-10 16:13 ` [dpdk-stable] [dpdk-dev] " Mattias Rönnblom
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Monjalon @ 2019-05-10 13:30 UTC (permalink / raw)
To: dev; +Cc: stable, Nikhil Rao, jerinj, matias.elo
Any review please?
10/05/2019 10:08, Nikhil Rao:
> The Rx adapter flushes events only if it has BATCH_SIZE
> events buffered where BATCH_SIZE is set to 32, e.g., if a
> single packet is sent, it is never passed to
> eventdev. Fix this issue by adding an event buffer flush
> either when a Rx queue is found to be empty or the adapter service
> function has processed the max number of packets for an invocation.
>
> Bugzilla ID: 277
>
> Fixes: 6b83f5935543 ("eventdev: add event buffer flush in Rx adapter")
>
> Reported-by: Matias Elo <matias.elo@nokia.com>
>
> CC: stable@dpdk.org
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
> lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> v2:
> * add Bugzilla ID
>
> v3:
> * add stable CC
> * replace boolean check with check for > 0
>
> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> index 8b6e69d..b60674b 100644
> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> @@ -872,7 +872,7 @@ static uint16_t rxa_gcd_u16(uint16_t a, uint16_t b)
> break;
> }
>
> - if (buf->count >= BATCH_SIZE)
> + if (buf->count > 0)
> rxa_flush_event_buffer(rx_adapter);
>
> return nb_rx;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v3] eventdev: fix Rx adapter event flush logic
2019-05-10 13:30 ` Thomas Monjalon
@ 2019-05-10 16:13 ` Mattias Rönnblom
2019-05-13 4:20 ` Elo, Matias (Nokia - FI/Espoo)
0 siblings, 1 reply; 5+ messages in thread
From: Mattias Rönnblom @ 2019-05-10 16:13 UTC (permalink / raw)
To: Thomas Monjalon, dev; +Cc: stable, Nikhil Rao, jerinj, matias.elo
On 2019-05-10 15:30, Thomas Monjalon wrote:
> Any review please?
>
Reviewed-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
Mattias Elo reported "Thanks, I’ve tested this patch and can confirm
that it fixes the problem." for the (nearly identical) v2 of this patch.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v3] eventdev: fix Rx adapter event flush logic
2019-05-10 16:13 ` [dpdk-stable] [dpdk-dev] " Mattias Rönnblom
@ 2019-05-13 4:20 ` Elo, Matias (Nokia - FI/Espoo)
2019-05-13 14:00 ` Thomas Monjalon
0 siblings, 1 reply; 5+ messages in thread
From: Elo, Matias (Nokia - FI/Espoo) @ 2019-05-13 4:20 UTC (permalink / raw)
To: Thomas Monjalon
Cc: dev, stable, Nikhil Rao, Jerin Jacob Kollanukkaran,
Mattias Rönnblom
> On 2019-05-10 15:30, Thomas Monjalon wrote:
>> Any review please?
>
> Reviewed-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
>
> Mattias Elo reported "Thanks, I’ve tested this patch and can confirm that it fixes the problem." for the (nearly identical) v2 of this patch.
I’ve now tested also the v3:
Tested-by: Matias Elo <matias.elo@nokia.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v3] eventdev: fix Rx adapter event flush logic
2019-05-13 4:20 ` Elo, Matias (Nokia - FI/Espoo)
@ 2019-05-13 14:00 ` Thomas Monjalon
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2019-05-13 14:00 UTC (permalink / raw)
To: Nikhil Rao
Cc: dev, Elo, Matias (Nokia - FI/Espoo),
stable, Jerin Jacob Kollanukkaran, Mattias Rönnblom
13/05/2019 06:20, Elo, Matias (Nokia - FI/Espoo):
>
> > On 2019-05-10 15:30, Thomas Monjalon wrote:
> >> Any review please?
> >
> > Reviewed-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> >
> > Mattias Elo reported "Thanks, I’ve tested this patch and can confirm that it fixes the problem." for the (nearly identical) v2 of this patch.
>
> I’ve now tested also the v3:
>
> Tested-by: Matias Elo <matias.elo@nokia.com>
Applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-13 14:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1557376797-10609-1-git-send-email-nikhil.rao@intel.com>
2019-05-10 8:08 ` [dpdk-stable] [PATCH v3] eventdev: fix Rx adapter event flush logic Nikhil Rao
2019-05-10 13:30 ` Thomas Monjalon
2019-05-10 16:13 ` [dpdk-stable] [dpdk-dev] " Mattias Rönnblom
2019-05-13 4:20 ` Elo, Matias (Nokia - FI/Espoo)
2019-05-13 14:00 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).