From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ori Kam <orika@mellanox.com>, Xiao Zhang <xiao.zhang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "qi.z.zhang@intel.com" <qi.z.zhang@intel.com>,
"wei.zhao1@intel.com" <wei.zhao1@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [v2] app/testpmd: fix PPPOES flow API
Date: Wed, 8 Apr 2020 15:44:22 +0100 [thread overview]
Message-ID: <1386b745-1a21-bd52-e4a6-9880cbf1d399@intel.com> (raw)
In-Reply-To: <AM6PR05MB517636F46C385D4ECA62209DDBC50@AM6PR05MB5176.eurprd05.prod.outlook.com>
On 4/5/2020 4:12 PM, Ori Kam wrote:
> Hi Xiao,
>
>
>
>> -----Original Message-----
>> From: Xiao Zhang <xiao.zhang@intel.com>
>> Sent: Tuesday, March 31, 2020 4:30 PM
>> To: dev@dpdk.org
>> Cc: Ori Kam <orika@mellanox.com>; qi.z.zhang@intel.com;
>> wei.zhao1@intel.com; Xiao Zhang <xiao.zhang@intel.com>; stable@dpdk.org
>> Subject: [v2] app/testpmd: fix PPPOES flow API
>>
>> The command line to create RTE flow for specific proto_id of PPPOES can
>> not work.
>>
>> It was:
>> testpmd> flow create 0 ingress pattern proto_id
>> proto_id [TOKEN]: match PPPoE session protocol identifier
>> testpmd> flow create 0 ingress pattern proto_id proto_id
>> proto_id [TOKEN]: match PPPoE session protocol identifier
>> testpmd> flow create 0 ingress pattern proto_id proto_id proto_id
>> proto_id [TOKEN]: match PPPoE session protocol identifier
>>
>> The proto_id can not be set with previous implementation.
>>
>> This patch is to fix this issue, and change the command line to:
>> testpmd> flow create 0 pattern pppoe_proto_id is xxxx
>>
>> Fixes: 226c6e60c35b ("ethdev: add PPPoE to flow API")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Xiao Zhang <xiao.zhang@intel.com>
>> ---
>> v2 change the command line according to review comments.
>> ---
>
> Acked-by: Ori Kam <orika@mellanox.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2020-04-08 14:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 8:19 [dpdk-stable] " Xiao Zhang
2020-03-29 6:27 ` Ori Kam
2020-03-29 9:06 ` Zhang, Xiao
2020-03-29 10:18 ` Ori Kam
2020-03-29 12:00 ` Zhang, Xiao
2020-03-29 12:45 ` Ori Kam
2020-03-30 2:08 ` Zhang, Xiao
2020-03-30 7:42 ` Ori Kam
2020-03-30 8:49 ` Zhao1, Wei
2020-03-30 8:57 ` Ori Kam
2020-03-30 14:22 ` Zhang, Xiao
2020-03-31 6:55 ` Ori Kam
2020-03-31 8:13 ` Zhang, Xiao
2020-03-31 9:05 ` Ori Kam
2020-03-31 13:04 ` Zhang, Xiao
2020-03-31 13:29 ` [dpdk-stable] [v2] " Xiao Zhang
2020-04-05 15:12 ` Ori Kam
2020-04-08 14:44 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386b745-1a21-bd52-e4a6-9880cbf1d399@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=orika@mellanox.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
--cc=xiao.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).