* [dpdk-stable] [PATCH] eal/x86: remove unused memcpy file
@ 2018-11-09 13:46 Thomas Monjalon
2018-11-09 17:35 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2018-11-09 13:46 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, stable, xiaoyun.li
The use of rte_memcpy_ptr was removed in revert below,
but it was missing removing the file arch/x86/rte_memcpy.c.
Fixes: d35cc1fe6a7a ("eal/x86: revert select optimized memcpy at run-time")
Cc: stable@dpdk.org
Cc: xiaoyun.li@intel.com
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
lib/librte_eal/common/arch/x86/rte_memcpy.c | 29 ---------------------
1 file changed, 29 deletions(-)
delete mode 100644 lib/librte_eal/common/arch/x86/rte_memcpy.c
diff --git a/lib/librte_eal/common/arch/x86/rte_memcpy.c b/lib/librte_eal/common/arch/x86/rte_memcpy.c
deleted file mode 100644
index 648c8f680..000000000
--- a/lib/librte_eal/common/arch/x86/rte_memcpy.c
+++ /dev/null
@@ -1,29 +0,0 @@
-/* SPDX-License-Identifier: BSD-3-Clause
- * Copyright(c) 2010-2017 Intel Corporation
- */
-
-#include <rte_memcpy.h>
-#include <rte_cpuflags.h>
-#include <rte_log.h>
-
-void *(*rte_memcpy_ptr)(void *dst, const void *src, size_t n) = NULL;
-
-RTE_INIT(rte_memcpy_init)
-{
-#ifdef CC_SUPPORT_AVX512F
- if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F)) {
- rte_memcpy_ptr = rte_memcpy_avx512f;
- RTE_LOG(DEBUG, EAL, "AVX512 memcpy is using!\n");
- return;
- }
-#endif
-#ifdef CC_SUPPORT_AVX2
- if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2)) {
- rte_memcpy_ptr = rte_memcpy_avx2;
- RTE_LOG(DEBUG, EAL, "AVX2 memcpy is using!\n");
- return;
- }
-#endif
- rte_memcpy_ptr = rte_memcpy_sse;
- RTE_LOG(DEBUG, EAL, "Default SSE/AVX memcpy is using!\n");
-}
--
2.19.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-stable] [PATCH] eal/x86: remove unused memcpy file
2018-11-09 13:46 [dpdk-stable] [PATCH] eal/x86: remove unused memcpy file Thomas Monjalon
@ 2018-11-09 17:35 ` Ferruh Yigit
2018-11-11 23:13 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2018-11-09 17:35 UTC (permalink / raw)
To: Thomas Monjalon, dev; +Cc: stable, xiaoyun.li
On 11/9/2018 1:46 PM, Thomas Monjalon wrote:
> The use of rte_memcpy_ptr was removed in revert below,
> but it was missing removing the file arch/x86/rte_memcpy.c.
>
> Fixes: d35cc1fe6a7a ("eal/x86: revert select optimized memcpy at run-time")
> Cc: stable@dpdk.org
> Cc: xiaoyun.li@intel.com
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-stable] [PATCH] eal/x86: remove unused memcpy file
2018-11-09 17:35 ` Ferruh Yigit
@ 2018-11-11 23:13 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2018-11-11 23:13 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: stable, dev, xiaoyun.li
09/11/2018 18:35, Ferruh Yigit:
> On 11/9/2018 1:46 PM, Thomas Monjalon wrote:
> > The use of rte_memcpy_ptr was removed in revert below,
> > but it was missing removing the file arch/x86/rte_memcpy.c.
> >
> > Fixes: d35cc1fe6a7a ("eal/x86: revert select optimized memcpy at run-time")
> > Cc: stable@dpdk.org
> > Cc: xiaoyun.li@intel.com
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-11 23:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-09 13:46 [dpdk-stable] [PATCH] eal/x86: remove unused memcpy file Thomas Monjalon
2018-11-09 17:35 ` Ferruh Yigit
2018-11-11 23:13 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).