Re: [dpdk-stable] [dpdk-dev] [PATCH v3] build: disable armv8 crypto extension

[Thomas Monjalon <thomas@monjalon.net>]

13/05/2019 21:26, Honnappa Nagarahalli:
> > 
> > Per armv8 crypto extension support, make build always enable it by default as
> > long as compiler supports the feature while meson build only enables it for
> > 'default' machine of generic armv8 architecture.
> > 
> > It is known that not all the armv8 platforms have the crypto extension. For
> > example, Mellanox BlueField has a variant which doesn't have it. If crypto
> > enabled binary runs on such a platform, rte_eal_init() fails.
> > 
> > '+crypto' flag currently implies only '+aes' and '+sha2' and enabling it will
> > generate the crypto instructions only when crypto intrinsics are used.
> > For the devices supporting 8.2 crypto or newer, compiler could generate such
> > instructions beyond intrinsics or asm code. For example, compiler can generate
> > 3-way exclusive OR instructions if sha3 is supported. However, it has to be
> > enabled by adding '+sha3' as of today.
> > 
> > In DPDK, armv8 cryptodev is the only one which requires the crypto support.
> > As it even uses external library of Marvell which is compiled out of DPDK with
> > crypto support and there's run-time check for required cpuflags, crypto
> > support can be disabled in DPDK.
> > 
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
> > Tested-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> 
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

Applied, thanks