* [dpdk-stable] [PATCH] test: enable installing test app with meson
@ 2019-07-24 15:47 Anatoly Burakov
2019-07-24 15:50 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: Anatoly Burakov @ 2019-07-24 15:47 UTC (permalink / raw)
To: dev; +Cc: thomas, harry.van.haaren, bruce.richardson, stable
Currently, the test app is not being installed by default when
built and installed with meson build system. Fix that to enable
installation of the test app alongside other DPDK apps.
Fixes: b5dc795a8a55 ("test: build app with meson as dpdk-test")
Cc: harry.van.haaren@intel.com
Cc: bruce.richardson@intel.com
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
app/test/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/meson.build b/app/test/meson.build
index 1834897bf..c50b20275 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -359,7 +359,7 @@ dpdk_test = executable('dpdk-test',
dependencies: test_dep_objs,
c_args: [cflags, '-DALLOW_EXPERIMENTAL_API'],
install_rpath: driver_install_path,
- install: false)
+ install: true)
# some perf tests (eg: memcpy perf autotest)take very long
# to complete, so timeout to 10 minutes
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [PATCH] test: enable installing test app with meson
2019-07-24 15:47 [dpdk-stable] [PATCH] test: enable installing test app with meson Anatoly Burakov
@ 2019-07-24 15:50 ` Bruce Richardson
2019-07-30 9:03 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2019-07-24 15:50 UTC (permalink / raw)
To: Anatoly Burakov; +Cc: dev, thomas, harry.van.haaren, stable
On Wed, Jul 24, 2019 at 04:47:31PM +0100, Anatoly Burakov wrote:
> Currently, the test app is not being installed by default when
> built and installed with meson build system. Fix that to enable
> installation of the test app alongside other DPDK apps.
>
> Fixes: b5dc795a8a55 ("test: build app with meson as dpdk-test")
> Cc: harry.van.haaren@intel.com
> Cc: bruce.richardson@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> app/test/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test/meson.build b/app/test/meson.build
> index 1834897bf..c50b20275 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
> @@ -359,7 +359,7 @@ dpdk_test = executable('dpdk-test',
> dependencies: test_dep_objs,
> c_args: [cflags, '-DALLOW_EXPERIMENTAL_API'],
> install_rpath: driver_install_path,
> - install: false)
> + install: true)
>
I see no major reason not to have it installed - if anyone does not want
the test app, they can disable it completely using the meson option
"tests". Therefore:
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] test: enable installing test app with meson
2019-07-24 15:50 ` Bruce Richardson
@ 2019-07-30 9:03 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2019-07-30 9:03 UTC (permalink / raw)
To: Anatoly Burakov; +Cc: dev, Bruce Richardson, harry.van.haaren, stable
24/07/2019 17:50, Bruce Richardson:
> On Wed, Jul 24, 2019 at 04:47:31PM +0100, Anatoly Burakov wrote:
> > Currently, the test app is not being installed by default when
> > built and installed with meson build system. Fix that to enable
> > installation of the test app alongside other DPDK apps.
> >
> > Fixes: b5dc795a8a55 ("test: build app with meson as dpdk-test")
> > Cc: harry.van.haaren@intel.com
> > Cc: bruce.richardson@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> I see no major reason not to have it installed - if anyone does not want
> the test app, they can disable it completely using the meson option
> "tests". Therefore:
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-30 9:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-24 15:47 [dpdk-stable] [PATCH] test: enable installing test app with meson Anatoly Burakov
2019-07-24 15:50 ` Bruce Richardson
2019-07-30 9:03 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).