From: Thomas Monjalon <thomas@monjalon.net>
To: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
Cc: dev@dpdk.org, stable@dpdk.org,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Xueming Li <xuemingl@nvidia.com>, Marcin Wojtas <mw@semihalf.com>,
Michal Krawczyk <mk@semihalf.com>,
Shai Brandes <shaibran@amazon.com>,
Evgeny Schemeilin <evgenys@amazon.com>,
Igor Chauskin <igorch@amazon.com>,
Parav Pandit <parav@nvidia.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Long Li <longli@microsoft.com>
Subject: Re: [dpdk-stable] [PATCH v4] bus: clarify log for non-NUMA-aware devices
Date: Fri, 30 Jul 2021 18:18:34 +0200 [thread overview]
Message-ID: <14406363.YTmczRCzET@thomas> (raw)
In-Reply-To: <20210728220618.1048721-1-dkozlyuk@nvidia.com>
29/07/2021 00:06, Dmitry Kozlyuk:
> EAL: PCI device 0000:00:06.0 on NUMA socket -1
> - EAL: Invalid NUMA socket, default to 0
> + EAL: Device is not NUMA-aware, defaulting socket to 0
> EAL: probe driver: 1d0f:ec20 net_ena
The indentation in logs are wrong because they are not all
at the same log level.
If you run at a non-debug-level, you lose the first line,
so the indent becomes meaningless and confusing.
[...]
> - AUXILIARY_LOG(INFO, "Device is not NUMA-aware, defaulting NUMA node to 0");
> + if (rte_socket_count() > 1)
> + AUXILIARY_LOG(INFO, " Device is not NUMA-aware, defaulting socket to
0");
Instead of adding an indent, I would prefer we print the device name.
And we should remove log indents in other bus drivers.
next prev parent reply other threads:[~2021-07-30 16:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 10:51 [dpdk-stable] [PATCH] " Dmitry Kozlyuk
2021-06-15 15:12 ` [dpdk-stable] [dpdk-dev] " Stephen Hemminger
2021-06-16 10:07 ` [dpdk-stable] [PATCH v2] " Dmitry Kozlyuk
2021-07-23 20:07 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2021-07-27 8:08 ` Dmitry Kozlyuk
2021-07-27 10:27 ` [dpdk-stable] [PATCH v3] " Dmitry Kozlyuk
2021-07-28 22:06 ` [dpdk-stable] [PATCH v4] " Dmitry Kozlyuk
2021-07-29 7:45 ` Andrew Rybchenko
2021-07-30 16:18 ` Thomas Monjalon [this message]
2021-08-04 8:03 ` [dpdk-stable] [PATCH v5] " Dmitry Kozlyuk
2021-08-04 9:34 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14406363.YTmczRCzET@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=dkozlyuk@nvidia.com \
--cc=evgenys@amazon.com \
--cc=igorch@amazon.com \
--cc=longli@microsoft.com \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
--cc=parav@nvidia.com \
--cc=shaibran@amazon.com \
--cc=stable@dpdk.org \
--cc=sthemmin@microsoft.com \
--cc=viacheslavo@nvidia.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).