patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH v2] eal: fix header files install with meson
       [not found] <20191126081637.23008-1-alialnu@mellanox.com>
@ 2019-11-26 10:51 ` Ali Alnubani
  2019-11-26 11:17   ` Thomas Monjalon
  2019-11-26 15:38 ` [dpdk-stable] [PATCH v3] eal: fix header file " Ali Alnubani
  1 sibling, 1 reply; 5+ messages in thread
From: Ali Alnubani @ 2019-11-26 10:51 UTC (permalink / raw)
  To: dev; +Cc: bruce.richardson, stable, Thomas Monjalon

The following header files weren't being installed by meson:
  - rte_vfio.h
  - rte_function_versioning.h
  - rte_test.h

This patch adds them to the common_headers list so that
they are installed.

Fixes: 610beca42ea4 ("build: remove library special cases")
Cc: bruce.richardson@intel.com
Cc: stable@dpdk.org

Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
v2: updated commit title and added a fixes tag.

 lib/librte_eal/common/meson.build | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build
index d6a149bec..71d0c50ce 100644
--- a/lib/librte_eal/common/meson.build
+++ b/lib/librte_eal/common/meson.build
@@ -64,6 +64,7 @@ common_headers = files(
 	'include/rte_eal_interrupts.h',
 	'include/rte_errno.h',
 	'include/rte_fbarray.h',
+	'include/rte_function_versioning.h',
 	'include/rte_hexdump.h',
 	'include/rte_hypervisor.h',
 	'include/rte_interrupts.h',
@@ -84,9 +85,11 @@ common_headers = files(
 	'include/rte_service_component.h',
 	'include/rte_string_fns.h',
 	'include/rte_tailq.h',
+	'include/rte_test.h',
 	'include/rte_time.h',
 	'include/rte_uuid.h',
-	'include/rte_version.h')
+	'include/rte_version.h',
+	'include/rte_vfio.h')
 
 # special case install the generic headers, since they go in a subdir
 generic_headers = files(
-- 
2.24.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-stable] [PATCH v2] eal: fix header files install with meson
  2019-11-26 10:51 ` [dpdk-stable] [PATCH v2] eal: fix header files install with meson Ali Alnubani
@ 2019-11-26 11:17   ` Thomas Monjalon
  2019-11-26 13:25     ` Bruce Richardson
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Monjalon @ 2019-11-26 11:17 UTC (permalink / raw)
  To: Ali Alnubani; +Cc: dev, bruce.richardson, stable

26/11/2019 11:51, Ali Alnubani:
> The following header files weren't being installed by meson:
>   - rte_vfio.h
>   - rte_function_versioning.h
>   - rte_test.h
> 
> This patch adds them to the common_headers list so that
> they are installed.
> 
> Fixes: 610beca42ea4 ("build: remove library special cases")

I am not sure this is the right root cause.
At least for rte_function_versioning.h, it has been added recently.

> Cc: bruce.richardson@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>




^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-stable] [PATCH v2] eal: fix header files install with meson
  2019-11-26 11:17   ` Thomas Monjalon
@ 2019-11-26 13:25     ` Bruce Richardson
  0 siblings, 0 replies; 5+ messages in thread
From: Bruce Richardson @ 2019-11-26 13:25 UTC (permalink / raw)
  To: Thomas Monjalon; +Cc: Ali Alnubani, dev, stable

On Tue, Nov 26, 2019 at 12:17:41PM +0100, Thomas Monjalon wrote:
> 26/11/2019 11:51, Ali Alnubani:
> > The following header files weren't being installed by meson:
> >   - rte_vfio.h
> >   - rte_function_versioning.h
> >   - rte_test.h
> > 
> > This patch adds them to the common_headers list so that
> > they are installed.
> > 
> > Fixes: 610beca42ea4 ("build: remove library special cases")
> 
> I am not sure this is the right root cause.
> At least for rte_function_versioning.h, it has been added recently.
> 

Thanks for pointing this out. The rte_function_versioning.h file I
deliberately omitted from the meson install since it's really for internal
use only. It's not really recommended for external app use, since it relies
on some DPDK defines etc.

> > Cc: bruce.richardson@intel.com
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> > Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> 
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dpdk-stable] [PATCH v3] eal: fix header file install with meson
       [not found] <20191126081637.23008-1-alialnu@mellanox.com>
  2019-11-26 10:51 ` [dpdk-stable] [PATCH v2] eal: fix header files install with meson Ali Alnubani
@ 2019-11-26 15:38 ` " Ali Alnubani
  2019-11-26 16:13   ` Thomas Monjalon
  1 sibling, 1 reply; 5+ messages in thread
From: Ali Alnubani @ 2019-11-26 15:38 UTC (permalink / raw)
  To: dev; +Cc: bruce.richardson, stable, Thomas Monjalon

The header file 'rte_vfio.h' might be required by some external apps.
This patch adds it to the list of common_headers so that it's
installed by meson.

Fixes: 610beca42ea4 ("build: remove library special cases")
Cc: bruce.richardson@intel.com
Cc: stable@dpdk.org

Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
v2: updated commit title and added a fixes tag.
v3: removed rte_test.h and rte_function_versioning.h.

 lib/librte_eal/common/meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/common/meson.build b/lib/librte_eal/common/meson.build
index d6a149bec..2b97715a2 100644
--- a/lib/librte_eal/common/meson.build
+++ b/lib/librte_eal/common/meson.build
@@ -86,7 +86,8 @@ common_headers = files(
 	'include/rte_tailq.h',
 	'include/rte_time.h',
 	'include/rte_uuid.h',
-	'include/rte_version.h')
+	'include/rte_version.h',
+	'include/rte_vfio.h')
 
 # special case install the generic headers, since they go in a subdir
 generic_headers = files(
-- 
2.24.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-stable] [PATCH v3] eal: fix header file install with meson
  2019-11-26 15:38 ` [dpdk-stable] [PATCH v3] eal: fix header file " Ali Alnubani
@ 2019-11-26 16:13   ` Thomas Monjalon
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2019-11-26 16:13 UTC (permalink / raw)
  To: Ali Alnubani; +Cc: dev, bruce.richardson, stable

26/11/2019 16:38, Ali Alnubani:
> The header file 'rte_vfio.h' might be required by some external apps.
> This patch adds it to the list of common_headers so that it's
> installed by meson.
> 
> Fixes: 610beca42ea4 ("build: remove library special cases")
> Cc: bruce.richardson@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
> Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20191126081637.23008-1-alialnu@mellanox.com>
2019-11-26 10:51 ` [dpdk-stable] [PATCH v2] eal: fix header files install with meson Ali Alnubani
2019-11-26 11:17   ` Thomas Monjalon
2019-11-26 13:25     ` Bruce Richardson
2019-11-26 15:38 ` [dpdk-stable] [PATCH v3] eal: fix header file " Ali Alnubani
2019-11-26 16:13   ` Thomas Monjalon

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox