From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id BDD88F72 for ; Wed, 2 Nov 2016 11:21:29 +0100 (CET) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP; 02 Nov 2016 03:21:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,583,1473145200"; d="scan'208";a="26465843" Received: from yliu-dev.sh.intel.com ([10.239.67.162]) by fmsmga006.fm.intel.com with ESMTP; 02 Nov 2016 03:21:28 -0700 From: Yuanhan Liu To: Qi Zhang Date: Wed, 2 Nov 2016 18:21:36 +0800 Message-Id: <1478082097-16957-40-git-send-email-yuanhan.liu@linux.intel.com> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1478082097-16957-1-git-send-email-yuanhan.liu@linux.intel.com> References: <1478082097-16957-1-git-send-email-yuanhan.liu@linux.intel.com> Cc: Jingjing Wu , dpdk stable Subject: [dpdk-stable] patch 'net/i40e: fix Rx hang when disable LLDP' has been queued to stable release 16.07.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Nov 2016 10:21:30 -0000 Hi, FYI, your patch has been queued to stable release 16.07.2 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/06/16. So please shout if anyone has objections. Thanks. --yliu --- >>From 0eb2ca5d015391c8fad324ca5f4b048149f4c427 Mon Sep 17 00:00:00 2001 From: Qi Zhang Date: Thu, 20 Oct 2016 04:40:13 +0800 Subject: [PATCH] net/i40e: fix Rx hang when disable LLDP [ upstream commit fcbd40d4327b36725c4de9f33f57809edc359f4a ] Remove stopping LLDP as a workaround for a known errata which can cause Rx hang. Ref: Item #70 from http://www.intel.com/content/www/us/en/embedded/products/networking/xl710-10-40-controller-spec-update.html Fixes: 4861cde46116 ("i40e: new poll mode driver") Signed-off-by: Qi Zhang Acked-by: Jingjing Wu --- drivers/net/i40e/i40e_ethdev.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 4ad98e3..7614525 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -1235,11 +1235,6 @@ eth_i40e_dev_uninit(struct rte_eth_dev *dev) dev->rx_pkt_burst = NULL; dev->tx_pkt_burst = NULL; - /* Disable LLDP */ - ret = i40e_aq_stop_lldp(hw, true, NULL); - if (ret != I40E_SUCCESS) /* Its failure can be ignored */ - PMD_INIT_LOG(INFO, "Failed to stop lldp"); - /* Clear PXE mode */ i40e_clear_pxe_mode(hw); @@ -9197,10 +9192,6 @@ i40e_dcb_init_configure(struct rte_eth_dev *dev, bool sw_dcb) * LLDP MIB change event. */ if (sw_dcb == TRUE) { - ret = i40e_aq_stop_lldp(hw, TRUE, NULL); - if (ret != I40E_SUCCESS) - PMD_INIT_LOG(DEBUG, "Failed to stop lldp"); - ret = i40e_init_dcb(hw); /* if sw_dcb, lldp agent is stopped, the return from * i40e_init_dcb we expect is failure with I40E_AQ_RC_EPERM -- 1.9.0